Robert Bragg
4355621aeb
group: make it comparable to ClutterBox
...
There is a lot of duplication between ClutterGroup and ClutterBox so
this makes the two files diff-able so that new fixes can easily be
ported to both and bug fixes missing in one or the other can be spotted
more easily. This doesn't change the behaviour of either actor; it's
really just a shuffle around of code and normalizes the coding style to
make the files comparable.
This has already uncovered one bug in ClutterBox, and also highlights
a bug in ClutterGroup + many other actors:
1) ClutterGroup::real_foreach was recently changed to use
g_list_foreach instead of manually iterating the child list so it can
safely handle calls like:
clutter_container_foreach (container, clutter_actor_destroy);
ClutterBox is still manually iterating the list.
2) In ClutterGroup we guard _queue_redraw() calls like this:
if (CLUTTER_ACTOR_IS_VISIBLE (container))
clutter_actor_queue_redraw (CLUTTER_ACTOR (container));
In ClutterBox we don't:
I think ClutterBox is correct here because
clutter_actor_queue_redraw already optimizes the case where the
actor's not visible, but it also considers that the actor may be
cloned and so the guard in ClutterGroup could break clones. This
actually highlights a wider clutter bug since the same kinds of
guards can be found in all other clutter actors.
2010-02-12 12:31:24 +00:00
..
2010-02-11 15:59:53 +00:00
2009-10-16 18:58:50 +01:00
2009-10-16 18:58:50 +01:00
2009-10-16 18:58:50 +01:00
2010-02-10 15:04:53 +00:00
2009-10-18 17:11:42 +01:00
2009-11-06 11:48:42 +00:00
2010-02-03 16:34:27 +00:00
2010-02-09 22:19:41 +00:00
2010-02-09 10:34:41 +00:00
2010-01-20 00:38:08 +00:00
2010-02-08 15:45:43 +00:00
2009-01-20 18:47:50 +00:00
2009-05-27 13:01:31 +01:00
2009-05-27 13:01:31 +01:00
2010-02-08 15:45:43 +00:00
2009-08-25 12:16:41 +01:00
2010-02-08 17:55:29 +00:00
2010-02-08 17:37:00 +00:00
2010-02-10 15:04:53 +00:00
2009-10-16 18:58:47 +01:00
2009-01-23 13:08:46 +00:00
2009-03-16 15:00:55 +00:00
2009-06-19 16:38:35 +01:00
2009-06-19 16:38:35 +01:00
2010-02-02 12:54:51 +00:00
2009-03-16 15:00:55 +00:00
2009-02-20 12:09:07 +00:00
2009-11-19 11:51:21 +00:00
2009-06-19 16:38:35 +01:00
2009-06-19 16:38:35 +01:00
2009-06-19 16:38:35 +01:00
2009-06-19 16:38:35 +01:00
2009-11-06 11:39:30 +00:00
2009-01-20 16:42:49 +00:00
2009-01-20 16:20:54 +00:00
2008-12-05 13:13:37 +00:00
2010-02-09 16:58:03 +00:00
2009-10-14 11:31:29 +01:00
2009-11-17 21:32:17 +00:00
2009-01-14 15:03:30 +00:00
2009-12-23 10:36:46 +00:00
2009-12-13 01:15:02 +00:00
2010-02-12 12:31:24 +00:00
2009-12-04 16:54:22 +00:00
2009-06-15 12:41:13 +01:00
2009-05-14 15:53:59 +01:00
2009-02-20 12:09:07 +00:00
2009-03-16 15:00:55 +00:00
2009-10-22 15:51:06 +01:00
2009-03-16 15:00:55 +00:00
2009-10-26 16:29:31 +00:00
2009-06-29 21:37:02 +02:00
2009-09-22 17:55:04 +01:00
2009-05-28 17:18:13 +01:00
2010-02-09 22:19:41 +00:00
2009-07-21 09:22:38 +01:00
2010-01-20 00:38:53 +00:00
2010-01-20 00:38:08 +00:00
2009-05-29 12:40:23 +01:00
2007-08-20 20:16:15 +00:00
2010-01-20 00:38:08 +00:00
2010-01-20 00:38:08 +00:00
2010-02-03 16:34:27 +00:00
2010-02-09 22:19:41 +00:00
2009-10-14 11:31:30 +01:00
2009-10-14 11:31:29 +01:00
2009-03-10 12:38:04 +00:00
2009-03-10 12:38:04 +00:00
2010-02-09 16:58:03 +00:00
2009-10-14 11:31:30 +01:00
2010-02-01 10:40:34 +00:00
2009-03-16 15:40:18 +00:00
2010-02-12 12:31:24 +00:00
2009-04-08 18:19:46 +01:00
2009-10-07 12:53:19 +01:00
2008-10-30 17:04:34 +00:00
2010-02-10 17:13:33 +00:00
2010-01-20 00:38:09 +00:00
2009-10-16 15:57:21 +01:00
2009-01-08 11:15:09 +00:00
2009-08-12 15:31:16 +01:00
2008-06-10 06:37:46 +00:00
2008-08-05 10:54:40 +00:00
2009-12-23 10:37:10 +00:00
2009-12-13 01:23:54 +00:00
2009-10-14 11:31:26 +01:00
2009-12-02 11:36:25 +00:00
2009-05-12 16:31:41 +01:00
2009-02-14 11:31:00 +00:00
2010-02-10 17:20:31 +00:00
2009-12-07 19:00:55 +00:00
2010-01-20 00:38:07 +00:00
2010-02-09 22:19:41 +00:00
2009-07-10 11:38:42 +01:00
2010-01-11 13:04:16 +00:00
2010-01-11 13:04:16 +00:00
2009-05-05 20:18:28 +01:00
2009-09-10 13:28:54 +01:00
2009-05-20 16:06:09 +01:00
2010-02-04 21:10:02 +00:00
2009-10-06 10:43:41 +01:00
2010-02-09 22:19:41 +00:00
2010-01-08 20:19:50 +00:00
2010-01-08 20:19:50 +00:00
2009-06-30 17:13:38 +01:00
2009-03-16 15:00:55 +00:00
2009-03-17 14:13:31 +00:00
2009-03-16 15:00:55 +00:00
2010-02-08 15:45:43 +00:00
2010-02-08 15:45:43 +00:00
2009-11-06 14:07:46 +00:00
2009-03-16 15:00:55 +00:00
2009-02-26 14:57:58 +00:00
2008-10-30 17:04:34 +00:00
2009-07-27 15:01:52 +01:00
2009-05-12 14:53:44 +01:00
2009-06-01 17:40:23 +01:00
2009-04-03 12:47:21 +01:00
2009-10-19 12:01:38 +01:00
2009-12-02 11:38:04 +00:00
2010-02-09 22:19:41 +00:00
2010-02-09 22:19:41 +00:00
2010-02-09 22:19:41 +00:00
2010-02-06 11:23:37 +00:00
2010-02-10 15:45:54 +00:00
2010-02-03 14:38:13 +00:00
2010-01-13 15:13:10 +00:00
2009-05-23 19:35:19 +01:00
2009-09-16 11:57:57 +01:00
2009-06-19 16:38:35 +01:00
2010-02-01 10:40:34 +00:00
2009-03-16 15:40:18 +00:00
2010-02-01 10:40:34 +00:00
2009-03-16 15:40:18 +00:00
2010-02-07 18:25:19 +00:00
2009-10-16 15:55:05 +01:00
2009-10-16 15:25:37 +01:00
2010-02-06 10:49:33 +00:00
2010-02-06 10:49:33 +00:00
2009-10-30 11:02:35 +00:00
2010-02-07 18:25:19 +00:00
2010-02-10 10:58:14 +00:00