mirror of
https://github.com/brl/mutter.git
synced 2025-02-13 03:44:11 +00:00
3bbfaa03b3
The cache had the size 9, which was "big enough" in the past, but when more ways pipelines could be constructed, the size was not enough. The need to increase the cache size was hard to spot though, since adding pipeline flag didn't give any hints about the cache being directly tied to these flag values. So, when enough flag bits were set when attempting to retrieve and put a pipeline in the cache, it'd instead overwrite some arbitrary stack memory, which would sooner or later result in a memory corruption induced crash. Valgrind could not detect this particular memory corruption, as it messed up stack memory, not e.g. freed heap memory, so it instead got confused and thought plain stack values were unreadable. Fix these two issues by making the cache size the combination of all pipeline flags + 1, so that we can safely put any flag combination in the cache. Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1747>
Intro
=====
In general, the compositor splits the window from the contents of
the window from the shape of the window. In other words, a window
has contents, and the contents of the window have a shape. This is
represented by the actor hierarchy:
+--------------------------------------+
| MetaWindowActor |
| +----------------------------------+ |
| | MetaSurfaceActor | |
| | +------------------------------+ | |
| | | MetaShapedTexture | | |
| | | | | |
| | | | | |
| | | | | |
| | | | | |
| | +------------------------------+ | |
| +----------------------------------+ |
+--------------------------------------+
Surfaces may also contain subsurfaces. The MetaWindowActor and
MetaSurfaceActor subclasses that will be created depend on the client
type, and the display server type.
## Subsurfaces
Additionally, there is also the case of subsurfaces: surfaces that
are child of other surfaces. That is also represented in the actor
hierarchy by having one or many MetaSurfaceActors (the subsurfaces)
added as children of a parent MetaSurfaceActor. There are no limits
to how many subsurfaces a surface may have. With subsurfaces, the
actor hierarchy looks like this:
MetaWindowActor
↳ MetaSurfaceActor (surface)
↳ MetaShapedTexture
↳ MetaSurfaceActor (subsurface)
↳ MetaShapedTexture
↳ MetaSurfaceActor (sub-subsurface)
↳ MetaShapedTexture
↳ MetaSurfaceActor (subsurface)
↳ MetaShapedTexture
In this example, the main surface has 2 subsurfaces. One of these
subsurfaces contains a subsurface as well.
All MetaWindowActors contain at least one MetaSurfaceActor, and all
MetaSurfaceActors contain a MetaShapedTexture.
## Client and compositor
MetaWindowActor and its subclasses represent the client window's
type. A X11 client will have a MetaWindowActorX11 representing it,
and a Wayland client will have a MetaWindowActorWayland.
On the compositor side, the surface where the contents of the window
are drawn into are represented by MetaSurfaceActor subclasses. On a
Wayland session, windows are backed by a MetaSurfaceActorWayland
surface, whereas on X11 sessions, by MetaSurfaceActorX11.
XWayland windows are X11 client windows (MetaWindowActorX11) backed
by Wayland surfaces (MetaWindowActorWayland).
Env Vars
========
MUTTER_DISABLE_MIPMAPS - set to disable use of mipmaped windows.