e470fd7d82
Currently, only clutter_model_iter_set_valist() is in charge of emitting the ClutterModel::row-changed signal. Both the set() and the set_valist() functions can be called with multiple columns, so we coalesce the signal emission at the end of the set_valist(), to have a single ::row-changed emission per change. The clutter_model_iter_set_value() function is just a thin wrapper around the set_value() virtual function, but since it's called internally we cannot add the signal emission there as well, as we'd break the signal coalescing. For this reason, we need some code refactoring inside the various set() variants of ClutterModelIter: - we only use the internal va_arg variant for both the set() and set_valist() public functions, to avoid multiple type checks; - the internal set_valist() calls an internal set_value() method which calls the virtual function from the iterator vtable; - a new internal emit_row_changed() method is needed to retrieve the ClutterModel from the iterator, and emit the signal; Now, all three variants of the value setter will call an internal ClutterModelIter::set_value() wrapper, and emit the ::row-changed signal. To check that the intended behaviour has been implemented, and it's not going to be broken, the test suite has grown a new unit which populates a model and changes a random row. |
||
---|---|---|
.. | ||
ADDING_NEW_TESTS | ||
Makefile.am | ||
run-tests.sh | ||
test-actor-destroy.c | ||
test-actor-invariants.c | ||
test-actor-size.c | ||
test-anchors.c | ||
test-animator.c | ||
test-behaviours.c | ||
test-binding-pool.c | ||
test-cally-text.c | ||
test-clutter-cairo-texture.c | ||
test-clutter-rectangle.c | ||
test-clutter-text.c | ||
test-clutter-texture.c | ||
test-clutter-units.c | ||
test-cogl-atlas-migration.c | ||
test-cogl-backface-culling.c | ||
test-cogl-blend-strings.c | ||
test-cogl-depth-test.c | ||
test-cogl-fixed.c | ||
test-cogl-just-vertex-shader.c | ||
test-cogl-materials.c | ||
test-cogl-multitexture.c | ||
test-cogl-npot-texture.c | ||
test-cogl-object.c | ||
test-cogl-offscreen.c | ||
test-cogl-path.c | ||
test-cogl-pipeline-user-matrix.c | ||
test-cogl-pixel-buffer.c | ||
test-cogl-premult.c | ||
test-cogl-primitive.c | ||
test-cogl-readpixels.c | ||
test-cogl-sub-texture.c | ||
test-cogl-texture-3d.c | ||
test-cogl-texture-get-set-data.c | ||
test-cogl-texture-mipmaps.c | ||
test-cogl-texture-pixmap-x11.c | ||
test-cogl-texture-rectangle.c | ||
test-cogl-vertex-buffer-contiguous.c | ||
test-cogl-vertex-buffer-interleved.c | ||
test-cogl-vertex-buffer-mutability.c | ||
test-cogl-viewport.c | ||
test-cogl-wrap-modes.c | ||
test-color.c | ||
test-conform-common.c | ||
test-conform-common.h | ||
test-conform-main.c | ||
test-group.c | ||
test-launcher.sh.in | ||
test-model.c | ||
test-offscreen-redirect.c | ||
test-paint-opacity.c | ||
test-path.c | ||
test-pick.c | ||
test-score.c | ||
test-script-parser.c | ||
test-state.c | ||
test-text-cache.c | ||
test-texture-fbo.c | ||
test-timeline-interpolate.c | ||
test-timeline-rewind.c | ||
test-timeline.c |