Jonas Dreßler
e76877c4b8
extensionSystem: Check if extension exists before accessing property
...
If the extension doesn't exist in the `this._extensions` Map, we'd try
to access `extension.dir` on undefined/null. So set the `dir` variable
after checking if `extension` is defined.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/96
2019-09-12 10:24:49 +00:00
Jonas Dreßler
2a32fb2e72
extensionSystem: Fix a wrong error message
...
The extension object is added to the `this._extensions` Map inside
`createExtensionObject`, not inside `loadExtension`.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/96
2019-09-12 10:24:49 +00:00
Jonas Dreßler
de86920e0e
extensionSystem: Remove unncessary return statements
...
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/96
2019-09-12 10:24:49 +00:00
Jonas Dreßler
8754736fda
extensionUtils: Check version variable for undefined first
...
Avoid a warning message when trying to access requiredArray[2] by
checking if its undefined first.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/96
2019-09-12 10:24:49 +00:00
Iain Lane
d2ead59d74
data: Lower TimeoutStartSec in systemd units
...
If there's a stubborn process in our cgroup, we shouldn't hang around
waiting for the default (30 seconds) before the session closes. We've
logged out, SIGTERMed and the thing is refusing to go away, let's not
make people hang around for ages.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/699
2019-09-12 08:16:10 +00:00
Emin Tufan Çetin
2f4fcc59a1
Update Turkish translation
2019-09-12 04:26:07 +00:00
Florian Müllner
ba6dbb228d
workspace: Minor clarification
...
Code and comment were based on the old get_input_rect() and get_outer_rect()
method names that were changed to the more appropriate get_buffer_rect() and
get_frame_rect() a long time ago.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/713
2019-09-11 23:32:16 +00:00
Florian Müllner
60e386048b
backgroundMenu: Animate menu opening
...
The animation was removed in commit 6a00a504d4
for consistency with
other menus. However commit a9b12d5d73
then *added* animations to
those just four minutes later.
So add back the original animations for consistency, both with menu
closing and with other menus.
https://gitlab.gnome.org/GNOME/gnome-shell/issues/1595
2019-09-11 23:25:21 +00:00
Christian Kirbach
c2904fa14d
Update German translation
2019-09-11 21:14:44 +00:00
Florian Müllner
dfdb139d9c
workspaceThumbnails: Replace loops with Array.find()
...
This is much more idiomatic and concise than iterating over
thumbnails until we find the one we are looking for.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/710
2019-09-11 20:59:31 +00:00
Florian Müllner
ce63d21dcc
overview: Minor cleanup
...
Safe one indentation level by combining conditions.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/710
2019-09-11 20:59:31 +00:00
Florian Müllner
1da9937453
workspace: Use operator shorthand
...
Shorthands like a += b are well-established, so prefer them over the
less concise a = a + b.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/710
2019-09-11 20:59:31 +00:00
Florian Müllner
9f11fbad16
jsParse: Disambiguate regex
...
Make it clear that /= is part of a regex and not an operator shorthand.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/710
2019-09-11 20:59:31 +00:00
Florian Müllner
f54e7804c5
workspace: Don't initialize variables to undefined
...
The declaration itself already does this implicitly.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/710
2019-09-11 20:59:31 +00:00
Florian Müllner
7db5f8b28e
calendar: Use template strings over concatenation
...
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/710
2019-09-11 20:59:31 +00:00
Florian Müllner
743ce23fbc
util: Separate statements with linebreak
...
Our eslint rules will soon forbid more than one statement per line.
We already follow that rule except for one lone offender; fix that.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/710
2019-09-11 20:59:31 +00:00
Florian Müllner
a3267be192
network: Don't omit parens when constructing
...
While it is legal to omit parentheses when invoking a constructor
with no arguments, we generally avoid that in our coding style.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/710
2019-09-11 20:59:31 +00:00
Florian Müllner
4ad2523877
messageTray: Add missing linebreak
...
Methods should be separated by an empty lines, even when short.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/710
2019-09-11 20:59:31 +00:00
Florian Müllner
4bfee3a8ca
ibusManager: Wrap line before dot
...
When chaining function calls, our coding style asks for the dot to
start the new line, not end the preceding one.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/710
2019-09-11 20:59:31 +00:00
Florian Müllner
fc964f975a
kbdA11yDialog: Avoid unnecessary ternary operators
...
A condition is already boolean, there's no point in explicitly
turning it into true/false.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/710
2019-09-11 20:59:31 +00:00
Florian Müllner
52f85c9465
system: Properly separate statements
...
Whoops, that's some typo that sneaked into commit 9c3b3320f8
...
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/710
2019-09-11 20:59:31 +00:00
Florian Müllner
691610f23c
lookingGlass: Fix misleading typeof use
...
typeof is an operator, not a function. Putting unneeded parentheses
around the expression obfuscates that.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/710
2019-09-11 20:59:31 +00:00
Florian Müllner
b6a2b2b8a5
cleanup: Remove left-over imports
...
Unfortunately this slipped through our CI tests, as the script
filters errors by lines that are modified by the corresponding
merge request.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/710
2019-09-11 20:59:31 +00:00
Daniel Șerbănescu
1ad8a2fcf6
Update Romanian translation
2019-09-11 20:13:21 +00:00
Balázs Úr
7ce08845f1
Update Hungarian translation
2019-09-11 20:11:51 +00:00
Aurimas Černius
d469250130
Updated Lithuanian translation
2019-09-11 22:37:29 +03:00
Jordi Mas
7fd5c47e06
Update Catalan translation
2019-09-11 21:21:08 +02:00
Kukuh Syafaat
8704b1004e
Update Indonesian translation
2019-09-11 18:31:47 +00:00
Piotr Drąg
65a9fb8c01
Update Polish translation
2019-09-11 19:22:04 +02:00
Florian Müllner
25a7a8006a
gnome-extensions: Translate help command
...
The quotes and COMMAND string aren't part of the syntax, so they
should be translated.
https://gitlab.gnome.org/GNOME/gnome-shell/issues/1538
2019-09-11 17:09:30 +00:00
Marek Černocký
6fe1d3248a
Updated Czech translation
2019-09-11 18:01:13 +02:00
Jonas Dreßler
13f97532bf
overviewControls: Remove slide transitions before setting value manually
...
Remove transitions of the `slide-x` property of the layout manager
before we set the property to a fixed value, otherwise the transitions
might still be running and change the value after we set it.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/707
2019-09-11 11:39:44 +00:00
Anders Jonsson
1acee3d702
Update Swedish translation
2019-09-10 23:53:06 +00:00
Marco Trevisan (Treviño)
1d17404471
selectArea: Ignore motion events once we got a result
...
When selecting an area for screenshot we monitor the events while we've valid
coordinates in order to redraw the rubber band.
However, we don't stop ignore the motion events after button release and so
while animating. This might cause an unwanted effect if moving the mouse away
during fade out that is way more visible slowing-down the animations.
To fix this ignore any motion event once we've set the results.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/711
2019-09-10 22:08:25 +02:00
Florian Müllner
48b860b69f
ci: Turn on -Werror
...
Now that all compiler warnings are fixed, let's try to keep it that
way by making warnings fatal during CI.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/709
2019-09-10 17:51:02 +00:00
Florian Müllner
a030c54661
shell: Replace another GTimeVal
...
This slipped through in commit 9b7f228f8e
.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/709
2019-09-10 17:51:02 +00:00
Florian Müllner
dcf7bae6c7
calendar-server: Temporarily ignore all deprecations in eds includes
...
Evolution draws in libsoup, which exposes deprecated types in its
API. While its headers have been fixed to guard the affected symbols,
those fixes aren't in our CI images yet.
Until we get a fixed version, just disable all deprecation warnings
during the include in order to not trip over "foreign" bugs.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/709
2019-09-10 17:51:02 +00:00
Florian Müllner
d0ace108e5
calendar-server: Disable deprecated e-d-s API
...
We aren't using any deprecated evolution-data-server API, so we can
turn it off; this avoids compiler warnings for glib deprecations
used by those functions, which makes it harder to spot warnings for
our own code base.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/709
2019-09-10 17:51:02 +00:00
Florian Müllner
32d5744014
build: Exclude private headers from GIR
...
They contain API that is explicitly not meant to be used externally
and - as it uses the "wrong" namespace due to the _ prefix - doesn't
end up in the introspection data anyway.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/709
2019-09-10 17:51:02 +00:00
Florian Müllner
d16094774b
build: Remove st-private.h from "public" headers
...
It is currently listed both as public and private header, which is
clearly bonkers. As the name implies, the latter is correct ...
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/709
2019-09-10 17:51:02 +00:00
Piotr Drąg
ac664ba321
Update Polish translation
2019-09-10 17:58:11 +02:00
Florian Müllner
0888a9bffd
environment: Skip property animations while hidden
...
For implicit animations, Clutter will skip any transitions while
an actor is unmapped, and just set the property directly. Do the
same in our ease_property() convencience method.
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/708
2019-09-10 14:41:26 +00:00
Daniel Mustieles
5e82d72424
Updated Spanish translation
2019-09-10 15:56:03 +02:00
Jiri Grönroos
2513835e89
Update Finnish translation
2019-09-10 11:11:21 +00:00
Kukuh Syafaat
98b70ef00f
Update Indonesian translation
2019-09-10 07:12:48 +00:00
Daniel Șerbănescu
ae11381b88
Update Romanian translation
2019-09-10 06:48:29 +00:00
Milo Casagrande
e9596f2775
Update Italian translation
2019-09-10 06:47:05 +00:00
Balázs Úr
8adbc8010a
Update Hungarian translation
2019-09-10 04:40:55 +00:00
Fran Dieguez
76fb559964
Update Galician translation
2019-09-09 22:45:51 +00:00
Rafael Fontenelle
1bc1b4d9d8
Update Brazilian Portuguese translation
2019-09-09 22:44:55 +00:00