18427 Commits

Author SHA1 Message Date
Florian Müllner
3dec080324 data: Strip blanks from SVG icons
The size reduction will be modest, but given that there's no downside,
it's still a good idea.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3107>
2024-01-17 04:30:11 +00:00
Florian Müllner
2df9b025eb ci: Bump mutter image
... to pull in an up-to-date gsettings-desktop-schemas version.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3107>
2024-01-17 04:30:11 +00:00
Florian Müllner
7e0209f905 build: Make g-ir-scanner warnings fatal when werror is set
This should help catching problems with introspection in CI.

Adapted from Sebastian Wick's corresponding mutter change
in https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3528.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3121>
2024-01-16 23:51:13 +00:00
Barnabás Pőcze
c227d0b38e status/backlight: Do only one dbus call per local change
The values of the two control widgets are syncronized, meaning
that both emit signals when the local value changes, regardless
which one is visible and is actually used by the user.

This is not ideal because it leads to two dbus calls
per local change. To alleviate this, only consider
changes from the widget that is visible.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3086>
2024-01-16 23:30:42 +00:00
Barnabás Pőcze
be944ff2dc status/backlight: Fix keyboard backlight infinite loop
The logic could enter an infinite loop because it tried to
propagate local changes to g-s-d that were caused by signals sent
by g-s-d. For example:

  1. slider is set to 50
  2. Set(50) dbus call is sent
  3. slider is set to 51
  4. Set(51) dbus call is sent
  5. PropertiesChanged arrives due to Set(50)
  6. this._sliderItem.value is set to 50
  7. notify::value is emitted from this._sliderItem
  8. Set(50) dbus call is sent
  9. PropertiesChanged arrives due to Set(51)
 10. this._sliderItem.value is set to 51
 11. notify::value is emitted from this._sliderItem
 12. Set(51) dbus call is sent

To alleviate this issue, block signal handlers when the local state is
changed due to a remote event.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7111

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3086>
2024-01-16 23:30:42 +00:00
A S Alam
f2e51cb722 Update Punjabi translation 2024-01-16 13:35:23 +00:00
Sam Hewitt
7abe91918f style: Add lockscreen style to entry drawing mixin
- include style condition to entry drawing mixin to accommodate transparent bg on lockscreen
- see https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6802 and https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3109#note_1970652

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7326
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3118>
2024-01-15 22:45:25 +00:00
Florian Müllner
17b7162121 closeDialog: Close existing dialogs on shutdown
Otherwise mutter will request to hide the dialog when the meta
context is destroyed, but at the JS context has already shut down,
resulting in a crash.

Close https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7328

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3117>
2024-01-15 22:40:47 +00:00
Florian Müllner
655eb672d6 tools/toolbox: Add meson test convenience wrapper
It can be fairly tedious to enter a toolbox and invoke `meson test`
with the right build directory, so add a companion script to the
existing meson-build.sh to handle that.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3114>
2024-01-15 17:27:46 +00:00
Florian Müllner
96ecdba855 tools/toolbox: Expose --wipe meson flag
It's useful when the existing build directory became invalid,
for instance after a meson update, and exposing it directly
from the wrapper script is more convenient than removing the
directory or entering the toolbox manually to invoke meson.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3113>
2024-01-15 17:18:09 +00:00
Florian Müllner
26e8408b92 tools/toolbox: Consistently handle option parsing failures
`getopt` already prints a message on parse errors, but it still
seems like good style to point to --help as we do elsewhere.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3113>
2024-01-15 17:18:09 +00:00
Florian Müllner
f1422dff83 tools/toolbox: Consistently abort on failure
Unlike the other scripts, meson-build currently doesn't set
the `-e` option. The script is mainly a wrapper around a single
toolbox call, but it means that any errors during option parsing
print a warning, but are otherwise ignored.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3113>
2024-01-15 17:18:09 +00:00
Florian Müllner
41b94ccf11 extensions-app: Remember window state
It's good practice to save and reload the window size and
maximization state, and easy enough to implement, so let's
do that.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3115>
2024-01-13 23:44:35 +01:00
Danial Behzadi
2d380a3995 Update Persian translation 2024-01-13 00:49:29 +00:00
Florian Müllner
3099bfc571 tests: Add fittsy test
Both the dash and top bar items are expected to extend to the
screen edge, to make them easier click targets according to
Fitts' law.

This has the tendency to break fairly regularly, so add a small
test that checks the Fittsiness of the show-apps and activities
buttons to catch regressions.

Related: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7318
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3111>
2024-01-12 20:29:10 +00:00
Sam Hewitt
b3d3fb79ae style: Fix panel and dash to account for mouse travel
- rework overview-icon styles for the dash so they extend to the edge of the screen once again
- revert changes to panel_button mixin
- rework panel_button mixin to be more flexible
- fixes #7318

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3112>
2024-01-12 16:14:59 +00:00
Florian Müllner
3f4f74689e notificationDaemon: Stop special-casing Empathy
Our telepathy component has been optional for years, and it is
disabled by default on major distros, so we cannot assume that
it handles any particular notifications.

Plus Empathy itself is mostly dead, so it's unlikely to be used
much anymore anyway.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3110>
2024-01-12 14:23:23 +00:00
Sam Hewitt
a917644fad style: Refactor the button and entry drawing css
- use a single button mixin for all buttons with a saner 'style' parameter
- rework the entry mixins to be similar to the buttons'
- clear out all unused or deprecated mixins
- create some drawing functions for focus ring and high contrast inset
- replace instances of old mixins with the new

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3109>
2024-01-11 19:27:59 +00:00
Balázs Meskó
76abf806e4 Update Hungarian translation
(cherry picked from commit b3690409929c425b1b9afeb297d38e517d0af8fd)
2024-01-11 19:22:20 +00:00
Georges Basile Stavracas Neto
36b3a995eb data: Remove gnome-shell.portal
Now that xdg-desktop-portal-gnome implements the Access portal
interface, GNOME Shell doesn't have to be the portal backend for
that anymore.

The D-Bus implementation is still preserved, because internally,
xdg-desktop-portal-gnome may still proxy the Access call to GNOME
Shell when the parent window is not available. That's a private
exchange between xdg-desktop-portal-gnome and GNOME Shell though,
and doesn't require GNOME Shell to be a full portal backend.

See https://gitlab.gnome.org/GNOME/xdg-desktop-portal-gnome/-/merge_requests/140

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3106>
2024-01-10 15:36:01 +00:00
Florian Müllner
812270fee3 overviewControls: Subclass layout manager directly
All the ControlsManagerLayout uses from BoxLayout is the spacing
property, both size requests and allocation are completely custom.

That makes subclassing really questionable, so stop doing that
and just hook up to the `spacing` style property manually.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3104>
2024-01-10 15:26:44 +00:00
Florian Müllner
64b7249405 st/settings: Don't notify "icon-theme" on "high-contrast" changes
Since commit e831a924, the two are no longer linked.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3105>
2024-01-10 15:14:53 +00:00
Florian Müllner
723ccb70ee mountOperation: Close when drive gets disconnected
If the volume that corresponds to the mount operation has an
associated drive, we should withdraw any pending dialogs or
notifications when the drive gets physically disconnected,
as they've become obsolete.

Close https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7302

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3089>
2024-01-10 15:08:14 +00:00
Sam Hewitt
075df42d01 calendar: Stylesheet follow-ups and fixes
- drop extraneous calendar-day style_class on week headings
- fix wrong variable in insensitive button mixin
- add some missing focus styles to calendar month header
- fix the asset for today with-events in light theme
- adjust HighContrast visuals for other month days
- make pager buttons circular

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3102>
2024-01-10 03:02:09 +00:00
Sam Hewitt
e57bf0791e style: Use system base color for screenshot overview
- Fixes #7289

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3084>
2024-01-09 20:22:47 +00:00
Sam Hewitt
ea73e4f1e9 style: Clean up color definitions and High Contrast
- clean out unused colors; add desaturated light color
- remove long unused drawing functions; add high contrast color mixin
- de-duplicate and move common colors to a default-colors stylesheet
- rework how HighContrast is defined; clean up HC cruft
- bring over named color defines and other colors from libadwaita
- change how panel colors are defined

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3097>
2024-01-09 20:17:24 +00:00
Bilal Elmoussaoui
129fe3a07e shell/tray-icon: Adapt to moved xwindow property to XWindow
Associated merge request:
https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3211

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3026>
2024-01-09 19:17:20 +01:00
Sam Hewitt
d3b2784db0 style: Card style rework for light scheme
- clean up button mixin
- add new card-specific styles and colors
- fixes #7153
2024-01-09 14:09:40 -03:30
Sam Hewitt
5f9a626061 style: Update panel_button mixin to have HighContrast support
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3076>
2024-01-09 17:24:54 +00:00
Sam Hewitt
21a6c22fc6 style: Change text styles in calendar popover for better visibility
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3076>
2024-01-09 17:24:54 +00:00
Sam Hewitt
43e45d4b5f style: Change insensitive style on quick settings submenu
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3076>
2024-01-09 17:24:54 +00:00
Sam Hewitt
d3c3e02d52 style: Fix HighContrast issues with notifications
- define a new hc_mix_color for mixing functions that was making bg color transparent
- fix missing HC outline on banner notifications
- fix notification timestamp not changing in HC due to color
- closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7283

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3075>
2024-01-09 17:20:21 +00:00
Sam Hewitt
15e0440a8b appDisplay: CSS cleanup & fixes for app dialog
- change the container and dialog actor alignments
- pad the container to not have dialog overlap panel
- clean up extraneous app-folder css

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3044>
2024-01-09 17:14:09 +00:00
robert.mader@collabora.com
0ffddb0cd2 build: Enable no-omit-frame-pointer for all non-plain builds
To mirror Mutter.

This is useful for local installations with e.g. the `release`
buildtype.
Further more, Fedora has been doing the same system wide and it
apparently was helpful in various ways.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2982>
2024-01-09 17:41:12 +01:00
Julian Sparber
4b09aa2b8a st/viewport: Queue only redraw when StAdjustment value changes
It's enough to redraw the actor. Also the actor may be already in a relayout cycle
when the StAdjustment value changes which is bad.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3059>
2024-01-09 08:13:30 +00:00
Sam Hewitt
54a0c49d32 style: Update panel styles to use appropriately contrasty text color
- new always light fg color definition
- update panel button style to use new fg color
- fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7270

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3063>
2024-01-08 21:06:14 +00:00
Sabri Ünal
a4a3afc895 Update Turkish translation 2024-01-08 16:58:25 +00:00
Artur S0
a1719e8048 Update Russian translation 2024-01-08 13:44:30 +00:00
Ekaterine Papava
b641424c3e Update Georgian translation 2024-01-08 08:50:15 +00:00
Florian Müllner
99f3b24911 Bump version to 46.alpha
Update NEWS.
2024-01-07 11:16:54 +01:00
Florian Müllner
b4ea92562e Bump mutter API version
We forgot to do this when branching, so let's get it done now
before the alpha release.
2024-01-07 11:14:59 +01:00
Florian Müllner
e75a2ca146 extensions-app: Only change state if necessary
The `state-set` signal is emitted to change the underlying state,
which can have two reasons:

 1. the user toggled the switch
 2. the extension's `enabled` state changed externally

In the second case, calling enable/disable is pointless at best,
and can mess up the expected state by permanently disabling an
extension that was disabled because of the global kill switch.

Address this by only calling enable/disable if the new state does
not already match the current value of the `enabled` property.

Close https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7305

Fixes: fec523f83f ("extensions-app: Use new 'enabled' property")
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3090>
2024-01-07 10:02:23 +00:00
Aefgh Threenine
1c5a10a71f Update Thai translation 2024-01-07 00:09:30 +00:00
Aefgh Threenine
76e26cc129 Update Thai translation 2024-01-06 23:55:36 +00:00
Sebastian Wick
6b9c04de6e lookingGlass: Use Cogl.Pipeline.new to construct new pipelines
new Cogl.Pipeline now constructs a GObject via g_object_new and not via
cogl_pipeline_new. Construction via g_object_new requires a some
construct only parameters so either way, this call doesn't work anymore.

Closes: https://gitlab.gnome.org/GNOME/mutter/-/issues/3144
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3057>
2024-01-06 21:24:56 +00:00
Florian Müllner
02c8249e0b shell/util: Drop unused capture_images() function
It hasn't been used since commit 757e4b6731, so drop it. This
also avoids a warning when generating the typelib that was
introduced in commit f48729f6e.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3091>
2024-01-05 11:49:28 +01:00
Bilal Elmoussaoui
00813828f3 tray: Adapt to meta_x11_error_* removal
By switching to use the mtk helpers instead

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3087>
2024-01-05 10:46:17 +00:00
Philip Chimento
71befc5ff7 extensionSystem: Improve error formatting
This exposes the formatted error with stack trace and proper location of
SyntaxErrors over the bus, instead of just the message.

<https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3041>

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3041>
2024-01-04 20:12:32 +01:00
Philip Chimento
1692004b6b init: Improve error message formatting
Instead of manually formatting the error message and stack, use the same
formatting mechanism as we do when displaying errors to the user that
occur while opening extension preferences. This should correctly
indicate where syntax errors from imported modules occur.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3041>
2024-01-04 18:59:33 +00:00
Philip Chimento
e3ea12b8d5 scripting: Use logError to format error stack
Instead of manually formatting the error stack, use logError() to
display the error. logError() displays the stack already.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3041>
2024-01-04 18:59:33 +00:00