Go to file
Florian Müllner e75a2ca146 extensions-app: Only change state if necessary
The `state-set` signal is emitted to change the underlying state,
which can have two reasons:

 1. the user toggled the switch
 2. the extension's `enabled` state changed externally

In the second case, calling enable/disable is pointless at best,
and can mess up the expected state by permanently disabling an
extension that was disabled because of the global kill switch.

Address this by only calling enable/disable if the new state does
not already match the current value of the `enabled` property.

Close https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7305

Fixes: fec523f83f ("extensions-app: Use new 'enabled' property")
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3090>
2024-01-07 10:02:23 +00:00
.gitlab/issue_templates gitlab: Add a comment about disabling extension to the issue template 2022-12-15 19:07:08 +00:00
.gitlab-ci ci: Include .desktop files in POTFILES check 2023-08-22 00:16:52 +00:00
.settings Clean out some eclipse artefacts 2019-02-13 04:39:26 +01:00
data extensionSytem: Rename ENABLED/DISABLED states 2024-01-03 20:05:05 +00:00
docs docs: Fix st reference in urlmap 2023-12-14 18:12:22 +01:00
js lookingGlass: Use Cogl.Pipeline.new to construct new pipelines 2024-01-06 21:24:56 +00:00
lint lint: Remove legacy config 2023-08-09 15:10:38 +00:00
man man: Update options 2020-12-28 02:25:17 +01:00
meson theme: Include both dark and light variant in resource 2023-05-25 17:10:53 +02:00
po Update Thai translation 2024-01-07 00:09:30 +00:00
src shell/util: Drop unused capture_images() function 2024-01-05 11:49:28 +01:00
subprojects extensions-app: Only change state if necessary 2024-01-07 10:02:23 +00:00
tests tests/unit: Access shell sources from resource 2023-08-10 17:42:23 +00:00
tools/toolbox doc: Add README for toolbox tooling 2023-12-04 16:30:14 +00:00
.eslintrc.yml js: Port to modules 2023-08-06 13:02:49 +02:00
.gitignore ci: Simplify run-eslint script 2023-08-09 15:10:38 +00:00
.gitlab-ci.yml ci: Fix publishing docs 2023-12-14 17:53:38 +01:00
.gitmodules git: Always use libgnome-volume-control submodule from GNOME group 2022-08-04 18:31:16 +02:00
.jscheckignore ci: Don't ignore init.js 2023-04-21 18:28:32 +00:00
config.h.meson shell: Add device monitor for cameras 2023-07-29 13:55:15 +03:00
COPYING Changed obsolete FSF postal address. 2014-01-08 04:35:14 +07:00
gnome-shell.doap gnome-shell.doap: Make marge-bot a maintainer 2020-11-17 17:29:56 +00:00
HACKING.md lookingGlass: Use Cogl.Pipeline.new to construct new pipelines 2024-01-06 21:24:56 +00:00
meson_options.txt shell: Add device monitor for cameras 2023-07-29 13:55:15 +03:00
meson.build doc: Switch documentation to gi-docgen 2023-12-13 14:52:48 +01:00
NEWS Bump version to 45.0 2023-09-16 20:27:58 +02:00
README.md doc: Update contribution section 2022-12-06 01:49:24 +01:00

GNOME Shell

GNOME Shell provides core user interface functions for the GNOME desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience.

For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see the project wiki.

Bugs should be reported to the GNOME bug tracking system. Please refer to the Schedule wiki page to see the supported versions.

Contributing

To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell.

Commit messages should follow the GNOME commit message guidelines. If a merge request fixes an existing issue, it is good practice to append the full issue URL to each commit message. Try to always prefix commit subjects with a relevant topic, such as panel: or status/network:, and it's always better to write too much in the commit message body than too little.

Default branch

The default development branch is main. If you still have a local checkout under the old name, use:

git checkout master
git branch -m master main
git fetch
git branch --unset-upstream
git branch -u origin/main
git symbolic-ref refs/remotes/origin/HEAD refs/remotes/origin/main

License

GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.