d2186f6f1a
We fetch a frame clock that we schedule update on when queuing _NET_WM_FRAME_DRAWN events. In some situations this frame clock is the one from the stage, and if there are multiple hotplugs in a row, we failed to update it as there were no stage views changes on the window actor itself. As an actor updates the stage views list on layout, When a queue_frame_drawn() call was done (typically from an X11 event) after a second hotplug, it'd attempt to schedule an update on the frame clock from the previous hotplug, as it didn't get notified about any stage-views changes since for itself there was none. Fix this by not caching the frame clock at all and just fetch it every time. In the majority of cases, this fetching means iterating over a very short list (most often a single entry, rarely more), so it's very unlikely to be of any relevance. The only situations where it might be a heavier operation is the short time between a hotplug and a layout, as it will attempt to traverse up to the stage to find a clock, but that's likely only a few levels, so even that is unlikely to be an issue. Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4486 Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1947> |
||
---|---|---|
.gitlab/issue_templates | ||
.gitlab-ci | ||
clutter | ||
cogl | ||
data | ||
doc | ||
meson | ||
po | ||
src | ||
subprojects | ||
tools | ||
.gitignore | ||
.gitlab-ci.yml | ||
config.h.meson | ||
COPYING | ||
HACKING.md | ||
meson_options.txt | ||
meson.build | ||
mutter.doap | ||
NEWS | ||
README.md |
Mutter
Mutter is a Wayland display server and X11 window manager and compositor library.
When used as a Wayland display server, it runs on top of KMS and libinput. It implements the compositor side of the Wayland core protocol as well as various protocol extensions. It also has functionality related to running X11 applications using Xwayland.
When used on top of Xorg it acts as a X11 window manager and compositing manager.
It contains functionality related to, among other things, window management, window compositing, focus tracking, workspace management, keybindings and monitor configuration.
Internally it uses a fork of Cogl, a hardware acceleration abstraction library used to simplify usage of OpenGL pipelines, as well as a fork af Clutter, a scene graph and user interface toolkit.
Mutter is used by, for example, GNOME Shell, the GNOME core user interface, and by Gala, elementary OS's window manager. It can also be run standalone, using the command "mutter", but just running plain mutter is only intended for debugging purposes.
Contributing
To contribute, open merge requests at https://gitlab.gnome.org/GNOME/mutter.
It can be useful to look at the documentation available at the Wiki.
Coding style and conventions
See HACKING.md.
Git messages
Commit messages should follow the GNOME commit message
guidelines. We require an URL
to either an issue or a merge request in each commit. Try to always prefix
commit subjects with a relevant topic, such as compositor:
or
clutter/actor:
, and it's always better to write too much in the commit
message body than too little.
Default branch
The default development branch is main
. If you still have a local
checkout under the old name, use:
git checkout master
git branch -m master main
git fetch
git branch --unset-upstream
git branch -u origin/main
git symbolic-ref refs/remotes/origin/HEAD refs/remotes/origin/main
License
Mutter is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for detalis.