mirror of
https://github.com/brl/mutter.git
synced 2024-11-10 16:16:20 -05:00
7d674db9d2
The ClutterColor API has some inconsistencies:
- the string deserialization function does not match the rest of
the conversion function naming policy; the naming should be:
clutter_color_parse() -> clutter_color_from_string()
and the first parameter should be the ClutterColor that will
be set from the string, not the string itself (a GDK-ism).
- the fixed point API should not be exposed, especially in the
form of ClutterFixed values
- the non-fixed point HLS conversion functions do not make any
sense. The values returned should be:
hue := range [ 0, 360 ]
luminance := range [ 0, 1 ]
saturation := range [ 0, 1 ]
like the current fixed point API does. Returning a value in
the [ 0, 255 ] range is completely useless
- the clutter_color_equal() should be converted for its use inside
a GHashTable; a clutter_color_hash() should be added as well
- the second parameter of the clutter_color_shade() function should
be the shading factor, not the result (another GDK-ism). this way
the function call can be translated from this:
color.shade(out result, factor)
to the more natural:
color.shade(factor, out result)
This somewhat large commit fixes all these issues and updates the
internal users of the API.
|
||
|---|---|---|
| .. | ||
| Makefile.am | ||
| test-actor-clone.c | ||
| test-actors.c | ||
| test-animation.c | ||
| test-behave.c | ||
| test-binding-pool.c | ||
| test-clip.c | ||
| test-clutter-cairo-flowers.c | ||
| test-cogl-multitexture.c | ||
| test-cogl-offscreen.c | ||
| test-cogl-primitives.c | ||
| test-cogl-tex-convert.c | ||
| test-cogl-tex-foreign.c | ||
| test-cogl-tex-getset.c | ||
| test-cogl-tex-polygon.c | ||
| test-cogl-tex-tile.c | ||
| test-depth.c | ||
| test-devices.c | ||
| test-easing.c | ||
| test-entry.c | ||
| test-events.c | ||
| test-fbo.c | ||
| test-fullscreen.c | ||
| test-grab.c | ||
| test-layout.c | ||
| test-main.c | ||
| test-model.c | ||
| test-multistage.c | ||
| test-offscreen.c | ||
| test-paint-wrapper.c | ||
| test-perspective.c | ||
| test-pixmap.c | ||
| test-project.c | ||
| test-random-text.c | ||
| test-rotate.c | ||
| test-scale.c | ||
| test-score.c | ||
| test-script.c | ||
| test-shader.c | ||
| test-stage-read-pixels.c | ||
| test-text-field.c | ||
| test-text.c | ||
| test-texture-quality.c | ||
| test-textures.c | ||
| test-threads.c | ||
| test-unproject.c | ||
| test-viewport.c | ||
| wrapper.sh | ||