Daniel van Vugt
2a725f0bd9
cursor-renderer-native: Don't retry forever after GBM cursor functions fail
...
This avoids flooding the log with every cursor change:
```
(gnome-shell:19923): libmutter-WARNING **: 10:15:23.404: Realizing HW cursor failed: Failed to allocate gbm_bo: Invalid argument
(gnome-shell:19923): libmutter-WARNING **: 10:15:23.450: Realizing HW cursor failed: Failed to allocate gbm_bo: Invalid argument
(gnome-shell:19923): libmutter-WARNING **: 10:15:23.451: Realizing HW cursor failed: Failed to allocate gbm_bo: Invalid argument
```
Related: https://gitlab.gnome.org/GNOME/mutter/-/issues/2354
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2520 >
2022-08-10 15:35:55 +00:00
Daniel van Vugt
c430731436
output-xrandr: Less line wrapping
...
To silence CI warnings from check-code-style.
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2511 >
2022-08-10 14:41:46 +00:00
Daniel van Vugt
9d7cebd8e6
monitor-manager: Remove struct member indentation
...
To silence CI warnings from check-code-style.
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2511 >
2022-08-10 14:41:46 +00:00
Daniel van Vugt
5476feeaf2
monitor-config-store: Parentheses for correct indentation
...
To silence check-code-style complaints in CI, but also for consistency
(other cases already have parentheses).
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2511 >
2022-08-10 14:41:46 +00:00
Daniel van Vugt
3d044c351e
monitor-config-store: Remove whitespace to silence check-code-style warning
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2511 >
2022-08-10 14:41:46 +00:00
Dor Askayo
b4fff403b8
clutter/frame-clock: Ignore missing presentation timestamps
...
In some hardware configurations, presentation timestamps could be
missing from some page flip events, leading to a temporary loss of
vblank synchronization.
This occurs at least with AMD GPUs for atomic commits that only update
the cursor plane. [0]
In those cases, it's better to calculate the next update time
according to the last valid presentation timestamp instead of relying
on the dispatch lateness.
[0] https://gitlab.freedesktop.org/drm/amd/-/issues/2030
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2481 >
2022-08-10 14:01:40 +00:00
Jonas Ådahl
a4e71361b6
ci: Always retry the image build step
...
The image build step is prone to race conditions, e.g. token changes. It
also tends to hit sporadic connection errors to FDO's gitlab. To
minimize the risk of these types of issues block pipelines, always retry
the image building step if it failed.
This has the unwanted consequence that changes to the image building
that results in the script actually failing, but right now there doesn't
appear to be a way to distinguish between actual build errors, and the
mentioned race conditions, as both cause the script to fail.
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2564 >
2022-08-10 12:54:33 +00:00
Daniel van Vugt
8019714b5d
texture-mipmap: Fix some leaks and tidy up
...
Seems we were leaking mipmap->mipmap_texture and mipmap->fb.
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2562 >
2022-08-10 11:52:39 +00:00
Corentin Noël
8fcee7a8a5
clutter/stage: Add nullable annotation to get_*_actor methods
...
Allows to know when a NULL ClutterActor is possibly being returned.
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2559 >
2022-08-10 10:47:51 +00:00
Corentin Noël
5356bc865f
main: Add meta-context to the header
...
The meta_restart function now requires it.
Fixes f772b4cde6
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2559 >
2022-08-10 10:47:51 +00:00
Michel Dänzer
23526a99c7
x11-display: Unset GDK_BACKEND environment variable
...
mutter needs GDK to use the x11 backend. It already calls
gdk_set_allowed_backends ("x11") for this purpose; however, if
GDK_BACKEND=wayland (or any other non-x11 backend possibly) happened to
be in the environment, GDK would fail to initialize at all. This would
result in mutter not registering as X11 window manager, and all X11
clients hanging.
Big thanks to Olivier Fourdan for figuring this out!
v2:
* Restore original value of GDK_BACKEND environment variable after
initializing GDK.
Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2022283
Bug: https://bugs.debian.org/1008992
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2496 >
2022-08-10 08:34:48 +00:00
Jonas Ådahl
efaf5a25b3
cogl: Remove the now unused test framework
...
All tests have been moved into src/tests/, so no need for it anymore.
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:13 +00:00
Jonas Ådahl
30daad4da5
cogl/pipeline/vertend/glsl: Move out unit test to its own file
...
Fix a memory leak while at it.
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:13 +00:00
Jonas Ådahl
04bbe31287
cogl/pipeline/glsl: Distinguish between pipeline state types
...
Both the fragend and vertend shader state was called
"CoglPipelineShaderState", which was rather annoying, especially when
the type needs to be exposed outside of the .c file as part of moving
out unit tests. Make the types unique. This also avoids confusing what
type one is looking at.
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:13 +00:00
Jonas Ådahl
2c72032668
tests/cogl/unit: Run most tests with all drivers
...
All tests but one (so far) will in one way or the other depend on what
driver is used, so run the tests on all.
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:13 +00:00
Jonas Ådahl
07f8edde22
cogl/pipeline/opengl: Move out unit test to separate file
...
Also rename the suffix to "-glsl" to not confuse OpenGL with GLES2
since this test covers both.
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:13 +00:00
Jonas Ådahl
16a7f77701
cogl/pipeline-state: Move out working unit test to separate file
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:13 +00:00
Jonas Ådahl
ae0f6c549f
cogl/pipeline-state: Move out failing test to its own file
...
This test is a known failure, so mark it as such. It's stored in its own
file since keeping it in the same as the passing test isn't markable
using meson.
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:13 +00:00
Jonas Ådahl
57382b6aff
test/cogl/unit: Allow marking known failures
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:13 +00:00
Jonas Ådahl
4905a55f64
cogl/pipeline-cache: Move unit test to its own file
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:13 +00:00
Jonas Ådahl
d0861c8ae2
cogl: Move out bitmask unit test to separate file
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:13 +00:00
Jonas Ådahl
9a9e7e471c
tests/cogl: Add unit test framework
...
It consists of only a macro and build description logic.
Adds a macro for simpler tests that doesn't require a context; unit
tests requiring a context should use the same framework as conform
tests.
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:13 +00:00
Jonas Ådahl
4ebaa433ee
cogl: Remove now empty conform test suite
...
All working tests have already migrated to the test suite using mutter;
move the old unported tests over too, and remove the conform test
framework, as it is no longer used.
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:13 +00:00
Jonas Ådahl
5d40a5eeea
tests/cogl: Migrate fence test
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
2b43ff5963
tests/cogl: Migrate texture rg test
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
e7f535a21d
tests/cogl: Migrate pipeline shader state test
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
94744061de
tests/cogl: Migrate texture no allocate test
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
d066fb5380
tests/cogl: Migrate pipeline cache unrefs texture test
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
68dcde0bdb
tests/cogl: Migrate copy/replace texture test
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
20111fa8ca
tests/cogl: Migrate primitive and journal test
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
3750ed6a26
tests/cogl: Migrate framebuffer bits test
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
09990f8bcc
tests/cogl: Migrate texture get/set data test
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
85ad013b2d
tests/cogl: Migrate alpha texture test
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
629c23b229
tests/cogl: Migrate npot texture test
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
33c582d33a
tests/cogl: Migrate map buffer range test
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
0a841ce846
tests/cogl: Migrate alpha test test
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
5b0fa9cff4
tests/cogl: Migrate layer remove test
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
7a91c30149
cogl: Remove version
...
The cogl version was unused, and not relevant, as the version and API is
tied to the mutter API version, not the old pre fork cogl version.
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
c0746a04f9
tests/cogl: Migrate no-gl header test
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
590290cd6d
tests/cogl: Migrate point sprite tests
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
41e5ee63d3
tests/cogl: Migrate point size attribute tests
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
2746861c6a
tests/cogl: Migrate point size test
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
ae9b4a1bcf
tests/cogl: Migrate write texture formats test
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
ddb982ba6e
tests/cogl: Migrate read texture formats test
...
This test fails on gl and gl3, but not on gles2; mark is at such.
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
bfd5e87c92
tests/cogl: List known failures
...
Some tests fail on e.g. gl and gl3, but not on gles2; allow describing
that.
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
400cc89364
tests/cogl: Migrate sparse pipeline test
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
8dc0489b33
tests/cogl: Migrate primitive tests
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
559c9c8795
tests/cogl: Migrate journal test
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
0c6eb86698
tests/cogl: Migrate offscreen test
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00
Jonas Ådahl
fd99884063
tests/cogl: Migrate custom attributes test
...
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2555 >
2022-08-08 21:59:12 +00:00