isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
dab60d5580
gnome-shell/js/ui
History
Marco Trevisan (Treviño) dab60d5580 renameFolderMenu: Use a custom menu item inheriting from PopupBaseMenuItem 
The RenameFolderMenu uses the internal box as a menu item, while PopupMenu
expects to have PopupBaseMenuItem based children with a delegate set.

Instead of using a custom menu with a customized box acting as menu
item,just add a RenameFolderMenuItem that inherits from the parent,
adjusting the features as we need them. In fact, the rename folder menu item
doesn't need any label, padding or default styling so we can reuse
PopupMenuBaseItem after we use our styling properties and we set the
Ornament to HIDDEN.

To get the proper style in place, define rename-folder-popup and
rename-folder-popup-item to override the default popup-menu-item rule
padding instead of using margins.

Pass the menu item as menu's focusActor as this will key-focus it on pop-up,
by overriding the key_focus_in() vfunc we can then delegate the focus
handling to the entry's clutter-text.

Also override the map() vfunc in order to update the entry's content before
mapping the entry.

Finally, use the item's activate method in order to tell the parent menu
we're done with it and that the menu can be closed.

As consequence we can also remove the menu's popup() method, and just use
the default open().

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/720
2019-09-20 15:53:42 +00:00
..
components cleanup: Don't add linebreak before operators 2019-09-15 16:02:45 +02:00
status cleanup: Don't add linebreak before operators 2019-09-15 16:02:45 +02:00
accessDialog.js cleanup: Disambiguate assignments in arrow functions 2019-09-15 16:02:45 +02:00
altTab.js cleanup: Avoid unnecessary parentheses in arrow functions 2019-09-15 16:02:45 +02:00
animation.js cleanup: Stop using Mainloop module 2019-09-12 19:09:24 +02:00
appDisplay.js renameFolderMenu: Use a custom menu item inheriting from PopupBaseMenuItem 2019-09-20 15:53:42 +00:00
appFavorites.js cleanup: "Only" use two indentation styles for object literals 2019-09-12 23:18:24 +02:00
audioDeviceSelection.js cleanup: Disambiguate assignments in arrow functions 2019-09-15 16:02:45 +02:00
background.js cleanup: "Only" use two indentation styles for object literals 2019-09-12 23:18:24 +02:00
backgroundMenu.js backgroundMenu: Animate menu opening 2019-09-11 23:25:21 +00:00
barLevel.js barLevel: Remove duplicated assignment 2019-08-13 16:35:17 +02:00
boxpointer.js cleanup: Don't add linebreak before operators 2019-09-15 16:02:45 +02:00
calendar.js cleanup: Avoid unnecessary parentheses in arrow functions 2019-09-15 16:02:45 +02:00
checkBox.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
closeDialog.js js: Use implicit animations for animatable properties 2019-08-06 23:54:29 +02:00
ctrlAltTab.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
dash.js cleanup: Use consistent style for ternary operator 2019-09-15 13:30:19 +00:00
dateMenu.js cleanup: Disambiguate assignments in arrow functions 2019-09-15 16:02:45 +02:00
dialog.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
dnd.js dnd: Fix drag cancel animation scale 2019-08-09 10:58:46 -03:00
edgeDragAction.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
endSessionDialog.js cleanup: "Only" use two indentation styles for object literals 2019-09-12 23:18:24 +02:00
environment.js environment: Disable fullscreen unredirect during all transitions 2019-09-13 16:10:17 +00:00
extensionDownloader.js cleanup: "Only" use two indentation styles for object literals 2019-09-12 23:18:24 +02:00
extensionSystem.js cleanup: Avoid pointless "renames" in destructuring 2019-09-15 16:02:45 +02:00
focusCaretTracker.js cleanup: Prefer template strings 2019-07-05 11:32:31 +00:00
grabHelper.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
ibusCandidatePopup.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
iconGrid.js appDisplay: Add API to animate launch at given position 2019-09-18 17:14:16 +00:00
inhibitShortcutsDialog.js cleanup: Use consistent style for ternary operator 2019-09-15 13:30:19 +00:00
kbdA11yDialog.js cleanup: Fix wrong indentation 2019-09-15 13:30:19 +00:00
keyboard.js cleanup: Remove trailing spaces 2019-09-15 16:02:45 +02:00
layout.js cleanup: Use consistent brace style of blocks 2019-09-15 16:02:45 +02:00
lightbox.js cleanup: "Only" use two indentation styles for object literals 2019-09-12 23:18:24 +02:00
locatePointer.js locatePointer: Bind ripples creation to settings 2019-09-09 19:28:18 +00:00
lookingGlass.js cleanup: Remove trailing spaces 2019-09-15 16:02:45 +02:00
magnifier.js magnifier: Do not modify function argument 2019-09-15 16:02:45 +02:00
magnifierDBus.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
main.js cleanup: Avoid useless return statements 2019-09-15 16:02:45 +02:00
messageList.js js: Ease non-animatable actor properties 2019-08-06 23:54:29 +02:00
messageTray.js cleanup: Remove trailing spaces 2019-09-15 16:02:45 +02:00
modalDialog.js cleanup: Disambiguate assignments in arrow functions 2019-09-15 16:02:45 +02:00
mpris.js cleanup: Use consistent style for ternary operator 2019-09-15 13:30:19 +00:00
notificationDaemon.js cleanup: Remove trailing spaces 2019-09-15 16:02:45 +02:00
osdMonitorLabeler.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
osdWindow.js cleanup: Stop using Mainloop module 2019-09-12 19:09:24 +02:00
overview.js overview: Fix fading out desktop icons 2019-09-14 14:05:12 +02:00
overviewControls.js cleanup: Use consistent style for ternary operator 2019-09-15 13:30:19 +00:00
padOsd.js style: Disable camelcase rule for GObject properties 2019-07-24 00:28:45 +02:00
pageIndicators.js cleanup: Use consistent style for ternary operator 2019-09-15 13:30:19 +00:00
panel.js cleanup: Stop using Mainloop module 2019-09-12 19:09:24 +02:00
panelMenu.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
pointerA11yTimeout.js cleanup: Remove left-over imports 2019-09-11 20:59:31 +00:00
pointerWatcher.js cleanup: Stop using Mainloop module 2019-09-12 19:09:24 +02:00
popupMenu.js popupMenu: Add focusActor property to define the default focus actor 2019-09-20 15:53:42 +00:00
remoteSearch.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
ripples.js cleanup: Disambiguate assignments in arrow functions 2019-09-15 16:02:45 +02:00
runDialog.js cleanup: Avoid unnecessary parentheses in arrow functions 2019-09-15 16:02:45 +02:00
screencast.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
screenShield.js cleanup: Use consistent style for ternary operator 2019-09-15 13:30:19 +00:00
screenshot.js cleanup: Switch some method calls to new indentation style 2019-09-15 13:30:19 +00:00
scripting.js scripting: Disable an eslint warning 2019-09-15 16:02:45 +02:00
search.js cleanup: Use consistent style for ternary operator 2019-09-15 13:30:19 +00:00
sessionMode.js cleanup: Use consistent style for ternary operator 2019-09-15 13:30:19 +00:00
shellDBus.js shellDBus: Use floats instead of percentages for OSD levels 2019-07-28 17:27:53 +02:00
shellEntry.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
shellMountOperation.js cleanup: Remove trailing spaces 2019-09-15 16:02:45 +02:00
slider.js slider: Do not notify on parent's behalf 2019-08-13 16:35:17 +02:00
switcherPopup.js cleanup: Stop using Mainloop module 2019-09-12 19:09:24 +02:00
switchMonitor.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
tweener.js tweener: Use new adjustAnimationTime() helper 2019-08-06 20:50:43 +02:00
unlockDialog.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
userWidget.js userWidget: Handle non-square icons gracefully 2019-07-29 16:16:22 +00:00
viewSelector.js viewSelector: Only reset search entry if it has key focus 2019-09-18 15:56:26 +00:00
windowAttentionHandler.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
windowManager.js cleanup: Disambiguate assignments in arrow functions 2019-09-15 16:02:45 +02:00
windowMenu.js cleanup: Avoid unnecessary parentheses in arrow functions 2019-09-15 16:02:45 +02:00
workspace.js workspace: Fix an incorrect signal check 2019-09-20 11:50:24 +02:00
workspacesView.js cleanup: Disambiguate assignments in arrow functions 2019-09-15 16:02:45 +02:00
workspaceSwitcherPopup.js cleanup: Stop using Mainloop module 2019-09-12 19:09:24 +02:00
workspaceThumbnail.js appDisplay: Animate DnD app icons at the position they were dropped 2019-09-18 17:14:16 +00:00
xdndHandler.js cleanup: Mark unused (but useful) variables as ignored 2019-07-24 00:28:45 +02:00