7095ef05e1
The WorkspacesView may be scheduled to be destroyed during relayout, and despite that go through the allocate() vfunc. When that happens, the ::destroy handler is called early, so the WorkspacesView clears this._workspaces in result. When vfunc_allocate() is called, various paths rely on the workspaces array being still populated, which is not the case. The existing check at vfunc_allocate() for the WorkspacesView having no children is insufficient, since children are destroyed as a result, not beforehand. This results in the following warnings when going out of overview: JS ERROR: TypeError: workspace is undefined _getSpacing@resource:///org/gnome/shell/ui/workspacesView.js:218:13 vfunc_allocate@resource:///org/gnome/shell/ui/workspacesView.js:344:18 vfunc_allocate@resource:///org/gnome/shell/ui/overviewControls.js:223:33 removeWindow@resource:///org/gnome/shell/ui/workspace.js:856:29 addWindow/<.destroyId<@resource:///org/gnome/shell/ui/workspace.js:808:22 _updateWorkspacesViews@resource:///org/gnome/shell/ui/workspacesView.js:1023:38 prepareToEnterOverview@resource:///org/gnome/shell/ui/workspacesView.js:990:14 prepareToEnterOverview@resource:///org/gnome/shell/ui/overviewControls.js:740:33 gestureBegin@resource:///org/gnome/shell/ui/overviewControls.js:802:14 _gestureBegin@resource:///org/gnome/shell/ui/overview.js:409:33 _beginGesture@resource:///org/gnome/shell/ui/swipeTracker.js:601:14 _handleEvent@resource:///org/gnome/shell/ui/swipeTracker.js:173:26 @resource:///org/gnome/shell/ui/init.js:21:20 This always happens through the _updateWorkspacesViews() paths, so there is a new WorkspacesView taking over and the one being destroyed should silently go away. Related: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/6935 Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2918> |
||
|---|---|---|
| .gitlab/issue_templates | ||
| .gitlab-ci | ||
| .settings | ||
| data | ||
| docs/reference | ||
| js | ||
| lint | ||
| man | ||
| meson | ||
| po | ||
| src | ||
| subprojects | ||
| tests | ||
| tools | ||
| .eslintrc.yml | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| .gitmodules | ||
| .jscheckignore | ||
| config.h.meson | ||
| COPYING | ||
| gnome-shell.doap | ||
| HACKING.md | ||
| meson_options.txt | ||
| meson.build | ||
| NEWS | ||
| README.md | ||
GNOME Shell
GNOME Shell provides core user interface functions for the GNOME desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience.
For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see the project wiki.
Bugs should be reported to the GNOME bug tracking system. Please refer to the Schedule wiki page to see the supported versions.
Contributing
To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell.
Commit messages should follow the GNOME commit message
guidelines. If a merge request
fixes an existing issue, it is good practice to append the full issue URL
to each commit message. Try to always prefix commit subjects with a relevant
topic, such as panel: or status/network:, and it's always better to write
too much in the commit message body than too little.
Default branch
The default development branch is main. If you still have a local
checkout under the old name, use:
git checkout master
git branch -m master main
git fetch
git branch --unset-upstream
git branch -u origin/main
git symbolic-ref refs/remotes/origin/HEAD refs/remotes/origin/main
License
GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.