brl
0 Followers · 0 Following
  • Joined on 2024-03-31
Repositories
5
 Projects Packages Code Public Activity Starred Repositories
brl pushed to master at brl/citadel 2024-09-27 07:42:45 -04:00
9599d3da9d Add patch for GNOME Software to facilitate sandboxing
brl pushed to master at brl/citadel 2024-09-11 14:40:39 -04:00
4c6f4f4a3d Add missing files to correct dns fix commit (0d13ca38df)
brl merged pull request brl/citadel#15 2024-09-11 14:40:38 -04:00
Add missing files to correct dns fix commit (0d13ca38df)
brl pushed to master at brl/citadel 2024-09-09 08:23:37 -04:00
0d13ca38df Fix failure of dns resolution in realms
brl merged pull request brl/citadel#14 2024-09-09 08:23:36 -04:00
Fix failure of dns resolution in realms
brl pushed to master at brl/citadel 2024-09-06 12:00:58 -04:00
bc87a2c629 Added packages needed for flatpak/gnome-software support
brl pushed to master at brl/citadel-tools 2024-09-06 11:49:47 -04:00
24f786cf75 Fix broken realmfs autoresize
2dc8bf2922 Support for flatpak and GNOME Software in Realms
Compare 2 commits »
brl pushed to master at brl/citadel-tools 2024-09-06 07:53:37 -04:00
2a16bd4c41 Upgrade clap, rpassword and pwhash to prepare for new code using them
brl merged pull request brl/citadel-tools#5 2024-09-06 07:53:37 -04:00
Upgrade clap, rpassword and pwhash to prepare for new code using them
brl pushed to master at brl/citadel 2024-09-06 07:52:10 -04:00
e51faa3266 Fix missing svg file in bitbake build process
brl merged pull request brl/citadel#13 2024-09-06 07:52:09 -04:00
Fix missing svg file in bitbake build process
brl commented on pull request brl/citadel#10 2024-08-30 11:50:00 -04:00
Fix double click required for wifi connection and upgrade nma

Pulling in GNOME Keyring to "Fix double click" bug is a change that I'll need more information about.

Whether or not to include GNOME Keyring in Citadel is not such a trivial decision because…

brl commented on pull request brl/citadel-tools#4 2024-08-30 11:31:08 -04:00
Improve error handling by using std lib rust code

PS: Gitea is pretty sweet. I had no idea it would collect all the code review comments I wrote and show them like that.

brl commented on pull request brl/citadel-tools#4 2024-08-30 11:29:03 -04:00
Improve error handling by using std lib rust code

Sorry, but no.

brl commented on pull request brl/citadel-tools#4 2024-08-30 11:29:03 -04:00
Improve error handling by using std lib rust code

When you mix reformatting changes in with code changes then I have to read the reformatting changes very carefully to make sure you haven't changed anything.

brl commented on pull request brl/citadel-tools#4 2024-08-30 11:29:03 -04:00
Improve error handling by using std lib rust code

This is an improvement over the current error handling API?

brl commented on pull request brl/citadel-tools#4 2024-08-30 11:29:03 -04:00
Improve error handling by using std lib rust code

Uh..... you want to panic instead of just exiting cleanly and printing an error message?

brl commented on pull request brl/citadel-tools#4 2024-08-30 11:29:03 -04:00
Improve error handling by using std lib rust code

Why did you rewrite this? Why is this buried in a massive commit described vaguely as "improve error handling"?

brl commented on pull request brl/citadel-tools#4 2024-08-30 11:29:03 -04:00
Improve error handling by using std lib rust code

What? Why does this need a Result return type?

brl commented on pull request brl/citadel-tools#4 2024-08-30 11:29:03 -04:00
Improve error handling by using std lib rust code

Ooops, you forgot to replace a libcitadel::error::Error the 'improved' version and everything still works when you return it. Are you still sure rewriting everything was what you needed to do?