brl/citadel
1
0
Fork 2
Code Issues Pull Requests 2 Packages Projects Releases Wiki Activity

Fix double click required for wifi connection and upgrade nma #10

Open
isa wants to merge 1 commits from isa/citadel:internet into master
pull from: isa/citadel:internet
merge into: brl:master
Conversation 2 Commits 1 Files Changed 5 +120 -4
isa commented 2024-08-28 13:54:45 -04:00
Contributor
Copy Link
No description provided.
isa added 1 commit 2024-08-28 13:54:45 -04:00
brl commented 2024-08-30 11:50:00 -04:00
Owner
Copy Link

Pulling in GNOME Keyring to "Fix double click" bug is a change that I'll need more information about.

Whether or not to include GNOME Keyring in Citadel is not such a trivial decision because in the future we have some plans to store secrets such as keys and passwords securely in Citadel. Yes, this is exactly what GNOME Keyring is for and that's the problem. Keyring may not be the right tool for the job because we need to be able to provide access and storage of secrets that is partitioned by individual realms.

If we don't use GNOME Keyring, we may still want to implement the Secret Service API for whatever we build to use instead of GNOME Keyring. Depending on the implementation details, it may be a problem that Keyring is running and already owning the service name.

If we really need to add Keyring now for a good reason, then fine, we can do that. But do we have a good reason?

I don't know because I don't understand the bug you have fixed.

Pulling in GNOME Keyring to "Fix double click" bug is a change that I'll need more information about. Whether or not to include GNOME Keyring in Citadel is not such a trivial decision because in the future we have some plans to store secrets such as keys and passwords securely in Citadel. Yes, this is exactly what GNOME Keyring is for and that's the problem. Keyring may not be the right tool for the job because we need to be able to provide access and storage of secrets that is partitioned by individual realms. If we don't use GNOME Keyring, we may still want to implement the [Secret Service API](https://specifications.freedesktop.org/secret-service-spec/latest/) for whatever we build to use instead of GNOME Keyring. Depending on the implementation details, it may be a problem that Keyring is running and already owning the service name. If we really need to add Keyring now for a good reason, then fine, we can do that. But do we have a good reason? I don't know because I don't understand the bug you have fixed.
isa commented 2024-08-30 13:19:53 -04:00
Author
Contributor
Copy Link

When using citadel right now, if you click to connect to a wifi network through the applet (not the settings program), you are not prompted to enter the password of the network. Instead, nothing happens. So the user must click the network name again and is then prompted for the wifi password.

This is not a serious bug but is annoying. McKinney found this bug, I also noticed it a bit later.

Do you think that a deeper dive into the network-manager-applet code is preferred to resolve this issue? Maybe patch NMA instead of pulling in gnome-keyring?

When using citadel right now, if you click to connect to a wifi network through the applet (not the settings program), you are not prompted to enter the password of the network. Instead, nothing happens. So the user must click the network name again and is then prompted for the wifi password. This is not a serious bug but is annoying. McKinney found this bug, I also noticed it a bit later. Do you think that a deeper dive into the network-manager-applet code is preferred to resolve this issue? Maybe patch NMA instead of pulling in gnome-keyring?
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u internet:isa-internet
git checkout isa-internet
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: brl/citadel#10
No description provided.
Delete Branch "isa/citadel:internet"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?