Pulling in GNOME Keyring to "Fix double click" bug is a change that I'll need more information about.
Whether or not to include GNOME Keyring in Citadel is not such a trivial decision because…
PS: Gitea is pretty sweet. I had no idea it would collect all the code review comments I wrote and show them like that.
When you mix reformatting changes in with code changes then I have to read the reformatting changes very carefully to make sure you haven't changed anything.
This is an improvement over the current error handling API?
Uh..... you want to panic instead of just exiting cleanly and printing an error message?
Why did you rewrite this? Why is this buried in a massive commit described vaguely as "improve error handling"?
Ooops, you forgot to replace a libcitadel::error::Error
the 'improved' version and everything still works when you return it. Are you still sure rewriting everything was what you needed to do?