2006-10-01 18:30:10 -04:00
|
|
|
/* -*- mode: C; c-file-style: "gnu"; indent-tabs-mode: nil; -*- */
|
|
|
|
|
2001-06-24 02:47:54 -04:00
|
|
|
/* Metacity window placement */
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Copyright (C) 2001 Havoc Pennington
|
2003-02-23 12:09:46 -05:00
|
|
|
* Copyright (C) 2002, 2003 Red Hat, Inc.
|
|
|
|
* Copyright (C) 2003 Rob Adams
|
2005-10-08 15:38:54 -04:00
|
|
|
* Copyright (C) 2005 Elijah Newren
|
2001-06-24 02:47:54 -04:00
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or
|
|
|
|
* modify it under the terms of the GNU General Public License as
|
|
|
|
* published by the Free Software Foundation; either version 2 of the
|
|
|
|
* License, or (at your option) any later version.
|
|
|
|
*
|
|
|
|
* This program is distributed in the hope that it will be useful, but
|
|
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
|
|
* General Public License for more details.
|
|
|
|
*
|
|
|
|
* You should have received a copy of the GNU General Public License
|
|
|
|
* along with this program; if not, write to the Free Software
|
|
|
|
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
|
|
|
|
* 02111-1307, USA.
|
|
|
|
*/
|
|
|
|
|
2002-05-12 20:03:17 -04:00
|
|
|
#include <config.h>
|
|
|
|
|
2001-06-24 02:47:54 -04:00
|
|
|
#include "place.h"
|
2001-06-24 04:09:10 -04:00
|
|
|
#include "workspace.h"
|
2002-05-12 20:03:17 -04:00
|
|
|
#include "prefs.h"
|
2001-06-24 04:09:10 -04:00
|
|
|
#include <gdk/gdkregion.h>
|
|
|
|
#include <math.h>
|
2001-07-12 01:53:56 -04:00
|
|
|
#include <stdlib.h>
|
2001-06-24 04:09:10 -04:00
|
|
|
|
2005-02-11 14:20:44 -05:00
|
|
|
typedef enum
|
|
|
|
{
|
|
|
|
META_LEFT,
|
|
|
|
META_RIGHT,
|
|
|
|
META_TOP,
|
|
|
|
META_BOTTOM
|
|
|
|
} MetaWindowDirection;
|
|
|
|
|
2001-06-24 04:09:10 -04:00
|
|
|
static gint
|
|
|
|
northwestcmp (gconstpointer a, gconstpointer b)
|
|
|
|
{
|
|
|
|
MetaWindow *aw = (gpointer) a;
|
|
|
|
MetaWindow *bw = (gpointer) b;
|
|
|
|
int from_origin_a;
|
|
|
|
int from_origin_b;
|
|
|
|
int ax, ay, bx, by;
|
|
|
|
|
|
|
|
/* we're interested in the frame position for cascading,
|
|
|
|
* not meta_window_get_position()
|
|
|
|
*/
|
|
|
|
if (aw->frame)
|
|
|
|
{
|
|
|
|
ax = aw->frame->rect.x;
|
|
|
|
ay = aw->frame->rect.y;
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
ax = aw->rect.x;
|
|
|
|
ay = aw->rect.y;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (bw->frame)
|
|
|
|
{
|
|
|
|
bx = bw->frame->rect.x;
|
|
|
|
by = bw->frame->rect.y;
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
bx = bw->rect.x;
|
|
|
|
by = bw->rect.y;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* probably there's a fast good-enough-guess we could use here. */
|
|
|
|
from_origin_a = sqrt (ax * ax + ay * ay);
|
|
|
|
from_origin_b = sqrt (bx * bx + by * by);
|
|
|
|
|
|
|
|
if (from_origin_a < from_origin_b)
|
|
|
|
return -1;
|
|
|
|
else if (from_origin_a > from_origin_b)
|
|
|
|
return 1;
|
|
|
|
else
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void
|
|
|
|
find_next_cascade (MetaWindow *window,
|
|
|
|
MetaFrameGeometry *fgeom,
|
|
|
|
/* visible windows on relevant workspaces */
|
|
|
|
GList *windows,
|
|
|
|
int x,
|
|
|
|
int y,
|
|
|
|
int *new_x,
|
|
|
|
int *new_y)
|
|
|
|
{
|
|
|
|
GList *tmp;
|
|
|
|
GList *sorted;
|
|
|
|
int cascade_x, cascade_y;
|
|
|
|
int x_threshold, y_threshold;
|
2002-10-01 22:42:24 -04:00
|
|
|
int window_width, window_height;
|
|
|
|
int cascade_stage;
|
2003-04-06 23:33:45 -04:00
|
|
|
MetaRectangle work_area;
|
|
|
|
const MetaXineramaScreenInfo* current;
|
2001-06-24 04:09:10 -04:00
|
|
|
|
|
|
|
sorted = g_list_copy (windows);
|
|
|
|
sorted = g_list_sort (sorted, northwestcmp);
|
|
|
|
|
|
|
|
/* This is a "fuzzy" cascade algorithm.
|
|
|
|
* For each window in the list, we find where we'd cascade a
|
|
|
|
* new window after it. If a window is already nearly at that
|
|
|
|
* position, we move on.
|
|
|
|
*/
|
2002-10-01 22:42:24 -04:00
|
|
|
|
|
|
|
/* arbitrary-ish threshold, honors user attempts to
|
|
|
|
* manually cascade.
|
|
|
|
*/
|
|
|
|
#define CASCADE_FUZZ 15
|
|
|
|
if (fgeom)
|
|
|
|
{
|
|
|
|
x_threshold = MAX (fgeom->left_width, CASCADE_FUZZ);
|
|
|
|
y_threshold = MAX (fgeom->top_height, CASCADE_FUZZ);
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
x_threshold = CASCADE_FUZZ;
|
|
|
|
y_threshold = CASCADE_FUZZ;
|
|
|
|
}
|
|
|
|
|
2001-06-24 04:09:10 -04:00
|
|
|
/* Find furthest-SE origin of all workspaces.
|
|
|
|
* cascade_x, cascade_y are the target position
|
|
|
|
* of NW corner of window frame.
|
|
|
|
*/
|
2003-02-23 12:09:46 -05:00
|
|
|
|
2003-04-06 23:33:45 -04:00
|
|
|
current = meta_screen_get_current_xinerama (window->screen);
|
|
|
|
meta_window_get_work_area_for_xinerama (window, current->number, &work_area);
|
2003-02-23 12:09:46 -05:00
|
|
|
|
2002-01-10 01:31:31 -05:00
|
|
|
cascade_x = MAX (0, work_area.x);
|
|
|
|
cascade_y = MAX (0, work_area.y);
|
2002-10-01 22:42:24 -04:00
|
|
|
|
2001-06-24 04:09:10 -04:00
|
|
|
/* Find first cascade position that's not used. */
|
|
|
|
|
2002-10-01 22:42:24 -04:00
|
|
|
window_width = window->frame ? window->frame->rect.width : window->rect.width;
|
|
|
|
window_height = window->frame ? window->frame->rect.height : window->rect.height;
|
|
|
|
|
|
|
|
cascade_stage = 0;
|
2001-06-24 04:09:10 -04:00
|
|
|
tmp = sorted;
|
|
|
|
while (tmp != NULL)
|
|
|
|
{
|
|
|
|
MetaWindow *w;
|
|
|
|
int wx, wy;
|
|
|
|
|
|
|
|
w = tmp->data;
|
|
|
|
|
|
|
|
/* we want frame position, not window position */
|
|
|
|
if (w->frame)
|
|
|
|
{
|
|
|
|
wx = w->frame->rect.x;
|
|
|
|
wy = w->frame->rect.y;
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
wx = w->rect.x;
|
|
|
|
wy = w->rect.y;
|
|
|
|
}
|
2002-10-01 22:42:24 -04:00
|
|
|
|
2001-06-24 04:09:10 -04:00
|
|
|
if (ABS (wx - cascade_x) < x_threshold &&
|
|
|
|
ABS (wy - cascade_y) < y_threshold)
|
|
|
|
{
|
|
|
|
/* This window is "in the way", move to next cascade
|
|
|
|
* point. The new window frame should go at the origin
|
|
|
|
* of the client window we're stacking above.
|
|
|
|
*/
|
|
|
|
meta_window_get_position (w, &wx, &wy);
|
|
|
|
cascade_x = wx;
|
|
|
|
cascade_y = wy;
|
2002-10-01 22:42:24 -04:00
|
|
|
|
|
|
|
/* If we go off the screen, start over with a new cascade */
|
|
|
|
if (((cascade_x + window_width) >
|
|
|
|
(work_area.x + work_area.width)) ||
|
|
|
|
((cascade_y + window_height) >
|
|
|
|
(work_area.y + work_area.height)))
|
|
|
|
{
|
|
|
|
cascade_x = MAX (0, work_area.x);
|
|
|
|
cascade_y = MAX (0, work_area.y);
|
|
|
|
|
|
|
|
#define CASCADE_INTERVAL 50 /* space between top-left corners of cascades */
|
|
|
|
cascade_stage += 1;
|
|
|
|
cascade_x += CASCADE_INTERVAL * cascade_stage;
|
|
|
|
|
|
|
|
/* start over with a new cascade translated to the right, unless
|
|
|
|
* we are out of space
|
|
|
|
*/
|
|
|
|
if ((cascade_x + window_width) <
|
|
|
|
(work_area.x + work_area.width))
|
|
|
|
{
|
|
|
|
tmp = sorted;
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
/* All out of space, this cascade_x won't work */
|
|
|
|
cascade_x = MAX (0, work_area.x);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
2001-06-24 04:09:10 -04:00
|
|
|
}
|
|
|
|
else
|
2002-07-12 19:03:40 -04:00
|
|
|
{
|
|
|
|
/* Keep searching for a further-down-the-diagonal window. */
|
|
|
|
}
|
2001-06-24 04:09:10 -04:00
|
|
|
|
|
|
|
tmp = tmp->next;
|
|
|
|
}
|
|
|
|
|
2002-07-12 19:03:40 -04:00
|
|
|
/* cascade_x and cascade_y will match the last window in the list
|
|
|
|
* that was "in the way" (in the approximate cascade diagonal)
|
|
|
|
*/
|
2001-06-24 04:09:10 -04:00
|
|
|
|
|
|
|
g_list_free (sorted);
|
|
|
|
|
|
|
|
/* Convert coords to position of window, not position of frame. */
|
|
|
|
if (fgeom == NULL)
|
|
|
|
{
|
|
|
|
*new_x = cascade_x;
|
|
|
|
*new_y = cascade_y;
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
*new_x = cascade_x + fgeom->left_width;
|
|
|
|
*new_y = cascade_y + fgeom->top_height;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2005-02-11 14:20:44 -05:00
|
|
|
static void
|
|
|
|
find_most_freespace (MetaWindow *window,
|
|
|
|
MetaFrameGeometry *fgeom,
|
|
|
|
/* visible windows on relevant workspaces */
|
|
|
|
MetaWindow *focus_window,
|
|
|
|
int x,
|
|
|
|
int y,
|
|
|
|
int *new_x,
|
|
|
|
int *new_y)
|
|
|
|
{
|
|
|
|
MetaWindowDirection side;
|
|
|
|
int max_area;
|
|
|
|
int max_width, max_height, left, right, top, bottom;
|
2005-07-24 22:12:58 -04:00
|
|
|
int left_space, right_space, top_space, bottom_space;
|
2005-02-11 14:20:44 -05:00
|
|
|
int frame_size_left, frame_size_top;
|
|
|
|
MetaRectangle work_area;
|
|
|
|
MetaRectangle avoid;
|
|
|
|
MetaRectangle outer;
|
|
|
|
|
|
|
|
frame_size_left = fgeom ? fgeom->left_width : 0;
|
|
|
|
frame_size_top = fgeom ? fgeom->top_height : 0;
|
|
|
|
|
|
|
|
meta_window_get_work_area_current_xinerama (focus_window, &work_area);
|
|
|
|
meta_window_get_outer_rect (focus_window, &avoid);
|
|
|
|
meta_window_get_outer_rect (window, &outer);
|
|
|
|
|
|
|
|
/* Find the areas of choosing the various sides of the focus window */
|
|
|
|
max_width = MIN (avoid.width, outer.width);
|
|
|
|
max_height = MIN (avoid.height, outer.height);
|
2005-07-24 22:12:58 -04:00
|
|
|
left_space = avoid.x - work_area.x;
|
|
|
|
right_space = work_area.width - (avoid.x + avoid.width - work_area.x);
|
|
|
|
top_space = avoid.y - work_area.y;
|
|
|
|
bottom_space = work_area.height - (avoid.y + avoid.height - work_area.y);
|
|
|
|
left = MIN (left_space, outer.width);
|
|
|
|
right = MIN (right_space, outer.width);
|
|
|
|
top = MIN (top_space, outer.height);
|
|
|
|
bottom = MIN (bottom_space, outer.height);
|
2005-02-11 14:20:44 -05:00
|
|
|
|
|
|
|
/* Find out which side of the focus_window can show the most of the window */
|
|
|
|
side = META_LEFT;
|
|
|
|
max_area = left*max_height;
|
|
|
|
if (right*max_height > max_area)
|
|
|
|
{
|
|
|
|
side = META_RIGHT;
|
|
|
|
max_area = right*max_height;
|
|
|
|
}
|
|
|
|
if (top*max_width > max_area)
|
|
|
|
{
|
|
|
|
side = META_TOP;
|
|
|
|
max_area = top*max_width;
|
|
|
|
}
|
|
|
|
if (bottom*max_width > max_area)
|
2005-07-24 22:12:58 -04:00
|
|
|
{
|
|
|
|
side = META_BOTTOM;
|
|
|
|
max_area = bottom*max_width;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Give up if there's no where to put it (i.e. focus window is maximized) */
|
|
|
|
if (max_area == 0)
|
|
|
|
return;
|
2005-02-11 14:20:44 -05:00
|
|
|
|
2005-07-24 22:12:58 -04:00
|
|
|
/* Place the window on the relevant side; if the whole window fits,
|
|
|
|
* make it adjacent to the focus window; if not, make sure the
|
|
|
|
* window doesn't go off the edge of the screen.
|
2005-02-11 14:20:44 -05:00
|
|
|
*/
|
|
|
|
switch (side)
|
|
|
|
{
|
|
|
|
case META_LEFT:
|
|
|
|
*new_y = avoid.y + frame_size_top;
|
2005-07-24 22:12:58 -04:00
|
|
|
if (left_space > outer.width)
|
|
|
|
*new_x = avoid.x - outer.width + frame_size_left;
|
|
|
|
else
|
|
|
|
*new_x = work_area.x + frame_size_left;
|
2005-02-11 14:20:44 -05:00
|
|
|
break;
|
|
|
|
case META_RIGHT:
|
|
|
|
*new_y = avoid.y + frame_size_top;
|
2005-07-24 22:12:58 -04:00
|
|
|
if (right_space > outer.width)
|
|
|
|
*new_x = avoid.x + avoid.width + frame_size_left;
|
|
|
|
else
|
|
|
|
*new_x = work_area.x + work_area.width - outer.width + frame_size_left;
|
2005-02-11 14:20:44 -05:00
|
|
|
break;
|
|
|
|
case META_TOP:
|
|
|
|
*new_x = avoid.x + frame_size_left;
|
2005-07-24 22:12:58 -04:00
|
|
|
if (top_space > outer.height)
|
|
|
|
*new_y = avoid.y - outer.height + frame_size_top;
|
|
|
|
else
|
|
|
|
*new_y = work_area.y + frame_size_top;
|
2005-02-11 14:20:44 -05:00
|
|
|
break;
|
|
|
|
case META_BOTTOM:
|
|
|
|
*new_x = avoid.x + frame_size_left;
|
2005-07-24 22:12:58 -04:00
|
|
|
if (bottom_space > outer.height)
|
|
|
|
*new_y = avoid.y + avoid.height + frame_size_top;
|
|
|
|
else
|
|
|
|
*new_y = work_area.y + work_area.height - outer.height + frame_size_top;
|
2005-02-11 14:20:44 -05:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2005-07-24 22:12:58 -04:00
|
|
|
static void
|
|
|
|
avoid_being_obscured_as_second_modal_dialog (MetaWindow *window,
|
|
|
|
MetaFrameGeometry *fgeom,
|
|
|
|
int *x,
|
|
|
|
int *y)
|
|
|
|
{
|
|
|
|
/* We can't center this dialog if it was denied focus and it
|
|
|
|
* overlaps with the focus window and this dialog is modal and this
|
|
|
|
* dialog is in the same app as the focus window (*phew*...please
|
|
|
|
* don't make me say that ten times fast). See bug 307875 comment 11
|
|
|
|
* and 12 for details, but basically it means this is probably a
|
|
|
|
* second modal dialog for some app while the focus window is the
|
|
|
|
* first modal dialog. We should probably make them simultaneously
|
|
|
|
* visible in general, but it becomes mandatory to do so due to
|
|
|
|
* buggy apps (e.g. those using gtk+ *sigh*) because in those cases
|
|
|
|
* this second modal dialog also happens to be modal to the first
|
|
|
|
* dialog in addition to the main window, while it has only let us
|
|
|
|
* know about the modal-to-the-main-window part.
|
|
|
|
*/
|
|
|
|
|
|
|
|
MetaWindow *focus_window;
|
|
|
|
MetaRectangle overlap;
|
|
|
|
|
|
|
|
focus_window = window->display->focus_window;
|
|
|
|
|
|
|
|
if (window->denied_focus_and_not_transient &&
|
|
|
|
window->wm_state_modal && /* FIXME: Maybe do this for all transients? */
|
|
|
|
meta_window_same_application (window, focus_window) &&
|
|
|
|
meta_rectangle_intersect (&window->rect,
|
|
|
|
&focus_window->rect,
|
|
|
|
&overlap))
|
|
|
|
{
|
|
|
|
find_most_freespace (window, fgeom, focus_window, *x, *y, x, y);
|
|
|
|
meta_topic (META_DEBUG_PLACEMENT,
|
|
|
|
"Dialog window %s was denied focus but may be modal "
|
|
|
|
"to the focus window; had to move it to avoid the "
|
|
|
|
"focus window\n",
|
|
|
|
window->desc);
|
|
|
|
}
|
|
|
|
}
|
2005-02-11 14:20:44 -05:00
|
|
|
|
2002-06-17 23:06:07 -04:00
|
|
|
static gboolean
|
|
|
|
rectangle_overlaps_some_window (MetaRectangle *rect,
|
|
|
|
GList *windows)
|
|
|
|
{
|
|
|
|
GList *tmp;
|
|
|
|
MetaRectangle dest;
|
|
|
|
|
|
|
|
tmp = windows;
|
|
|
|
while (tmp != NULL)
|
|
|
|
{
|
|
|
|
MetaWindow *other = tmp->data;
|
|
|
|
MetaRectangle other_rect;
|
|
|
|
|
|
|
|
switch (other->type)
|
|
|
|
{
|
|
|
|
case META_WINDOW_DOCK:
|
|
|
|
case META_WINDOW_SPLASHSCREEN:
|
|
|
|
case META_WINDOW_DESKTOP:
|
|
|
|
case META_WINDOW_DIALOG:
|
|
|
|
case META_WINDOW_MODAL_DIALOG:
|
|
|
|
break;
|
|
|
|
|
|
|
|
case META_WINDOW_NORMAL:
|
|
|
|
case META_WINDOW_UTILITY:
|
|
|
|
case META_WINDOW_TOOLBAR:
|
|
|
|
case META_WINDOW_MENU:
|
|
|
|
meta_window_get_outer_rect (other, &other_rect);
|
|
|
|
|
|
|
|
if (meta_rectangle_intersect (rect, &other_rect, &dest))
|
|
|
|
return TRUE;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
tmp = tmp->next;
|
|
|
|
}
|
|
|
|
|
|
|
|
return FALSE;
|
|
|
|
}
|
|
|
|
|
|
|
|
static gint
|
|
|
|
leftmost_cmp (gconstpointer a, gconstpointer b)
|
|
|
|
{
|
|
|
|
MetaWindow *aw = (gpointer) a;
|
|
|
|
MetaWindow *bw = (gpointer) b;
|
|
|
|
int ax, bx;
|
|
|
|
|
|
|
|
/* we're interested in the frame position for cascading,
|
|
|
|
* not meta_window_get_position()
|
|
|
|
*/
|
|
|
|
if (aw->frame)
|
|
|
|
ax = aw->frame->rect.x;
|
|
|
|
else
|
|
|
|
ax = aw->rect.x;
|
|
|
|
|
|
|
|
if (bw->frame)
|
|
|
|
bx = bw->frame->rect.x;
|
|
|
|
else
|
|
|
|
bx = bw->rect.x;
|
|
|
|
|
|
|
|
if (ax < bx)
|
|
|
|
return -1;
|
|
|
|
else if (ax > bx)
|
|
|
|
return 1;
|
|
|
|
else
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static gint
|
|
|
|
topmost_cmp (gconstpointer a, gconstpointer b)
|
|
|
|
{
|
|
|
|
MetaWindow *aw = (gpointer) a;
|
|
|
|
MetaWindow *bw = (gpointer) b;
|
|
|
|
int ay, by;
|
|
|
|
|
|
|
|
/* we're interested in the frame position for cascading,
|
|
|
|
* not meta_window_get_position()
|
|
|
|
*/
|
|
|
|
if (aw->frame)
|
|
|
|
ay = aw->frame->rect.y;
|
|
|
|
else
|
|
|
|
ay = aw->rect.y;
|
|
|
|
|
|
|
|
if (bw->frame)
|
|
|
|
by = bw->frame->rect.y;
|
|
|
|
else
|
|
|
|
by = bw->rect.y;
|
|
|
|
|
|
|
|
if (ay < by)
|
|
|
|
return -1;
|
|
|
|
else if (ay > by)
|
|
|
|
return 1;
|
|
|
|
else
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2003-02-23 12:09:46 -05:00
|
|
|
static void
|
|
|
|
center_tile_rect_in_area (MetaRectangle *rect,
|
|
|
|
MetaRectangle *work_area)
|
|
|
|
{
|
|
|
|
int fluff;
|
|
|
|
|
|
|
|
/* The point here is to tile a window such that "extra"
|
|
|
|
* space is equal on either side (i.e. so a full screen
|
|
|
|
* of windows tiled this way would center the windows
|
|
|
|
* as a group)
|
|
|
|
*/
|
2003-04-05 20:22:56 -05:00
|
|
|
|
|
|
|
fluff = (work_area->width % (rect->width+1)) / 2;
|
2003-02-23 12:09:46 -05:00
|
|
|
rect->x = work_area->x + fluff;
|
2003-04-05 20:22:56 -05:00
|
|
|
fluff = (work_area->height % (rect->height+1)) / 3;
|
2003-02-23 12:09:46 -05:00
|
|
|
rect->y = work_area->y + fluff;
|
|
|
|
}
|
|
|
|
|
2001-06-24 04:09:10 -04:00
|
|
|
/* Find the leftmost, then topmost, empty area on the workspace
|
|
|
|
* that can contain the new window.
|
2001-07-28 02:35:19 -04:00
|
|
|
*
|
|
|
|
* Cool feature to have: if we can't fit the current window size,
|
|
|
|
* try shrinking the window (within geometry constraints). But
|
|
|
|
* beware windows such as Emacs with no sane minimum size, we
|
|
|
|
* don't want to create a 1x1 Emacs.
|
2001-06-24 04:09:10 -04:00
|
|
|
*/
|
|
|
|
static gboolean
|
|
|
|
find_first_fit (MetaWindow *window,
|
|
|
|
MetaFrameGeometry *fgeom,
|
|
|
|
/* visible windows on relevant workspaces */
|
|
|
|
GList *windows,
|
2007-06-18 07:46:44 -04:00
|
|
|
int xinerama,
|
2001-06-24 04:09:10 -04:00
|
|
|
int x,
|
|
|
|
int y,
|
|
|
|
int *new_x,
|
|
|
|
int *new_y)
|
|
|
|
{
|
2002-06-17 23:06:07 -04:00
|
|
|
/* This algorithm is limited - it just brute-force tries
|
|
|
|
* to fit the window in a small number of locations that are aligned
|
|
|
|
* with existing windows. It tries to place the window on
|
|
|
|
* the bottom of each existing window, and then to the right
|
|
|
|
* of each existing window, aligned with the left/top of the
|
|
|
|
* existing window in each of those cases.
|
2003-02-23 12:09:46 -05:00
|
|
|
*/
|
2002-06-17 23:06:07 -04:00
|
|
|
int retval;
|
2003-04-06 00:57:36 -05:00
|
|
|
GList *below_sorted;
|
|
|
|
GList *right_sorted;
|
2002-06-17 23:06:07 -04:00
|
|
|
GList *tmp;
|
|
|
|
MetaRectangle rect;
|
2003-02-23 12:09:46 -05:00
|
|
|
MetaRectangle work_area;
|
2002-06-17 23:06:07 -04:00
|
|
|
|
|
|
|
retval = FALSE;
|
2003-04-06 00:57:36 -05:00
|
|
|
|
|
|
|
/* Below each window */
|
|
|
|
below_sorted = g_list_copy (windows);
|
|
|
|
below_sorted = g_list_sort (below_sorted, leftmost_cmp);
|
|
|
|
below_sorted = g_list_sort (below_sorted, topmost_cmp);
|
|
|
|
|
|
|
|
/* To the right of each window */
|
|
|
|
right_sorted = g_list_copy (windows);
|
|
|
|
right_sorted = g_list_sort (right_sorted, topmost_cmp);
|
|
|
|
right_sorted = g_list_sort (right_sorted, leftmost_cmp);
|
2002-09-12 16:46:03 -04:00
|
|
|
|
2002-06-17 23:06:07 -04:00
|
|
|
rect.width = window->rect.width;
|
|
|
|
rect.height = window->rect.height;
|
|
|
|
|
|
|
|
if (fgeom)
|
|
|
|
{
|
|
|
|
rect.width += fgeom->left_width + fgeom->right_width;
|
|
|
|
rect.height += fgeom->top_height + fgeom->bottom_height;
|
|
|
|
}
|
2002-09-12 16:46:03 -04:00
|
|
|
|
Merge of all the changes on the constraints_experiments branch. This is
2005-11-18 Elijah Newren <newren@gmail.com>
Merge of all the changes on the constraints_experiments branch.
This is just a summary, to get the full ChangeLog of those
changes (approx. 2000 lines):
cvs -q -z3 update -Pd -r constraints_experiments
cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog
Bugs fixed:
unfiled - constraints.c is overly complicated[1]
unfiled - constraints.c is not robust when all constraints
cannot simultaneously be met (constraints need to be
prioritized)
unfiled - keep-titlebar-onscreen constraint is decoration
unaware (since get_outermost_onscreen_positions()
forgets to include decorations)
unfiled - keyboard snap-moving and snap-resizing snap to hidden
edges
109553 - gravity w/ simultaneous move & resize doesn't work
113601 - maximize vertical and horizontal should toggle and be
constrained
122196 - windows show up under vertical panels
122670 - jerky/random resizing of window via keyboard[2]
124582 - keyboard and mouse snap-resizing and snap-moving
erroneously moves the window multidimensionally
136307 - don't allow apps to resize themselves off the screen
(*cough* filechooser *cough*)
142016, 143784 - windows should not span multiple xineramas
unless placed there by the user
143145 - clamp new windows to screensize and force them
onscreen, if they'll fit
144126 - Handle pathological strut lists sanely[3]
149867 - fixed aspect ratio windows are difficult to resize[4]
152898 - make screen edges consistent; allow easy slamming of
windows into the left, right, and bottom edges of the
screen too.
154706 - bouncing weirdness at screen edge with keyboard moving
or resizing
156699 - avoid struts when placing windows, if possible (nasty
a11y blocker)
302456 - dragging offscreen too restrictive
304857 - wireframe moving off the top of the screen is misleading
308521 - make uni-directional resizing easier with
alt-middle-drag and prevent the occasional super
annoying resize-the-wrong-side(s) behavior
312007 - snap-resize moves windows with a minimum size
constraint
312104 - resizing the top of a window can cause the bottom to
grow
319351 - don't instantly snap on mouse-move-snapping, remove
braindeadedness of having order of releasing shift and
releasing button press matter so much
[1] fixed in my opinion, anyway.
[2] Actually, it's not totally fixed--it's just annoying
instead of almost completely unusable. Matthias had a
suggestion that may fix the remainder of the problems (see
http://tinyurl.com/bwzuu).
[3] This bug was originally about not-quite-so-pathological
cases but was left open for the worse cases. The code from
the branch handles the remainder of the cases mentioned in
this bug.
[4] Actually, although it's far better there's still some minor
issues left: a slight drift that's only noticeable after
lots of resizing, and potential problems with partially
onscreen constraints due to not clearing any
fixed_directions flags (aspect ratio windows get resized in
both directions and thus aren't fixed in one of them)
New feature:
81704 - edge resistance for user move and resize operations;
in particular 3 different kinds of resistance are
implemented:
Pixel-Distance: window movement is resisted when it
aligns with an edge unless the movement is greater than
a threshold number of pixels
Timeout: window movement past an edge is prevented until
a certain amount of time has elapsed during the
operation since the first request to move it past that
edge
Keyboard-Buildup: when moving or resizing with the
keyboard, once a window is aligned with a certain edge
it cannot move past until the correct direction has
been pressed enough times (e.g. 2 or 3 times)
Major changes:
- constraints.c has been rewritten; very few lines of code from
the old version remain. There is a comment near the top of
the function explaining the basics of how the new framework
works. A more detailed explanation can be found in
doc/how-constraints-works.txt
- edge-resistance.[ch] are new files implementing edge-resistance.
- boxes.[ch] are new files containing low-level error-prone
functions used heavily in constraints.c and edge-resistance.c,
among various places throughout the code. testboxes.c
contains a thorough testsuite for the boxes.[ch] functions
compiled into a program, testboxes.
- meta_window_move_resize_internal() *must* be told the gravity
of the associated operation (if it's just a move operation,
the gravity will be ignored, but for resize and move+resize
the correct value is needed)
- the craziness of different values that
meta_window_move_resize_internal() accepts has been documented
in a large comment at the beginning of the function. It may
be possible to clean this up some, but until then things will
remain as they were before--caller beware.
- screen and xinerama usable areas (i.e. places not covered by
e.g. panels) are cached in the workspace now, as are the
screen and xinerama edges. These get updated with the
workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 09:58:50 -05:00
|
|
|
#ifdef WITH_VERBOSE_MODE
|
2007-06-18 07:46:44 -04:00
|
|
|
{
|
Merge of all the changes on the constraints_experiments branch. This is
2005-11-18 Elijah Newren <newren@gmail.com>
Merge of all the changes on the constraints_experiments branch.
This is just a summary, to get the full ChangeLog of those
changes (approx. 2000 lines):
cvs -q -z3 update -Pd -r constraints_experiments
cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog
Bugs fixed:
unfiled - constraints.c is overly complicated[1]
unfiled - constraints.c is not robust when all constraints
cannot simultaneously be met (constraints need to be
prioritized)
unfiled - keep-titlebar-onscreen constraint is decoration
unaware (since get_outermost_onscreen_positions()
forgets to include decorations)
unfiled - keyboard snap-moving and snap-resizing snap to hidden
edges
109553 - gravity w/ simultaneous move & resize doesn't work
113601 - maximize vertical and horizontal should toggle and be
constrained
122196 - windows show up under vertical panels
122670 - jerky/random resizing of window via keyboard[2]
124582 - keyboard and mouse snap-resizing and snap-moving
erroneously moves the window multidimensionally
136307 - don't allow apps to resize themselves off the screen
(*cough* filechooser *cough*)
142016, 143784 - windows should not span multiple xineramas
unless placed there by the user
143145 - clamp new windows to screensize and force them
onscreen, if they'll fit
144126 - Handle pathological strut lists sanely[3]
149867 - fixed aspect ratio windows are difficult to resize[4]
152898 - make screen edges consistent; allow easy slamming of
windows into the left, right, and bottom edges of the
screen too.
154706 - bouncing weirdness at screen edge with keyboard moving
or resizing
156699 - avoid struts when placing windows, if possible (nasty
a11y blocker)
302456 - dragging offscreen too restrictive
304857 - wireframe moving off the top of the screen is misleading
308521 - make uni-directional resizing easier with
alt-middle-drag and prevent the occasional super
annoying resize-the-wrong-side(s) behavior
312007 - snap-resize moves windows with a minimum size
constraint
312104 - resizing the top of a window can cause the bottom to
grow
319351 - don't instantly snap on mouse-move-snapping, remove
braindeadedness of having order of releasing shift and
releasing button press matter so much
[1] fixed in my opinion, anyway.
[2] Actually, it's not totally fixed--it's just annoying
instead of almost completely unusable. Matthias had a
suggestion that may fix the remainder of the problems (see
http://tinyurl.com/bwzuu).
[3] This bug was originally about not-quite-so-pathological
cases but was left open for the worse cases. The code from
the branch handles the remainder of the cases mentioned in
this bug.
[4] Actually, although it's far better there's still some minor
issues left: a slight drift that's only noticeable after
lots of resizing, and potential problems with partially
onscreen constraints due to not clearing any
fixed_directions flags (aspect ratio windows get resized in
both directions and thus aren't fixed in one of them)
New feature:
81704 - edge resistance for user move and resize operations;
in particular 3 different kinds of resistance are
implemented:
Pixel-Distance: window movement is resisted when it
aligns with an edge unless the movement is greater than
a threshold number of pixels
Timeout: window movement past an edge is prevented until
a certain amount of time has elapsed during the
operation since the first request to move it past that
edge
Keyboard-Buildup: when moving or resizing with the
keyboard, once a window is aligned with a certain edge
it cannot move past until the correct direction has
been pressed enough times (e.g. 2 or 3 times)
Major changes:
- constraints.c has been rewritten; very few lines of code from
the old version remain. There is a comment near the top of
the function explaining the basics of how the new framework
works. A more detailed explanation can be found in
doc/how-constraints-works.txt
- edge-resistance.[ch] are new files implementing edge-resistance.
- boxes.[ch] are new files containing low-level error-prone
functions used heavily in constraints.c and edge-resistance.c,
among various places throughout the code. testboxes.c
contains a thorough testsuite for the boxes.[ch] functions
compiled into a program, testboxes.
- meta_window_move_resize_internal() *must* be told the gravity
of the associated operation (if it's just a move operation,
the gravity will be ignored, but for resize and move+resize
the correct value is needed)
- the craziness of different values that
meta_window_move_resize_internal() accepts has been documented
in a large comment at the beginning of the function. It may
be possible to clean this up some, but until then things will
remain as they were before--caller beware.
- screen and xinerama usable areas (i.e. places not covered by
e.g. panels) are cached in the workspace now, as are the
screen and xinerama edges. These get updated with the
workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 09:58:50 -05:00
|
|
|
char xinerama_location_string[RECT_LENGTH];
|
2007-06-18 07:46:44 -04:00
|
|
|
meta_rectangle_to_string (&window->screen->xinerama_infos[xinerama].rect,
|
Merge of all the changes on the constraints_experiments branch. This is
2005-11-18 Elijah Newren <newren@gmail.com>
Merge of all the changes on the constraints_experiments branch.
This is just a summary, to get the full ChangeLog of those
changes (approx. 2000 lines):
cvs -q -z3 update -Pd -r constraints_experiments
cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog
Bugs fixed:
unfiled - constraints.c is overly complicated[1]
unfiled - constraints.c is not robust when all constraints
cannot simultaneously be met (constraints need to be
prioritized)
unfiled - keep-titlebar-onscreen constraint is decoration
unaware (since get_outermost_onscreen_positions()
forgets to include decorations)
unfiled - keyboard snap-moving and snap-resizing snap to hidden
edges
109553 - gravity w/ simultaneous move & resize doesn't work
113601 - maximize vertical and horizontal should toggle and be
constrained
122196 - windows show up under vertical panels
122670 - jerky/random resizing of window via keyboard[2]
124582 - keyboard and mouse snap-resizing and snap-moving
erroneously moves the window multidimensionally
136307 - don't allow apps to resize themselves off the screen
(*cough* filechooser *cough*)
142016, 143784 - windows should not span multiple xineramas
unless placed there by the user
143145 - clamp new windows to screensize and force them
onscreen, if they'll fit
144126 - Handle pathological strut lists sanely[3]
149867 - fixed aspect ratio windows are difficult to resize[4]
152898 - make screen edges consistent; allow easy slamming of
windows into the left, right, and bottom edges of the
screen too.
154706 - bouncing weirdness at screen edge with keyboard moving
or resizing
156699 - avoid struts when placing windows, if possible (nasty
a11y blocker)
302456 - dragging offscreen too restrictive
304857 - wireframe moving off the top of the screen is misleading
308521 - make uni-directional resizing easier with
alt-middle-drag and prevent the occasional super
annoying resize-the-wrong-side(s) behavior
312007 - snap-resize moves windows with a minimum size
constraint
312104 - resizing the top of a window can cause the bottom to
grow
319351 - don't instantly snap on mouse-move-snapping, remove
braindeadedness of having order of releasing shift and
releasing button press matter so much
[1] fixed in my opinion, anyway.
[2] Actually, it's not totally fixed--it's just annoying
instead of almost completely unusable. Matthias had a
suggestion that may fix the remainder of the problems (see
http://tinyurl.com/bwzuu).
[3] This bug was originally about not-quite-so-pathological
cases but was left open for the worse cases. The code from
the branch handles the remainder of the cases mentioned in
this bug.
[4] Actually, although it's far better there's still some minor
issues left: a slight drift that's only noticeable after
lots of resizing, and potential problems with partially
onscreen constraints due to not clearing any
fixed_directions flags (aspect ratio windows get resized in
both directions and thus aren't fixed in one of them)
New feature:
81704 - edge resistance for user move and resize operations;
in particular 3 different kinds of resistance are
implemented:
Pixel-Distance: window movement is resisted when it
aligns with an edge unless the movement is greater than
a threshold number of pixels
Timeout: window movement past an edge is prevented until
a certain amount of time has elapsed during the
operation since the first request to move it past that
edge
Keyboard-Buildup: when moving or resizing with the
keyboard, once a window is aligned with a certain edge
it cannot move past until the correct direction has
been pressed enough times (e.g. 2 or 3 times)
Major changes:
- constraints.c has been rewritten; very few lines of code from
the old version remain. There is a comment near the top of
the function explaining the basics of how the new framework
works. A more detailed explanation can be found in
doc/how-constraints-works.txt
- edge-resistance.[ch] are new files implementing edge-resistance.
- boxes.[ch] are new files containing low-level error-prone
functions used heavily in constraints.c and edge-resistance.c,
among various places throughout the code. testboxes.c
contains a thorough testsuite for the boxes.[ch] functions
compiled into a program, testboxes.
- meta_window_move_resize_internal() *must* be told the gravity
of the associated operation (if it's just a move operation,
the gravity will be ignored, but for resize and move+resize
the correct value is needed)
- the craziness of different values that
meta_window_move_resize_internal() accepts has been documented
in a large comment at the beginning of the function. It may
be possible to clean this up some, but until then things will
remain as they were before--caller beware.
- screen and xinerama usable areas (i.e. places not covered by
e.g. panels) are cached in the workspace now, as are the
screen and xinerama edges. These get updated with the
workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 09:58:50 -05:00
|
|
|
xinerama_location_string);
|
2003-04-06 00:57:36 -05:00
|
|
|
meta_topic (META_DEBUG_XINERAMA,
|
2007-06-18 07:46:44 -04:00
|
|
|
"Natural xinerama is %s\n",
|
Merge of all the changes on the constraints_experiments branch. This is
2005-11-18 Elijah Newren <newren@gmail.com>
Merge of all the changes on the constraints_experiments branch.
This is just a summary, to get the full ChangeLog of those
changes (approx. 2000 lines):
cvs -q -z3 update -Pd -r constraints_experiments
cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog
Bugs fixed:
unfiled - constraints.c is overly complicated[1]
unfiled - constraints.c is not robust when all constraints
cannot simultaneously be met (constraints need to be
prioritized)
unfiled - keep-titlebar-onscreen constraint is decoration
unaware (since get_outermost_onscreen_positions()
forgets to include decorations)
unfiled - keyboard snap-moving and snap-resizing snap to hidden
edges
109553 - gravity w/ simultaneous move & resize doesn't work
113601 - maximize vertical and horizontal should toggle and be
constrained
122196 - windows show up under vertical panels
122670 - jerky/random resizing of window via keyboard[2]
124582 - keyboard and mouse snap-resizing and snap-moving
erroneously moves the window multidimensionally
136307 - don't allow apps to resize themselves off the screen
(*cough* filechooser *cough*)
142016, 143784 - windows should not span multiple xineramas
unless placed there by the user
143145 - clamp new windows to screensize and force them
onscreen, if they'll fit
144126 - Handle pathological strut lists sanely[3]
149867 - fixed aspect ratio windows are difficult to resize[4]
152898 - make screen edges consistent; allow easy slamming of
windows into the left, right, and bottom edges of the
screen too.
154706 - bouncing weirdness at screen edge with keyboard moving
or resizing
156699 - avoid struts when placing windows, if possible (nasty
a11y blocker)
302456 - dragging offscreen too restrictive
304857 - wireframe moving off the top of the screen is misleading
308521 - make uni-directional resizing easier with
alt-middle-drag and prevent the occasional super
annoying resize-the-wrong-side(s) behavior
312007 - snap-resize moves windows with a minimum size
constraint
312104 - resizing the top of a window can cause the bottom to
grow
319351 - don't instantly snap on mouse-move-snapping, remove
braindeadedness of having order of releasing shift and
releasing button press matter so much
[1] fixed in my opinion, anyway.
[2] Actually, it's not totally fixed--it's just annoying
instead of almost completely unusable. Matthias had a
suggestion that may fix the remainder of the problems (see
http://tinyurl.com/bwzuu).
[3] This bug was originally about not-quite-so-pathological
cases but was left open for the worse cases. The code from
the branch handles the remainder of the cases mentioned in
this bug.
[4] Actually, although it's far better there's still some minor
issues left: a slight drift that's only noticeable after
lots of resizing, and potential problems with partially
onscreen constraints due to not clearing any
fixed_directions flags (aspect ratio windows get resized in
both directions and thus aren't fixed in one of them)
New feature:
81704 - edge resistance for user move and resize operations;
in particular 3 different kinds of resistance are
implemented:
Pixel-Distance: window movement is resisted when it
aligns with an edge unless the movement is greater than
a threshold number of pixels
Timeout: window movement past an edge is prevented until
a certain amount of time has elapsed during the
operation since the first request to move it past that
edge
Keyboard-Buildup: when moving or resizing with the
keyboard, once a window is aligned with a certain edge
it cannot move past until the correct direction has
been pressed enough times (e.g. 2 or 3 times)
Major changes:
- constraints.c has been rewritten; very few lines of code from
the old version remain. There is a comment near the top of
the function explaining the basics of how the new framework
works. A more detailed explanation can be found in
doc/how-constraints-works.txt
- edge-resistance.[ch] are new files implementing edge-resistance.
- boxes.[ch] are new files containing low-level error-prone
functions used heavily in constraints.c and edge-resistance.c,
among various places throughout the code. testboxes.c
contains a thorough testsuite for the boxes.[ch] functions
compiled into a program, testboxes.
- meta_window_move_resize_internal() *must* be told the gravity
of the associated operation (if it's just a move operation,
the gravity will be ignored, but for resize and move+resize
the correct value is needed)
- the craziness of different values that
meta_window_move_resize_internal() accepts has been documented
in a large comment at the beginning of the function. It may
be possible to clean this up some, but until then things will
remain as they were before--caller beware.
- screen and xinerama usable areas (i.e. places not covered by
e.g. panels) are cached in the workspace now, as are the
screen and xinerama edges. These get updated with the
workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 09:58:50 -05:00
|
|
|
xinerama_location_string);
|
2002-09-12 16:46:03 -04:00
|
|
|
}
|
2007-06-18 07:46:44 -04:00
|
|
|
#endif
|
2002-06-17 23:06:07 -04:00
|
|
|
|
2007-06-18 07:46:44 -04:00
|
|
|
meta_window_get_work_area_for_xinerama (window, xinerama, &work_area);
|
2002-06-17 23:06:07 -04:00
|
|
|
|
2007-06-18 07:46:44 -04:00
|
|
|
center_tile_rect_in_area (&rect, &work_area);
|
2003-04-06 00:57:36 -05:00
|
|
|
|
2007-06-18 07:46:44 -04:00
|
|
|
if (meta_rectangle_contains_rect (&work_area, &rect) &&
|
|
|
|
!rectangle_overlaps_some_window (&rect, windows))
|
|
|
|
{
|
|
|
|
*new_x = rect.x;
|
|
|
|
*new_y = rect.y;
|
|
|
|
if (fgeom)
|
|
|
|
{
|
|
|
|
*new_x += fgeom->left_width;
|
|
|
|
*new_y += fgeom->top_height;
|
|
|
|
}
|
|
|
|
|
|
|
|
retval = TRUE;
|
|
|
|
|
|
|
|
goto out;
|
|
|
|
}
|
2003-02-23 12:09:46 -05:00
|
|
|
|
2007-06-18 07:46:44 -04:00
|
|
|
/* try below each window */
|
|
|
|
tmp = below_sorted;
|
|
|
|
while (tmp != NULL)
|
|
|
|
{
|
|
|
|
MetaWindow *w = tmp->data;
|
|
|
|
MetaRectangle outer_rect;
|
2003-04-06 00:57:36 -05:00
|
|
|
|
2007-06-18 07:46:44 -04:00
|
|
|
meta_window_get_outer_rect (w, &outer_rect);
|
2003-04-06 00:57:36 -05:00
|
|
|
|
2007-06-18 07:46:44 -04:00
|
|
|
rect.x = outer_rect.x;
|
|
|
|
rect.y = outer_rect.y + outer_rect.height;
|
2003-04-06 00:57:36 -05:00
|
|
|
|
2007-06-18 07:46:44 -04:00
|
|
|
if (meta_rectangle_contains_rect (&work_area, &rect) &&
|
|
|
|
!rectangle_overlaps_some_window (&rect, below_sorted))
|
|
|
|
{
|
|
|
|
*new_x = rect.x;
|
|
|
|
*new_y = rect.y;
|
|
|
|
if (fgeom)
|
|
|
|
{
|
|
|
|
*new_x += fgeom->left_width;
|
|
|
|
*new_y += fgeom->top_height;
|
|
|
|
}
|
2003-04-06 00:57:36 -05:00
|
|
|
|
2007-06-18 07:46:44 -04:00
|
|
|
retval = TRUE;
|
2003-04-06 00:57:36 -05:00
|
|
|
|
2007-06-18 07:46:44 -04:00
|
|
|
goto out;
|
|
|
|
}
|
2002-09-24 21:20:44 -04:00
|
|
|
|
2007-06-18 07:46:44 -04:00
|
|
|
tmp = tmp->next;
|
|
|
|
}
|
2003-02-23 12:09:46 -05:00
|
|
|
|
2007-06-18 07:46:44 -04:00
|
|
|
/* try to the right of each window */
|
|
|
|
tmp = right_sorted;
|
|
|
|
while (tmp != NULL)
|
|
|
|
{
|
|
|
|
MetaWindow *w = tmp->data;
|
|
|
|
MetaRectangle outer_rect;
|
|
|
|
|
|
|
|
meta_window_get_outer_rect (w, &outer_rect);
|
2003-04-06 00:57:36 -05:00
|
|
|
|
2007-06-18 07:46:44 -04:00
|
|
|
rect.x = outer_rect.x + outer_rect.width;
|
|
|
|
rect.y = outer_rect.y;
|
|
|
|
|
|
|
|
if (meta_rectangle_contains_rect (&work_area, &rect) &&
|
|
|
|
!rectangle_overlaps_some_window (&rect, right_sorted))
|
|
|
|
{
|
|
|
|
*new_x = rect.x;
|
|
|
|
*new_y = rect.y;
|
|
|
|
if (fgeom)
|
|
|
|
{
|
|
|
|
*new_x += fgeom->left_width;
|
|
|
|
*new_y += fgeom->top_height;
|
|
|
|
}
|
|
|
|
|
|
|
|
retval = TRUE;
|
|
|
|
|
|
|
|
goto out;
|
|
|
|
}
|
2003-04-06 00:57:36 -05:00
|
|
|
|
2007-06-18 07:46:44 -04:00
|
|
|
tmp = tmp->next;
|
|
|
|
}
|
2003-02-23 12:09:46 -05:00
|
|
|
|
2002-06-17 23:06:07 -04:00
|
|
|
out:
|
2003-04-06 00:57:36 -05:00
|
|
|
|
|
|
|
g_list_free (below_sorted);
|
|
|
|
g_list_free (right_sorted);
|
2002-06-17 23:06:07 -04:00
|
|
|
return retval;
|
2001-06-24 04:09:10 -04:00
|
|
|
}
|
2001-06-24 02:47:54 -04:00
|
|
|
|
|
|
|
void
|
on unminimize, queue calc_showing on all transients
2002-05-05 Havoc Pennington <hp@pobox.com>
* src/window.c (meta_window_unminimize): on unminimize, queue
calc_showing on all transients
(meta_window_activate): on activate, unminimize all a window's
ancestors, not just the window itself.
* src/workspace.c (set_work_area_hint): don't increment "tmp" by
16 unsigned long, increment by 4
* src/window.c (meta_window_free): if a window isn't minimized,
restore its WM_STATE to NormalState instead of IconicState,
since IconicState on initial window map means that the window
should be minimized.
* src/workspace.c (meta_workspace_invalidate_work_area): queue an
idle to recompute the work area hint.
(set_work_area_hint): we need 4*num_workspaces ints, not just
num_workspaces.
* src/screen.c (meta_screen_new): add work_area_idle field,
handle it on screen shutdown
* src/common.h (META_PRIORITY_PREFS_NOTIFY,
META_PRIORITY_WORK_AREA_HINT): define some idle priorities
* src/window.c (meta_window_calc_showing): hide windows if
their parent window is minimized
(meta_window_minimize): also queue_calc_showing on all
transients of the window being minimized
* src/place.c (constrain_placement): function to apply
placement-time-only constraints, such as "not off the left of the
screen"
(meta_window_place): put dialogs down a bit over their parent,
not right at the top.
(meta_window_place): when centering a dialog, center it
on the current xinerama screen, rather than the entire
screen.
* src/screen.c (meta_screen_get_current_xinerama): new function,
but not implemented
2002-05-05 01:41:13 -04:00
|
|
|
meta_window_place (MetaWindow *window,
|
2001-06-24 02:47:54 -04:00
|
|
|
MetaFrameGeometry *fgeom,
|
on unminimize, queue calc_showing on all transients
2002-05-05 Havoc Pennington <hp@pobox.com>
* src/window.c (meta_window_unminimize): on unminimize, queue
calc_showing on all transients
(meta_window_activate): on activate, unminimize all a window's
ancestors, not just the window itself.
* src/workspace.c (set_work_area_hint): don't increment "tmp" by
16 unsigned long, increment by 4
* src/window.c (meta_window_free): if a window isn't minimized,
restore its WM_STATE to NormalState instead of IconicState,
since IconicState on initial window map means that the window
should be minimized.
* src/workspace.c (meta_workspace_invalidate_work_area): queue an
idle to recompute the work area hint.
(set_work_area_hint): we need 4*num_workspaces ints, not just
num_workspaces.
* src/screen.c (meta_screen_new): add work_area_idle field,
handle it on screen shutdown
* src/common.h (META_PRIORITY_PREFS_NOTIFY,
META_PRIORITY_WORK_AREA_HINT): define some idle priorities
* src/window.c (meta_window_calc_showing): hide windows if
their parent window is minimized
(meta_window_minimize): also queue_calc_showing on all
transients of the window being minimized
* src/place.c (constrain_placement): function to apply
placement-time-only constraints, such as "not off the left of the
screen"
(meta_window_place): put dialogs down a bit over their parent,
not right at the top.
(meta_window_place): when centering a dialog, center it
on the current xinerama screen, rather than the entire
screen.
* src/screen.c (meta_screen_get_current_xinerama): new function,
but not implemented
2002-05-05 01:41:13 -04:00
|
|
|
int x,
|
|
|
|
int y,
|
|
|
|
int *new_x,
|
|
|
|
int *new_y)
|
2001-06-24 02:47:54 -04:00
|
|
|
{
|
2001-06-24 04:09:10 -04:00
|
|
|
GList *windows;
|
2002-06-06 23:18:46 -04:00
|
|
|
const MetaXineramaScreenInfo *xi;
|
2007-06-18 07:46:44 -04:00
|
|
|
|
2001-06-24 02:47:54 -04:00
|
|
|
/* frame member variables should NEVER be used in here, only
|
2001-06-24 04:09:10 -04:00
|
|
|
* MetaFrameGeometry. But remember fgeom == NULL
|
2001-10-29 21:00:53 -05:00
|
|
|
* for undecorated windows. Also, this function should
|
|
|
|
* NEVER have side effects other than computing the
|
|
|
|
* placement coordinates.
|
2001-06-24 02:47:54 -04:00
|
|
|
*/
|
|
|
|
|
2002-05-12 20:03:17 -04:00
|
|
|
meta_topic (META_DEBUG_PLACEMENT, "Placing window %s\n", window->desc);
|
|
|
|
|
2002-06-17 23:06:07 -04:00
|
|
|
windows = NULL;
|
|
|
|
|
2002-06-09 14:17:02 -04:00
|
|
|
switch (window->type)
|
|
|
|
{
|
|
|
|
/* Run placement algorithm on these. */
|
|
|
|
case META_WINDOW_NORMAL:
|
|
|
|
case META_WINDOW_DIALOG:
|
|
|
|
case META_WINDOW_MODAL_DIALOG:
|
|
|
|
case META_WINDOW_SPLASHSCREEN:
|
|
|
|
break;
|
|
|
|
|
|
|
|
/* Assume the app knows best how to place these, no placement
|
|
|
|
* algorithm ever (other than "leave them as-is")
|
|
|
|
*/
|
|
|
|
case META_WINDOW_DESKTOP:
|
|
|
|
case META_WINDOW_DOCK:
|
|
|
|
case META_WINDOW_TOOLBAR:
|
|
|
|
case META_WINDOW_MENU:
|
|
|
|
case META_WINDOW_UTILITY:
|
|
|
|
goto done_no_constraints;
|
|
|
|
}
|
|
|
|
|
2002-05-12 20:03:17 -04:00
|
|
|
if (meta_prefs_get_disable_workarounds ())
|
|
|
|
{
|
|
|
|
switch (window->type)
|
|
|
|
{
|
|
|
|
/* Only accept USPosition on normal windows because the app is full
|
|
|
|
* of shit claiming the user set -geometry for a dialog or dock
|
|
|
|
*/
|
|
|
|
case META_WINDOW_NORMAL:
|
|
|
|
if (window->size_hints.flags & USPosition)
|
|
|
|
{
|
|
|
|
/* don't constrain with placement algorithm */
|
|
|
|
meta_topic (META_DEBUG_PLACEMENT,
|
|
|
|
"Honoring USPosition for %s instead of using placement algorithm\n", window->desc);
|
|
|
|
|
|
|
|
goto done;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
|
|
|
|
/* Ignore even USPosition on dialogs, splashscreen */
|
|
|
|
case META_WINDOW_DIALOG:
|
|
|
|
case META_WINDOW_MODAL_DIALOG:
|
|
|
|
case META_WINDOW_SPLASHSCREEN:
|
|
|
|
break;
|
|
|
|
|
|
|
|
/* Assume the app knows best how to place these. */
|
|
|
|
case META_WINDOW_DESKTOP:
|
|
|
|
case META_WINDOW_DOCK:
|
|
|
|
case META_WINDOW_TOOLBAR:
|
|
|
|
case META_WINDOW_MENU:
|
|
|
|
case META_WINDOW_UTILITY:
|
|
|
|
if (window->size_hints.flags & PPosition)
|
|
|
|
{
|
|
|
|
meta_topic (META_DEBUG_PLACEMENT,
|
|
|
|
"Not placing non-normal non-dialog window with PPosition set\n");
|
2002-06-09 14:17:02 -04:00
|
|
|
goto done_no_constraints;
|
2002-05-12 20:03:17 -04:00
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
/* workarounds enabled */
|
|
|
|
|
|
|
|
if ((window->size_hints.flags & PPosition) ||
|
|
|
|
(window->size_hints.flags & USPosition))
|
|
|
|
{
|
|
|
|
meta_topic (META_DEBUG_PLACEMENT,
|
|
|
|
"Not placing window with PPosition or USPosition set\n");
|
2005-07-24 22:12:58 -04:00
|
|
|
avoid_being_obscured_as_second_modal_dialog (window, fgeom, &x, &y);
|
2002-06-09 14:17:02 -04:00
|
|
|
goto done_no_constraints;
|
2002-05-12 20:03:17 -04:00
|
|
|
}
|
|
|
|
}
|
2001-08-30 00:01:38 -04:00
|
|
|
|
2002-04-30 23:23:46 -04:00
|
|
|
if ((window->type == META_WINDOW_DIALOG ||
|
|
|
|
window->type == META_WINDOW_MODAL_DIALOG) &&
|
|
|
|
window->xtransient_for != None)
|
2001-06-24 02:47:54 -04:00
|
|
|
{
|
|
|
|
/* Center horizontally, at top of parent vertically */
|
|
|
|
|
|
|
|
MetaWindow *parent;
|
|
|
|
|
|
|
|
parent =
|
|
|
|
meta_display_lookup_x_window (window->display,
|
|
|
|
window->xtransient_for);
|
|
|
|
|
|
|
|
if (parent)
|
|
|
|
{
|
|
|
|
int w;
|
|
|
|
|
|
|
|
meta_window_get_position (parent, &x, &y);
|
|
|
|
w = parent->rect.width;
|
|
|
|
|
|
|
|
/* center of parent */
|
|
|
|
x = x + w / 2;
|
|
|
|
/* center of child over center of parent */
|
|
|
|
x -= window->rect.width / 2;
|
|
|
|
|
2003-11-07 23:43:18 -05:00
|
|
|
/* "visually" center window over parent, leaving twice as
|
|
|
|
* much space below as on top.
|
on unminimize, queue calc_showing on all transients
2002-05-05 Havoc Pennington <hp@pobox.com>
* src/window.c (meta_window_unminimize): on unminimize, queue
calc_showing on all transients
(meta_window_activate): on activate, unminimize all a window's
ancestors, not just the window itself.
* src/workspace.c (set_work_area_hint): don't increment "tmp" by
16 unsigned long, increment by 4
* src/window.c (meta_window_free): if a window isn't minimized,
restore its WM_STATE to NormalState instead of IconicState,
since IconicState on initial window map means that the window
should be minimized.
* src/workspace.c (meta_workspace_invalidate_work_area): queue an
idle to recompute the work area hint.
(set_work_area_hint): we need 4*num_workspaces ints, not just
num_workspaces.
* src/screen.c (meta_screen_new): add work_area_idle field,
handle it on screen shutdown
* src/common.h (META_PRIORITY_PREFS_NOTIFY,
META_PRIORITY_WORK_AREA_HINT): define some idle priorities
* src/window.c (meta_window_calc_showing): hide windows if
their parent window is minimized
(meta_window_minimize): also queue_calc_showing on all
transients of the window being minimized
* src/place.c (constrain_placement): function to apply
placement-time-only constraints, such as "not off the left of the
screen"
(meta_window_place): put dialogs down a bit over their parent,
not right at the top.
(meta_window_place): when centering a dialog, center it
on the current xinerama screen, rather than the entire
screen.
* src/screen.c (meta_screen_get_current_xinerama): new function,
but not implemented
2002-05-05 01:41:13 -04:00
|
|
|
*/
|
2003-11-07 23:43:18 -05:00
|
|
|
y += (parent->rect.height - window->rect.height)/3;
|
on unminimize, queue calc_showing on all transients
2002-05-05 Havoc Pennington <hp@pobox.com>
* src/window.c (meta_window_unminimize): on unminimize, queue
calc_showing on all transients
(meta_window_activate): on activate, unminimize all a window's
ancestors, not just the window itself.
* src/workspace.c (set_work_area_hint): don't increment "tmp" by
16 unsigned long, increment by 4
* src/window.c (meta_window_free): if a window isn't minimized,
restore its WM_STATE to NormalState instead of IconicState,
since IconicState on initial window map means that the window
should be minimized.
* src/workspace.c (meta_workspace_invalidate_work_area): queue an
idle to recompute the work area hint.
(set_work_area_hint): we need 4*num_workspaces ints, not just
num_workspaces.
* src/screen.c (meta_screen_new): add work_area_idle field,
handle it on screen shutdown
* src/common.h (META_PRIORITY_PREFS_NOTIFY,
META_PRIORITY_WORK_AREA_HINT): define some idle priorities
* src/window.c (meta_window_calc_showing): hide windows if
their parent window is minimized
(meta_window_minimize): also queue_calc_showing on all
transients of the window being minimized
* src/place.c (constrain_placement): function to apply
placement-time-only constraints, such as "not off the left of the
screen"
(meta_window_place): put dialogs down a bit over their parent,
not right at the top.
(meta_window_place): when centering a dialog, center it
on the current xinerama screen, rather than the entire
screen.
* src/screen.c (meta_screen_get_current_xinerama): new function,
but not implemented
2002-05-05 01:41:13 -04:00
|
|
|
|
|
|
|
/* put top of child's frame, not top of child's client */
|
2001-06-24 04:09:10 -04:00
|
|
|
if (fgeom)
|
|
|
|
y += fgeom->top_height;
|
2001-06-24 02:47:54 -04:00
|
|
|
|
2002-02-07 22:34:26 -05:00
|
|
|
meta_topic (META_DEBUG_PLACEMENT, "Centered window %s over transient parent\n",
|
|
|
|
window->desc);
|
2001-09-08 23:44:42 -04:00
|
|
|
|
2005-07-24 22:12:58 -04:00
|
|
|
avoid_being_obscured_as_second_modal_dialog (window, fgeom, &x, &y);
|
|
|
|
|
2001-06-24 02:47:54 -04:00
|
|
|
goto done;
|
|
|
|
}
|
|
|
|
}
|
2005-09-02 11:54:34 -04:00
|
|
|
|
2002-04-30 23:23:46 -04:00
|
|
|
/* FIXME UTILITY with transient set should be stacked up
|
|
|
|
* on the sides of the parent window or something.
|
|
|
|
*/
|
|
|
|
|
2001-06-24 02:47:54 -04:00
|
|
|
if (window->type == META_WINDOW_DIALOG ||
|
2002-02-09 01:54:44 -05:00
|
|
|
window->type == META_WINDOW_MODAL_DIALOG ||
|
|
|
|
window->type == META_WINDOW_SPLASHSCREEN)
|
2001-06-24 02:47:54 -04:00
|
|
|
{
|
Merge of all the changes on the constraints_experiments branch. This is
2005-11-18 Elijah Newren <newren@gmail.com>
Merge of all the changes on the constraints_experiments branch.
This is just a summary, to get the full ChangeLog of those
changes (approx. 2000 lines):
cvs -q -z3 update -Pd -r constraints_experiments
cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog
Bugs fixed:
unfiled - constraints.c is overly complicated[1]
unfiled - constraints.c is not robust when all constraints
cannot simultaneously be met (constraints need to be
prioritized)
unfiled - keep-titlebar-onscreen constraint is decoration
unaware (since get_outermost_onscreen_positions()
forgets to include decorations)
unfiled - keyboard snap-moving and snap-resizing snap to hidden
edges
109553 - gravity w/ simultaneous move & resize doesn't work
113601 - maximize vertical and horizontal should toggle and be
constrained
122196 - windows show up under vertical panels
122670 - jerky/random resizing of window via keyboard[2]
124582 - keyboard and mouse snap-resizing and snap-moving
erroneously moves the window multidimensionally
136307 - don't allow apps to resize themselves off the screen
(*cough* filechooser *cough*)
142016, 143784 - windows should not span multiple xineramas
unless placed there by the user
143145 - clamp new windows to screensize and force them
onscreen, if they'll fit
144126 - Handle pathological strut lists sanely[3]
149867 - fixed aspect ratio windows are difficult to resize[4]
152898 - make screen edges consistent; allow easy slamming of
windows into the left, right, and bottom edges of the
screen too.
154706 - bouncing weirdness at screen edge with keyboard moving
or resizing
156699 - avoid struts when placing windows, if possible (nasty
a11y blocker)
302456 - dragging offscreen too restrictive
304857 - wireframe moving off the top of the screen is misleading
308521 - make uni-directional resizing easier with
alt-middle-drag and prevent the occasional super
annoying resize-the-wrong-side(s) behavior
312007 - snap-resize moves windows with a minimum size
constraint
312104 - resizing the top of a window can cause the bottom to
grow
319351 - don't instantly snap on mouse-move-snapping, remove
braindeadedness of having order of releasing shift and
releasing button press matter so much
[1] fixed in my opinion, anyway.
[2] Actually, it's not totally fixed--it's just annoying
instead of almost completely unusable. Matthias had a
suggestion that may fix the remainder of the problems (see
http://tinyurl.com/bwzuu).
[3] This bug was originally about not-quite-so-pathological
cases but was left open for the worse cases. The code from
the branch handles the remainder of the cases mentioned in
this bug.
[4] Actually, although it's far better there's still some minor
issues left: a slight drift that's only noticeable after
lots of resizing, and potential problems with partially
onscreen constraints due to not clearing any
fixed_directions flags (aspect ratio windows get resized in
both directions and thus aren't fixed in one of them)
New feature:
81704 - edge resistance for user move and resize operations;
in particular 3 different kinds of resistance are
implemented:
Pixel-Distance: window movement is resisted when it
aligns with an edge unless the movement is greater than
a threshold number of pixels
Timeout: window movement past an edge is prevented until
a certain amount of time has elapsed during the
operation since the first request to move it past that
edge
Keyboard-Buildup: when moving or resizing with the
keyboard, once a window is aligned with a certain edge
it cannot move past until the correct direction has
been pressed enough times (e.g. 2 or 3 times)
Major changes:
- constraints.c has been rewritten; very few lines of code from
the old version remain. There is a comment near the top of
the function explaining the basics of how the new framework
works. A more detailed explanation can be found in
doc/how-constraints-works.txt
- edge-resistance.[ch] are new files implementing edge-resistance.
- boxes.[ch] are new files containing low-level error-prone
functions used heavily in constraints.c and edge-resistance.c,
among various places throughout the code. testboxes.c
contains a thorough testsuite for the boxes.[ch] functions
compiled into a program, testboxes.
- meta_window_move_resize_internal() *must* be told the gravity
of the associated operation (if it's just a move operation,
the gravity will be ignored, but for resize and move+resize
the correct value is needed)
- the craziness of different values that
meta_window_move_resize_internal() accepts has been documented
in a large comment at the beginning of the function. It may
be possible to clean this up some, but until then things will
remain as they were before--caller beware.
- screen and xinerama usable areas (i.e. places not covered by
e.g. panels) are cached in the workspace now, as are the
screen and xinerama edges. These get updated with the
workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 09:58:50 -05:00
|
|
|
/* Center on current xinerama (i.e. on current monitor) */
|
2001-06-24 02:47:54 -04:00
|
|
|
int w, h;
|
|
|
|
|
2002-06-06 23:18:46 -04:00
|
|
|
/* Warning, this function is a round trip! */
|
|
|
|
xi = meta_screen_get_current_xinerama (window->screen);
|
on unminimize, queue calc_showing on all transients
2002-05-05 Havoc Pennington <hp@pobox.com>
* src/window.c (meta_window_unminimize): on unminimize, queue
calc_showing on all transients
(meta_window_activate): on activate, unminimize all a window's
ancestors, not just the window itself.
* src/workspace.c (set_work_area_hint): don't increment "tmp" by
16 unsigned long, increment by 4
* src/window.c (meta_window_free): if a window isn't minimized,
restore its WM_STATE to NormalState instead of IconicState,
since IconicState on initial window map means that the window
should be minimized.
* src/workspace.c (meta_workspace_invalidate_work_area): queue an
idle to recompute the work area hint.
(set_work_area_hint): we need 4*num_workspaces ints, not just
num_workspaces.
* src/screen.c (meta_screen_new): add work_area_idle field,
handle it on screen shutdown
* src/common.h (META_PRIORITY_PREFS_NOTIFY,
META_PRIORITY_WORK_AREA_HINT): define some idle priorities
* src/window.c (meta_window_calc_showing): hide windows if
their parent window is minimized
(meta_window_minimize): also queue_calc_showing on all
transients of the window being minimized
* src/place.c (constrain_placement): function to apply
placement-time-only constraints, such as "not off the left of the
screen"
(meta_window_place): put dialogs down a bit over their parent,
not right at the top.
(meta_window_place): when centering a dialog, center it
on the current xinerama screen, rather than the entire
screen.
* src/screen.c (meta_screen_get_current_xinerama): new function,
but not implemented
2002-05-05 01:41:13 -04:00
|
|
|
|
Merge of all the changes on the constraints_experiments branch. This is
2005-11-18 Elijah Newren <newren@gmail.com>
Merge of all the changes on the constraints_experiments branch.
This is just a summary, to get the full ChangeLog of those
changes (approx. 2000 lines):
cvs -q -z3 update -Pd -r constraints_experiments
cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog
Bugs fixed:
unfiled - constraints.c is overly complicated[1]
unfiled - constraints.c is not robust when all constraints
cannot simultaneously be met (constraints need to be
prioritized)
unfiled - keep-titlebar-onscreen constraint is decoration
unaware (since get_outermost_onscreen_positions()
forgets to include decorations)
unfiled - keyboard snap-moving and snap-resizing snap to hidden
edges
109553 - gravity w/ simultaneous move & resize doesn't work
113601 - maximize vertical and horizontal should toggle and be
constrained
122196 - windows show up under vertical panels
122670 - jerky/random resizing of window via keyboard[2]
124582 - keyboard and mouse snap-resizing and snap-moving
erroneously moves the window multidimensionally
136307 - don't allow apps to resize themselves off the screen
(*cough* filechooser *cough*)
142016, 143784 - windows should not span multiple xineramas
unless placed there by the user
143145 - clamp new windows to screensize and force them
onscreen, if they'll fit
144126 - Handle pathological strut lists sanely[3]
149867 - fixed aspect ratio windows are difficult to resize[4]
152898 - make screen edges consistent; allow easy slamming of
windows into the left, right, and bottom edges of the
screen too.
154706 - bouncing weirdness at screen edge with keyboard moving
or resizing
156699 - avoid struts when placing windows, if possible (nasty
a11y blocker)
302456 - dragging offscreen too restrictive
304857 - wireframe moving off the top of the screen is misleading
308521 - make uni-directional resizing easier with
alt-middle-drag and prevent the occasional super
annoying resize-the-wrong-side(s) behavior
312007 - snap-resize moves windows with a minimum size
constraint
312104 - resizing the top of a window can cause the bottom to
grow
319351 - don't instantly snap on mouse-move-snapping, remove
braindeadedness of having order of releasing shift and
releasing button press matter so much
[1] fixed in my opinion, anyway.
[2] Actually, it's not totally fixed--it's just annoying
instead of almost completely unusable. Matthias had a
suggestion that may fix the remainder of the problems (see
http://tinyurl.com/bwzuu).
[3] This bug was originally about not-quite-so-pathological
cases but was left open for the worse cases. The code from
the branch handles the remainder of the cases mentioned in
this bug.
[4] Actually, although it's far better there's still some minor
issues left: a slight drift that's only noticeable after
lots of resizing, and potential problems with partially
onscreen constraints due to not clearing any
fixed_directions flags (aspect ratio windows get resized in
both directions and thus aren't fixed in one of them)
New feature:
81704 - edge resistance for user move and resize operations;
in particular 3 different kinds of resistance are
implemented:
Pixel-Distance: window movement is resisted when it
aligns with an edge unless the movement is greater than
a threshold number of pixels
Timeout: window movement past an edge is prevented until
a certain amount of time has elapsed during the
operation since the first request to move it past that
edge
Keyboard-Buildup: when moving or resizing with the
keyboard, once a window is aligned with a certain edge
it cannot move past until the correct direction has
been pressed enough times (e.g. 2 or 3 times)
Major changes:
- constraints.c has been rewritten; very few lines of code from
the old version remain. There is a comment near the top of
the function explaining the basics of how the new framework
works. A more detailed explanation can be found in
doc/how-constraints-works.txt
- edge-resistance.[ch] are new files implementing edge-resistance.
- boxes.[ch] are new files containing low-level error-prone
functions used heavily in constraints.c and edge-resistance.c,
among various places throughout the code. testboxes.c
contains a thorough testsuite for the boxes.[ch] functions
compiled into a program, testboxes.
- meta_window_move_resize_internal() *must* be told the gravity
of the associated operation (if it's just a move operation,
the gravity will be ignored, but for resize and move+resize
the correct value is needed)
- the craziness of different values that
meta_window_move_resize_internal() accepts has been documented
in a large comment at the beginning of the function. It may
be possible to clean this up some, but until then things will
remain as they were before--caller beware.
- screen and xinerama usable areas (i.e. places not covered by
e.g. panels) are cached in the workspace now, as are the
screen and xinerama edges. These get updated with the
workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 09:58:50 -05:00
|
|
|
w = xi->rect.width;
|
|
|
|
h = xi->rect.height;
|
2001-06-24 02:47:54 -04:00
|
|
|
|
|
|
|
x = (w - window->rect.width) / 2;
|
2002-02-09 01:54:44 -05:00
|
|
|
y = (h - window->rect.height) / 2;
|
2001-06-24 02:47:54 -04:00
|
|
|
|
Merge of all the changes on the constraints_experiments branch. This is
2005-11-18 Elijah Newren <newren@gmail.com>
Merge of all the changes on the constraints_experiments branch.
This is just a summary, to get the full ChangeLog of those
changes (approx. 2000 lines):
cvs -q -z3 update -Pd -r constraints_experiments
cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog
Bugs fixed:
unfiled - constraints.c is overly complicated[1]
unfiled - constraints.c is not robust when all constraints
cannot simultaneously be met (constraints need to be
prioritized)
unfiled - keep-titlebar-onscreen constraint is decoration
unaware (since get_outermost_onscreen_positions()
forgets to include decorations)
unfiled - keyboard snap-moving and snap-resizing snap to hidden
edges
109553 - gravity w/ simultaneous move & resize doesn't work
113601 - maximize vertical and horizontal should toggle and be
constrained
122196 - windows show up under vertical panels
122670 - jerky/random resizing of window via keyboard[2]
124582 - keyboard and mouse snap-resizing and snap-moving
erroneously moves the window multidimensionally
136307 - don't allow apps to resize themselves off the screen
(*cough* filechooser *cough*)
142016, 143784 - windows should not span multiple xineramas
unless placed there by the user
143145 - clamp new windows to screensize and force them
onscreen, if they'll fit
144126 - Handle pathological strut lists sanely[3]
149867 - fixed aspect ratio windows are difficult to resize[4]
152898 - make screen edges consistent; allow easy slamming of
windows into the left, right, and bottom edges of the
screen too.
154706 - bouncing weirdness at screen edge with keyboard moving
or resizing
156699 - avoid struts when placing windows, if possible (nasty
a11y blocker)
302456 - dragging offscreen too restrictive
304857 - wireframe moving off the top of the screen is misleading
308521 - make uni-directional resizing easier with
alt-middle-drag and prevent the occasional super
annoying resize-the-wrong-side(s) behavior
312007 - snap-resize moves windows with a minimum size
constraint
312104 - resizing the top of a window can cause the bottom to
grow
319351 - don't instantly snap on mouse-move-snapping, remove
braindeadedness of having order of releasing shift and
releasing button press matter so much
[1] fixed in my opinion, anyway.
[2] Actually, it's not totally fixed--it's just annoying
instead of almost completely unusable. Matthias had a
suggestion that may fix the remainder of the problems (see
http://tinyurl.com/bwzuu).
[3] This bug was originally about not-quite-so-pathological
cases but was left open for the worse cases. The code from
the branch handles the remainder of the cases mentioned in
this bug.
[4] Actually, although it's far better there's still some minor
issues left: a slight drift that's only noticeable after
lots of resizing, and potential problems with partially
onscreen constraints due to not clearing any
fixed_directions flags (aspect ratio windows get resized in
both directions and thus aren't fixed in one of them)
New feature:
81704 - edge resistance for user move and resize operations;
in particular 3 different kinds of resistance are
implemented:
Pixel-Distance: window movement is resisted when it
aligns with an edge unless the movement is greater than
a threshold number of pixels
Timeout: window movement past an edge is prevented until
a certain amount of time has elapsed during the
operation since the first request to move it past that
edge
Keyboard-Buildup: when moving or resizing with the
keyboard, once a window is aligned with a certain edge
it cannot move past until the correct direction has
been pressed enough times (e.g. 2 or 3 times)
Major changes:
- constraints.c has been rewritten; very few lines of code from
the old version remain. There is a comment near the top of
the function explaining the basics of how the new framework
works. A more detailed explanation can be found in
doc/how-constraints-works.txt
- edge-resistance.[ch] are new files implementing edge-resistance.
- boxes.[ch] are new files containing low-level error-prone
functions used heavily in constraints.c and edge-resistance.c,
among various places throughout the code. testboxes.c
contains a thorough testsuite for the boxes.[ch] functions
compiled into a program, testboxes.
- meta_window_move_resize_internal() *must* be told the gravity
of the associated operation (if it's just a move operation,
the gravity will be ignored, but for resize and move+resize
the correct value is needed)
- the craziness of different values that
meta_window_move_resize_internal() accepts has been documented
in a large comment at the beginning of the function. It may
be possible to clean this up some, but until then things will
remain as they were before--caller beware.
- screen and xinerama usable areas (i.e. places not covered by
e.g. panels) are cached in the workspace now, as are the
screen and xinerama edges. These get updated with the
workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 09:58:50 -05:00
|
|
|
x += xi->rect.x;
|
|
|
|
y += xi->rect.y;
|
on unminimize, queue calc_showing on all transients
2002-05-05 Havoc Pennington <hp@pobox.com>
* src/window.c (meta_window_unminimize): on unminimize, queue
calc_showing on all transients
(meta_window_activate): on activate, unminimize all a window's
ancestors, not just the window itself.
* src/workspace.c (set_work_area_hint): don't increment "tmp" by
16 unsigned long, increment by 4
* src/window.c (meta_window_free): if a window isn't minimized,
restore its WM_STATE to NormalState instead of IconicState,
since IconicState on initial window map means that the window
should be minimized.
* src/workspace.c (meta_workspace_invalidate_work_area): queue an
idle to recompute the work area hint.
(set_work_area_hint): we need 4*num_workspaces ints, not just
num_workspaces.
* src/screen.c (meta_screen_new): add work_area_idle field,
handle it on screen shutdown
* src/common.h (META_PRIORITY_PREFS_NOTIFY,
META_PRIORITY_WORK_AREA_HINT): define some idle priorities
* src/window.c (meta_window_calc_showing): hide windows if
their parent window is minimized
(meta_window_minimize): also queue_calc_showing on all
transients of the window being minimized
* src/place.c (constrain_placement): function to apply
placement-time-only constraints, such as "not off the left of the
screen"
(meta_window_place): put dialogs down a bit over their parent,
not right at the top.
(meta_window_place): when centering a dialog, center it
on the current xinerama screen, rather than the entire
screen.
* src/screen.c (meta_screen_get_current_xinerama): new function,
but not implemented
2002-05-05 01:41:13 -04:00
|
|
|
|
|
|
|
meta_topic (META_DEBUG_PLACEMENT, "Centered window %s on screen %d xinerama %d\n",
|
|
|
|
window->desc, window->screen->number, xi->number);
|
2001-06-24 02:47:54 -04:00
|
|
|
|
2005-08-12 23:58:24 -04:00
|
|
|
goto done_check_denied_focus;
|
2001-06-24 02:47:54 -04:00
|
|
|
}
|
2002-02-09 01:54:44 -05:00
|
|
|
|
2001-06-24 04:09:10 -04:00
|
|
|
/* Find windows that matter (not minimized, on same workspace
|
|
|
|
* as placed window, may be shaded - if shaded we pretend it isn't
|
|
|
|
* for placement purposes)
|
|
|
|
*/
|
|
|
|
{
|
|
|
|
GSList *all_windows;
|
|
|
|
GSList *tmp;
|
|
|
|
|
|
|
|
all_windows = meta_display_list_windows (window->display);
|
|
|
|
|
|
|
|
tmp = all_windows;
|
|
|
|
while (tmp != NULL)
|
|
|
|
{
|
|
|
|
MetaWindow *w = tmp->data;
|
|
|
|
|
2005-01-28 09:48:47 -05:00
|
|
|
if (meta_window_showing_on_its_workspace (w) &&
|
2001-06-24 04:09:10 -04:00
|
|
|
w != window &&
|
2005-01-28 09:48:47 -05:00
|
|
|
(window->workspace == w->workspace ||
|
|
|
|
window->on_all_workspaces || w->on_all_workspaces))
|
2001-06-24 04:09:10 -04:00
|
|
|
windows = g_list_prepend (windows, w);
|
|
|
|
|
|
|
|
tmp = tmp->next;
|
|
|
|
}
|
2005-01-27 13:30:27 -05:00
|
|
|
|
|
|
|
g_slist_free (all_windows);
|
2001-06-24 04:09:10 -04:00
|
|
|
}
|
2002-06-06 23:18:46 -04:00
|
|
|
|
|
|
|
/* Warning, this is a round trip! */
|
|
|
|
xi = meta_screen_get_current_xinerama (window->screen);
|
2001-06-24 04:09:10 -04:00
|
|
|
|
2001-06-24 02:47:54 -04:00
|
|
|
/* "Origin" placement algorithm */
|
Merge of all the changes on the constraints_experiments branch. This is
2005-11-18 Elijah Newren <newren@gmail.com>
Merge of all the changes on the constraints_experiments branch.
This is just a summary, to get the full ChangeLog of those
changes (approx. 2000 lines):
cvs -q -z3 update -Pd -r constraints_experiments
cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog
Bugs fixed:
unfiled - constraints.c is overly complicated[1]
unfiled - constraints.c is not robust when all constraints
cannot simultaneously be met (constraints need to be
prioritized)
unfiled - keep-titlebar-onscreen constraint is decoration
unaware (since get_outermost_onscreen_positions()
forgets to include decorations)
unfiled - keyboard snap-moving and snap-resizing snap to hidden
edges
109553 - gravity w/ simultaneous move & resize doesn't work
113601 - maximize vertical and horizontal should toggle and be
constrained
122196 - windows show up under vertical panels
122670 - jerky/random resizing of window via keyboard[2]
124582 - keyboard and mouse snap-resizing and snap-moving
erroneously moves the window multidimensionally
136307 - don't allow apps to resize themselves off the screen
(*cough* filechooser *cough*)
142016, 143784 - windows should not span multiple xineramas
unless placed there by the user
143145 - clamp new windows to screensize and force them
onscreen, if they'll fit
144126 - Handle pathological strut lists sanely[3]
149867 - fixed aspect ratio windows are difficult to resize[4]
152898 - make screen edges consistent; allow easy slamming of
windows into the left, right, and bottom edges of the
screen too.
154706 - bouncing weirdness at screen edge with keyboard moving
or resizing
156699 - avoid struts when placing windows, if possible (nasty
a11y blocker)
302456 - dragging offscreen too restrictive
304857 - wireframe moving off the top of the screen is misleading
308521 - make uni-directional resizing easier with
alt-middle-drag and prevent the occasional super
annoying resize-the-wrong-side(s) behavior
312007 - snap-resize moves windows with a minimum size
constraint
312104 - resizing the top of a window can cause the bottom to
grow
319351 - don't instantly snap on mouse-move-snapping, remove
braindeadedness of having order of releasing shift and
releasing button press matter so much
[1] fixed in my opinion, anyway.
[2] Actually, it's not totally fixed--it's just annoying
instead of almost completely unusable. Matthias had a
suggestion that may fix the remainder of the problems (see
http://tinyurl.com/bwzuu).
[3] This bug was originally about not-quite-so-pathological
cases but was left open for the worse cases. The code from
the branch handles the remainder of the cases mentioned in
this bug.
[4] Actually, although it's far better there's still some minor
issues left: a slight drift that's only noticeable after
lots of resizing, and potential problems with partially
onscreen constraints due to not clearing any
fixed_directions flags (aspect ratio windows get resized in
both directions and thus aren't fixed in one of them)
New feature:
81704 - edge resistance for user move and resize operations;
in particular 3 different kinds of resistance are
implemented:
Pixel-Distance: window movement is resisted when it
aligns with an edge unless the movement is greater than
a threshold number of pixels
Timeout: window movement past an edge is prevented until
a certain amount of time has elapsed during the
operation since the first request to move it past that
edge
Keyboard-Buildup: when moving or resizing with the
keyboard, once a window is aligned with a certain edge
it cannot move past until the correct direction has
been pressed enough times (e.g. 2 or 3 times)
Major changes:
- constraints.c has been rewritten; very few lines of code from
the old version remain. There is a comment near the top of
the function explaining the basics of how the new framework
works. A more detailed explanation can be found in
doc/how-constraints-works.txt
- edge-resistance.[ch] are new files implementing edge-resistance.
- boxes.[ch] are new files containing low-level error-prone
functions used heavily in constraints.c and edge-resistance.c,
among various places throughout the code. testboxes.c
contains a thorough testsuite for the boxes.[ch] functions
compiled into a program, testboxes.
- meta_window_move_resize_internal() *must* be told the gravity
of the associated operation (if it's just a move operation,
the gravity will be ignored, but for resize and move+resize
the correct value is needed)
- the craziness of different values that
meta_window_move_resize_internal() accepts has been documented
in a large comment at the beginning of the function. It may
be possible to clean this up some, but until then things will
remain as they were before--caller beware.
- screen and xinerama usable areas (i.e. places not covered by
e.g. panels) are cached in the workspace now, as are the
screen and xinerama edges. These get updated with the
workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 09:58:50 -05:00
|
|
|
x = xi->rect.x;
|
|
|
|
y = xi->rect.y;
|
2001-06-24 02:47:54 -04:00
|
|
|
|
2003-06-09 19:49:02 -04:00
|
|
|
if (find_first_fit (window, fgeom, windows,
|
2007-06-18 07:46:44 -04:00
|
|
|
xi->number,
|
2003-06-09 19:49:02 -04:00
|
|
|
x, y, &x, &y))
|
2005-02-11 14:20:44 -05:00
|
|
|
goto done_check_denied_focus;
|
2003-06-09 19:49:02 -04:00
|
|
|
|
|
|
|
/* Maximize windows if they are too big for their work area (bit of
|
|
|
|
* a hack here). Assume undecorated windows probably don't intend to
|
|
|
|
* be maximized.
|
|
|
|
*/
|
|
|
|
if (window->has_maximize_func && window->decorated &&
|
|
|
|
!window->fullscreen)
|
|
|
|
{
|
|
|
|
MetaRectangle workarea;
|
|
|
|
MetaRectangle outer;
|
|
|
|
|
|
|
|
meta_window_get_work_area_for_xinerama (window,
|
2007-06-18 07:46:44 -04:00
|
|
|
xi->number,
|
2003-06-09 19:49:02 -04:00
|
|
|
&workarea);
|
|
|
|
meta_window_get_outer_rect (window, &outer);
|
|
|
|
|
2007-04-12 18:25:25 -04:00
|
|
|
/* If the window is bigger than the screen, then automaximize. Do NOT
|
|
|
|
* auto-maximize the directions independently. See #419810.
|
|
|
|
*/
|
|
|
|
if (outer.width >= workarea.width && outer.height >= workarea.height)
|
|
|
|
{
|
|
|
|
window->maximize_horizontally_after_placement = TRUE;
|
|
|
|
window->maximize_vertically_after_placement = TRUE;
|
|
|
|
}
|
2003-06-09 19:49:02 -04:00
|
|
|
}
|
2005-02-11 14:20:44 -05:00
|
|
|
|
|
|
|
done_check_denied_focus:
|
|
|
|
/* If the window is being denied focus and isn't a transient of the
|
|
|
|
* focus window, we do NOT want it to overlap with the focus window
|
|
|
|
* if at all possible. This is guaranteed to only be called if the
|
|
|
|
* focus_window is non-NULL, and we try to avoid that window.
|
|
|
|
*/
|
|
|
|
if (window->denied_focus_and_not_transient)
|
|
|
|
{
|
|
|
|
gboolean found_fit;
|
|
|
|
MetaWindow *focus_window;
|
|
|
|
MetaRectangle overlap;
|
|
|
|
|
|
|
|
focus_window = window->display->focus_window;
|
|
|
|
g_assert (focus_window != NULL);
|
|
|
|
|
|
|
|
/* No need to do anything if the window doesn't overlap at all */
|
|
|
|
found_fit = !meta_rectangle_intersect (&window->rect,
|
|
|
|
&focus_window->rect,
|
|
|
|
&overlap);
|
|
|
|
|
|
|
|
/* Try to do a first fit again, this time only taking into account the
|
|
|
|
* focus window.
|
|
|
|
*/
|
|
|
|
if (!found_fit)
|
|
|
|
{
|
|
|
|
GList *focus_window_list;
|
|
|
|
focus_window_list = g_list_prepend (NULL, focus_window);
|
|
|
|
|
|
|
|
/* Reset x and y ("origin" placement algorithm) */
|
Merge of all the changes on the constraints_experiments branch. This is
2005-11-18 Elijah Newren <newren@gmail.com>
Merge of all the changes on the constraints_experiments branch.
This is just a summary, to get the full ChangeLog of those
changes (approx. 2000 lines):
cvs -q -z3 update -Pd -r constraints_experiments
cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog
Bugs fixed:
unfiled - constraints.c is overly complicated[1]
unfiled - constraints.c is not robust when all constraints
cannot simultaneously be met (constraints need to be
prioritized)
unfiled - keep-titlebar-onscreen constraint is decoration
unaware (since get_outermost_onscreen_positions()
forgets to include decorations)
unfiled - keyboard snap-moving and snap-resizing snap to hidden
edges
109553 - gravity w/ simultaneous move & resize doesn't work
113601 - maximize vertical and horizontal should toggle and be
constrained
122196 - windows show up under vertical panels
122670 - jerky/random resizing of window via keyboard[2]
124582 - keyboard and mouse snap-resizing and snap-moving
erroneously moves the window multidimensionally
136307 - don't allow apps to resize themselves off the screen
(*cough* filechooser *cough*)
142016, 143784 - windows should not span multiple xineramas
unless placed there by the user
143145 - clamp new windows to screensize and force them
onscreen, if they'll fit
144126 - Handle pathological strut lists sanely[3]
149867 - fixed aspect ratio windows are difficult to resize[4]
152898 - make screen edges consistent; allow easy slamming of
windows into the left, right, and bottom edges of the
screen too.
154706 - bouncing weirdness at screen edge with keyboard moving
or resizing
156699 - avoid struts when placing windows, if possible (nasty
a11y blocker)
302456 - dragging offscreen too restrictive
304857 - wireframe moving off the top of the screen is misleading
308521 - make uni-directional resizing easier with
alt-middle-drag and prevent the occasional super
annoying resize-the-wrong-side(s) behavior
312007 - snap-resize moves windows with a minimum size
constraint
312104 - resizing the top of a window can cause the bottom to
grow
319351 - don't instantly snap on mouse-move-snapping, remove
braindeadedness of having order of releasing shift and
releasing button press matter so much
[1] fixed in my opinion, anyway.
[2] Actually, it's not totally fixed--it's just annoying
instead of almost completely unusable. Matthias had a
suggestion that may fix the remainder of the problems (see
http://tinyurl.com/bwzuu).
[3] This bug was originally about not-quite-so-pathological
cases but was left open for the worse cases. The code from
the branch handles the remainder of the cases mentioned in
this bug.
[4] Actually, although it's far better there's still some minor
issues left: a slight drift that's only noticeable after
lots of resizing, and potential problems with partially
onscreen constraints due to not clearing any
fixed_directions flags (aspect ratio windows get resized in
both directions and thus aren't fixed in one of them)
New feature:
81704 - edge resistance for user move and resize operations;
in particular 3 different kinds of resistance are
implemented:
Pixel-Distance: window movement is resisted when it
aligns with an edge unless the movement is greater than
a threshold number of pixels
Timeout: window movement past an edge is prevented until
a certain amount of time has elapsed during the
operation since the first request to move it past that
edge
Keyboard-Buildup: when moving or resizing with the
keyboard, once a window is aligned with a certain edge
it cannot move past until the correct direction has
been pressed enough times (e.g. 2 or 3 times)
Major changes:
- constraints.c has been rewritten; very few lines of code from
the old version remain. There is a comment near the top of
the function explaining the basics of how the new framework
works. A more detailed explanation can be found in
doc/how-constraints-works.txt
- edge-resistance.[ch] are new files implementing edge-resistance.
- boxes.[ch] are new files containing low-level error-prone
functions used heavily in constraints.c and edge-resistance.c,
among various places throughout the code. testboxes.c
contains a thorough testsuite for the boxes.[ch] functions
compiled into a program, testboxes.
- meta_window_move_resize_internal() *must* be told the gravity
of the associated operation (if it's just a move operation,
the gravity will be ignored, but for resize and move+resize
the correct value is needed)
- the craziness of different values that
meta_window_move_resize_internal() accepts has been documented
in a large comment at the beginning of the function. It may
be possible to clean this up some, but until then things will
remain as they were before--caller beware.
- screen and xinerama usable areas (i.e. places not covered by
e.g. panels) are cached in the workspace now, as are the
screen and xinerama edges. These get updated with the
workarea in src/workspace.c:ensure_work_areas_validated()
2005-11-19 09:58:50 -05:00
|
|
|
x = xi->rect.x;
|
|
|
|
y = xi->rect.y;
|
2005-02-11 14:20:44 -05:00
|
|
|
|
|
|
|
found_fit = find_first_fit (window, fgeom, focus_window_list,
|
2007-06-18 07:46:44 -04:00
|
|
|
xi->number,
|
2005-02-11 14:20:44 -05:00
|
|
|
x, y, &x, &y);
|
|
|
|
g_list_free (focus_window_list);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* If that still didn't work, just place it where we can see as much
|
|
|
|
* as possible.
|
|
|
|
*/
|
|
|
|
if (!found_fit)
|
|
|
|
find_most_freespace (window, fgeom, focus_window, x, y, &x, &y);
|
|
|
|
}
|
2001-06-24 04:09:10 -04:00
|
|
|
|
2001-06-24 02:47:54 -04:00
|
|
|
done:
|
2002-06-17 23:06:07 -04:00
|
|
|
g_list_free (windows);
|
|
|
|
|
2002-06-09 14:17:02 -04:00
|
|
|
done_no_constraints:
|
2003-02-23 12:09:46 -05:00
|
|
|
|
2001-06-24 02:47:54 -04:00
|
|
|
*new_x = x;
|
|
|
|
*new_y = y;
|
|
|
|
}
|