Commit Graph

14497 Commits

Author SHA1 Message Date
Carlos Garnacho
e16def0c43 magnifier: Make magnification factor changes animatable
So we can seamlessly change between them through eg. keybindings.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/984
2020-02-07 18:18:25 +01:00
Carlos Garnacho
83d083f189 magnifier: Implement pointer motion tracking differently
The use of the core idle monitor means that focus change events
are also delayed by keyboard interaction. Since the magnifier is
already in the business of pointer tracking, it's easy enough to
fire the pointer rest timeout from here, so focus changes are
accumulated and delayed.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/984
2020-02-07 18:18:25 +01:00
Carlos Garnacho
b1ea4f6c35 magnifier: Animate focus/caret position changes
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/984
2020-02-07 18:18:25 +01:00
Carlos Garnacho
60c540e93a magnifier: Add support for animating "scroll" on focus changes
This is nice in that it provides a hint of the relative position of
the new focus area, as opposed to a sudden jump.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/984
2020-02-07 18:18:25 +01:00
Carlos Garnacho
f3b56e0eb1 magnifier: Transform a11y events' coordinates by scale factor
We get those events in logical coordinates, which we have to transform
into actual pixels.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/984
2020-02-07 18:18:25 +01:00
Carlos Garnacho
c8d02be14a magnifier: Ignore repeated a11y events
We may get several a11y events setting the caret on the same
coordinates it previously was. Make focus tracking ignore those,
as we're jumping to the same coordinates again during eg. mouse
operation.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/984
2020-02-07 18:18:25 +01:00
Carlos Garnacho
42b50051ac magnifier: Sanity check coordinates in scrollContentsTo
We may receive a11y events with bogus coordinates (eg. x/y = minint),
so ensure the coordinates are sane before scrolling there.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/984
2020-02-07 18:18:25 +01:00
Carlos Garnacho
bda18888c0 magnifier: Clip all crosshair lines at even distances
If the crosshair is clipped so it doesn't cover the pointer cursor,
the clip rectangle is skewed towards the bottom/right. This was
made so to accomodate the default pointer, but the unevenness stays
on other pointer cursors, and it makes the crosshair look odd on
short crosshair length.

Make all lines clip to an even distance from the center instead.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/984
2020-02-07 18:18:25 +01:00
Carlos Garnacho
c150fe95b9 magnifier: Apply color inversion to crosshairs/pointer
It is somewhat unexpected that crosshair color and pointer cursor colors
remain the same across changes in color inversion settings, and may lead
to contrast issues. Apply the effect on the common container, so it
applies to these all.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/984
2020-02-07 18:18:25 +01:00
Carlos Garnacho
8b4b9d396b magnifier: Apply scale factor to crosshair length
On hidpi displays the length is double as advertised, make it match
the advertised length.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/984
2020-02-07 18:18:25 +01:00
Anders Jonsson
9c0f069f86 Update Swedish translation 2020-02-07 15:02:26 +00:00
Daniel van Vugt
8929c89d1f workspace: Animate window clones using translation properties
Instead of position x/y properties. This reduces CPU-intensive relayouts
in JavaScript (`vfunc_allocate` etc).

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/issues/1271
since the other fix required already landed in 4c4846e9.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/936
2020-02-07 14:43:56 +00:00
Daniel van Vugt
881eab7669 dnd: Make DND translation-property-aware
Previously DND only worked properly for actors with zero translation.
But it only requires a small tweak to `this._dragOffsetX/Y` to support
non-zero translation values.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/936
2020-02-07 14:43:56 +00:00
Danial Behzadi
141652b7ec Update Persian translation 2020-02-07 13:04:10 +00:00
Daniel van Vugt
b5651e38c7 iconGrid: Avoid animating the same icon twice
If the icon proper has opacity of zero then that's probably because a
clone of it is animating. So avoid animating the source actor too.

And if there's any other reason for the opacity being zero, still don't
animate it because we can't see it :)

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/issues/2167
2020-02-07 11:31:20 +00:00
Daniel van Vugt
33ae220ad2 appDisplay: Call super.vfunc_unmap last
So as to guarantee the unmapped state sticks and doesn't get toggled
back to mapped before we return.

Being in a mapped state when `FolderIcon.vfunc_unmap()` returned was
causing an assertion failure in `clutter_actor_set_mapped` and crashed
the shell.

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/issues/2170
2020-02-07 11:23:25 +00:00
Daniel Mustieles
6ec996e45b Updated Spanish translation 2020-02-07 11:54:07 +01:00
Daniel Mustieles
4f3e847897 Merge branch 'master' of gitlab.gnome.org:GNOME/gnome-shell 2020-02-07 11:54:07 +01:00
Rafael Fontenelle
07a1f107cc Update Brazilian Portuguese translation 2020-02-06 23:47:17 +00:00
Florian Müllner
e062f27edc Bump version to 3.35.90
Update NEWS.
2020-02-06 21:42:49 +01:00
nana-4
36c417e6d9 theme: Get back .weather-header-box styling
This introduced in f2df9f1a was lost in 9ea745bc.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/957
2020-02-06 20:31:42 +00:00
nana-4
87ca1e034f theme: Move .world-clocks-button before .weather-button
As per the layout.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/957
2020-02-06 20:31:42 +00:00
nana-4
dbf1ffc9d4 theme/calendar: Don't nest all card styles for code consistency
The inconsistent styling rules "some card styles are nested, but some
are not" and "some card styles are nested, but some of their descendant
styles are defined elsewhere" are very confusing.

This commit stops nesting all card styles to make the coding style
consistent and less confusing.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/957
2020-02-06 20:31:42 +00:00
nana-4
c5bed7e963 theme: Adjust calendar popover sizing
- Remove bottom blank space on the right column of the calendar popover
  so that the weather card is bottom-aligned with the clear button on
  the left column.
- Remove top blank space on the left column of the calendar popover so
  that the message list is top-aligned with the today button on the
  right column.
- Adjust .message-list-controls sizing to align with other card-styled
  elements.
- Use regular `spacing` instead of margin for some spacing.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/2088
Closes https://gitlab.gnome.org/GNOME/gnome-shell/issues/2120
2020-02-06 20:31:42 +00:00
nana-4
fa915ff7ea theme: Simplify .message styling
- Use fewer properties for layout.
- Use .message-body instead of .message-content to change the body
  color, and remove some color overrides.
- Fix border-radius for last .message-media-control, not only on hover.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/957
2020-02-06 20:31:42 +00:00
nana-4
cbced1ce28 theme: Reorder selectors in .message
The order was messed up when the recent Sass reorganization.
This reorders the selectors in .message to make sense again.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/957
2020-02-06 20:31:42 +00:00
nana-4
900d36d0ea theme/notifications: Remove some duplicate or pointless styling
Those styles are defined in .message and do not need to be overridden in
.notification-banner.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/957
2020-02-06 20:31:42 +00:00
nana-4
62441ebeb4 theme/notifications: Remove some unused style classes
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/957
2020-02-06 20:31:42 +00:00
nana-4
051f081db7 theme: Apply spacing to .overview-icon-with-label correctly
- Remove margin-bottom for StIcon, which is not only ineffective, but
  also created a bug in app folders.
- Remove ">" which is invalid for overview icons that are not app
  folders.
- Apply spacing to the correct target "StBoxLayout", not the parent
  .overview-icon.overview-icon-with-label.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/issues/2129
2020-02-06 20:31:42 +00:00
nana-4
ddbc4ef42e theme/search-results: Use spacing instead of margin or padding
Those margin and padding broke spacing in RTL layout. We should use
regular `spacing` for them as before the refactoring.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/957
2020-02-06 20:31:42 +00:00
nana-4
fc4dfa11c3 theme: Simplify .search-section-content items styling
This reduces duplicate code in .search-provider-icon and
.list-search-result by using %search-section-content-item
to improve maintainability.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/957
2020-02-06 20:31:42 +00:00
nana-4
60f12da3cd theme: Simplify .overview-icon styling
This reduces duplicate code by using overview-icon() and %app-well-app
to improve maintainability.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/957
2020-02-06 20:31:42 +00:00
nana-4
40f7d61524 theme: Add interactive styling to .events-section-title again
Since it's an interactive element, interactive styling is still needed.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/2088
2020-02-06 20:31:42 +00:00
nana-4
1263f84c3f theme: Make %notification_bubble a mixin
And simplify .datemenu-today-button styling by using it.

This allows removing duplicate code for flat notification_bubble
styling.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/957
2020-02-06 20:31:42 +00:00
nana-4
9d91b586d8 theme: Remove unnecessary !important rules
Using !important is a bad practice and should be avoided wherever
possible to make styling and debugging easier. See:

https://developer.mozilla.org/en-US/docs/Web/CSS/Specificity#The_!important_exception

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/957
2020-02-06 20:31:42 +00:00
nana-4
ab8bce35f1 theme: Remove some unsupported CSS properties
CSS opacity and border-{top,bottom}-{left,right}-radius are not
supported by St.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/957
2020-02-06 20:31:42 +00:00
Sebastian Keller
7287ee3651 texture-cache: Fix invalid reads when storing used resource scales
The used_scales hash table uses g_double_hash and g_double_equal which
try to read a double from the passed pointers. The pointers however were
pointing to a float, leading to an invalid read.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/974
2020-02-06 19:47:24 +00:00
Florian Müllner
9d7a319721 extensionPrefs: Remove stray > in .ui file
This slipped through as GtkBuilder still accepts it, but let's
not rely on that and fix our XML.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/2180
2020-02-06 20:05:32 +01:00
Piotr Drąg
b7df1133b8 extensionPrefs: Make the Log Out button a proper verb
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/981
2020-02-06 18:56:00 +00:00
Alexander Mikhaylenko
dfb8737007 appDisplay: Disable swipe tracker during swarm animation
Eensures it resets when an animation starts.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/2177
2020-02-06 17:36:05 +00:00
Alexander Mikhaylenko
a06a418ac1 swipeTracker: Reset scroll gesture state on disabling
Ensure that scrolling works correctly next time it's enabled.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/2177
2020-02-06 17:36:05 +00:00
Michael Catanzaro
35063c9e7c portalHelper: Enable WebKit sandbox if available
The portal helper is rather sensitive because potentially-hostile Wi-Fi
networks can decide to launch it whenever they want (by blocking the
user's connection to the nmcheck domain) and load whatever web content
they want into it. So having this unsandboxed is really extraordinarily
risky. Previously it was a risk we had to accept, because WebKit did not
have a web process sandbox, but now it does. So let's bubblewrap all the
things!

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/983
2020-02-06 18:28:40 +01:00
Jakub Steiner
ded4586781 theme: revert app grid button styling
- the plan was to drop the frequent/all view switcher, thus sam didn't
  pay too much attention to the button styling for those. Sadly the view
  switcher remains, so we should keep the old subtle styling intact.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/979
2020-02-06 16:41:04 +01:00
Daniel Mustieles
89790ac723 Updated Spanish translation 2020-02-06 11:40:07 +01:00
Daniel Mustieles
d253b0671b Updated Spanish translation 2020-02-06 11:39:36 +01:00
Aurimas Černius
e58dcd3040 Updated Lithuanian translation 2020-02-05 22:49:34 +02:00
Piotr Drąg
050a1898ab extensionPrefs: Add a translator comment to the .desktop file
So that Damned Lies filters out the Icon key from translation.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/980
2020-02-05 20:40:54 +01:00
Piotr Drąg
79a8fa2ede Update POTFILES.in 2020-02-05 20:31:50 +01:00
Anders Jonsson
7819f8f82e Update Swedish translation 2020-02-05 17:25:53 +00:00
Carlos Garnacho
5c570460cf magnifier: Use core idletime monitor
As it's getting the idletime monitor for the seat pointer, boils
down to about the same thing. We are moving away from per-device
idletime monitors though.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/978
2020-02-05 16:17:30 +00:00