Florian Müllner
78c7d5ba0c
status/location: Track enabled state
...
More fallout from commit e3a1d84992
: We are tracking the agent's
:max-accuracy-level property that we don't use, but not :enabled.
https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5043
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2170 >
2022-02-10 13:19:57 +00:00
Florian Müllner
5628849a40
status/location: Use correct enabled state
...
Commit e3a1d84992
split out the agent from the indicator, but kept
using a local 'enabled' property with no connection at all to the
actual state.
https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5043
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2170 >
2022-02-10 13:19:57 +00:00
Florian Müllner
d7d484a8cd
dbusServices: Allow to persist services via environment
...
Auto-shutdown prevents debugging a service with tools like
d-feet, so allow turning it off with an environment variable.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2169 >
2022-02-10 13:14:45 +00:00
Florian Müllner
9a2505f18c
shell: Specify G_PARAM_EXPLICIT_NOTIFY where appropriate
...
Like we did in ST, opt out of g_object_set()'s implicit change
notifications, so that notify is only emitted when a property
*actually* changes.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2168 >
2022-02-10 13:09:37 +00:00
Florian Müllner
17719352f3
shell: Use g_object_notify_by_pspec() where possible
...
It's slightly more efficient not having to do property lookups. While
that is unlikely to be a concern for the properties in question, it's
still good practice and makes the code base a bit more consistent.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2168 >
2022-02-10 13:09:37 +00:00
Florian Müllner
e3a3f79200
shell/app: Remove unused property ID
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2168 >
2022-02-10 13:09:37 +00:00
Florian Müllner
5a23c96bd9
st: Specify G_PARAM_EXPLICIT_NOTIFY where appropriate
...
We are now consistently calling notify() when a property does change.
With that we can opt out of g_object_set()'s implicit change notifications,
so that notify is only emitted when a property *actually* changes.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2168 >
2022-02-10 13:09:37 +00:00
Florian Müllner
bfb52aaf9d
st: Use g_object_notify_by_pspec() where possible
...
It's slightly more efficient not having to do property lookups. While
that is unlikely to be a concern for the properties in question, it's
still good practice and makes the code base a bit more consistent.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2168 >
2022-02-10 13:09:37 +00:00
Florian Müllner
76e5e22dac
st: Add static setters
...
Even where properties can only be set via g_object_set(), separate
setters help with code organization and consistency with other
properties.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2168 >
2022-02-10 13:09:37 +00:00
Florian Müllner
6a6b7eb341
st/scroll-view: Add missing notify call
...
Another property where changes aren't notified when going through
the public setter.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2168 >
2022-02-10 13:09:37 +00:00
Florian Müllner
621c8606df
st/entry: Add missing notify calls
...
Whoops, at the moment changes of most properties are only notified
when going through g_object_set() and not when using the public
setters.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2168 >
2022-02-10 13:09:37 +00:00
Marek Černocký
a79e0aa9b4
Updated Czech translation
2022-02-09 21:35:52 +01:00
Hugo Carvalho
88338c2043
Update Portuguese translation
2022-02-09 18:37:10 +00:00
Fran Dieguez
f8fcb58cc6
Update Galician translation
2022-02-09 18:36:56 +00:00
Yuri Chornoivan
16928897fd
Update Ukrainian translation
2022-02-09 18:36:11 +00:00
Luming Zh
3d3b5270a1
Update Chinese (China) translation
2022-02-09 18:34:59 +00:00
Kukuh Syafaat
a152b6f8cf
Update Indonesian translation
2022-02-09 18:34:22 +00:00
Carlos Garnacho
c13d44439f
popupMenu: Avoid intermediate focus changes on menu switch
...
Currently when switching from a popup menu to another in the same
manager, we first show the new menu, then hide the old menu and
remove its grab, then create a new grab for the just shown menu.
This briefly ungrabbed moment will still trigger keyboard focus
changes, that might have other visible effects. In order to fix
this, change the grabbing order so first the new grab is created
then the old one is dismissed. This ensures focus moves from the
old menu to the new menu without gaps in between.
Since a grab is tied to an active menu, but close/grab are now
slightly decoupled, also ensure closing a menu only tears down its
own grab. This is necessary for correct accounting while doing the
grab shuffling.
Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5039
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2166 >
2022-02-09 16:44:08 +00:00
Florian Müllner
00e41383c7
dbusServices/screencast: Removed unused properties
...
Those have been superseded by corresponding state enums.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2165 >
2022-02-09 13:00:04 +01:00
Bastien Nocera
0531fc54e5
status/bluetooth: Fix wedged state
...
Fix a state where toggling the main Bluetooth switch in the header will
always show the "Bluetooth Off" menu header with "Turn Off" as the only
option.
To reproduce, with Bluetooth enabled and working, run
"hciconfig hci0 down" as root, and check the status menu.
See gnome-bluetooth!102 and gnome-control-center!1148
Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4857
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2055 >
2022-02-08 23:16:46 +00:00
Bastien Nocera
4a480a78af
status/bluetooth: Port to new GListModel API
...
The GtkTreeView API was removed, and replaced with a GListModel API.
Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4748
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2055 >
2022-02-08 23:16:46 +00:00
Sebastian Wick
170f3ee089
glsl-effect: Allow to set uniform matrices
...
Add support for setting a uniform matrix on GLSLEffect because the color
vision deficiency simulation extension requires it.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2164 >
2022-02-08 21:55:31 +01:00
Florian Müllner
e07bc62fbd
dbusServices/extensions: Give extensions access to the prefs window
...
The current preference API - buildPrefsWidget() - predates client-side
decorations. While extension authors have been finding ways around
the limitation of not having access to the window/titlebar, the change
to the new Adwaita API seems like a good time for an updated API that
officially provides that access (as far as allowed by libadwaita).
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2012 >
2022-02-08 19:11:19 +00:00
Florian Müllner
285ebe020c
dbusServices/extensions: Stop setting a default size
...
Adw.PreferencesWindow already sets an appropriate default.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2012 >
2022-02-08 19:11:19 +00:00
Florian Müllner
cd9532c678
dbusServices/extensions: Use default style class
...
libadwaita provides a series of style classes as part of its API.
Use those instead of meddling manually with the font size.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2012 >
2022-02-08 19:11:19 +00:00
Florian Müllner
7a8b636028
dbusServides/extensions: Use Adw.PreferencesWindow
...
Adapt the new GNOME platform API for the upcoming 42. This makes
sure that we get the latest version of the stylesheet, as well as
support for the new dark mode.
Using the dedicated preference API also gives extensions with more
complex preferences an easier and standardized way for implementing
multi-page preferences.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2012 >
2022-02-08 19:11:19 +00:00
Florian Müllner
089fd315dd
dbusServices/extensions: Simplify actions handling
...
GTK4 has dedicated API for widget-specific actions, make use of that
instead of explicitly managing an action group.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2012 >
2022-02-08 19:11:19 +00:00
Florian Müllner
ae92c1c4eb
dbusServices/extensions: Split error page from window
...
The error UI comprises the bits that are actually custom. Splitting them
out from the off-the-shelf window makes it easier to replace the dialog
with libadwaita's dedicated preference window.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2012 >
2022-02-08 19:11:19 +00:00
Florian Müllner
073dbc3a04
dbusServices/extensions: Split out prefs dialog
...
We're about to make changes to the UI, so this seems to be a good
time to split GUI and service code.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2012 >
2022-02-08 19:11:19 +00:00
Florian Müllner
c071c3ed4c
dbus-services/extensions: Remove outdated requires
...
We are using GTK4, not GTK3 >= 3.20 ...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2012 >
2022-02-08 19:11:19 +00:00
Mohammed Sadiq
9f76d121cc
osk: Remove a duplicate key from Malayalam
...
The same key has been included as the first item on the third row
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2162 >
2022-02-08 18:50:28 +00:00
Bastien Nocera
b83b22bc58
powerProfiles: Remove support for power-profiles-daemon < 0.9.0
...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2101 >
2022-02-08 11:21:44 +00:00
Olivier Fourdan
5b8a32ca71
main: Raise the NOFILE limit if a Wayland compositor
...
When being run as a Wayland compositor, raise the NOFILE limit to
mitigate the risk of running out of file descriptors.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2117 >
2022-02-08 08:25:25 +00:00
Olivier Fourdan
9862ee9b25
shell/app: Restore NOFILE limit
...
Restore the nofile limit when launching apps so that they do not
inherit from the Shell's own limit.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2117 >
2022-02-08 08:25:25 +00:00
Olivier Fourdan
1bb05c33be
shell: Restore NOFILE limit before restarting
...
When restarting Shell, make sure to restore the original nofile limit so
that the new instance starts with the original value.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2117 >
2022-02-08 08:25:25 +00:00
Olivier Fourdan
3fc7357e3f
util: Restore the NOFILE limit before spawning apps
...
Make sure the restore the original NOFILE limit prior to run the
commands so those don't inherit from the raised value.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2117 >
2022-02-08 08:25:25 +00:00
Olivier Fourdan
bafacdf629
ibusManager: Restore the NOFILE limit
...
Use GLib's spawn_async() instead of Gio.SubprocessLauncher() which does
not support the child setup function to start ibus-daemon.
This way we can restore the NOFILE limit prior to run the ibus-daemon.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2117 >
2022-02-08 08:25:25 +00:00
Olivier Fourdan
7c394b0512
networkAgent: Restore the NOFILE limit
...
Restore the original NOFILE limit prior to spawn the VPN helper.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2117 >
2022-02-08 08:25:25 +00:00
Florian Müllner
8d8eba000f
dbusServices: Allow replacement
...
The REPLACE flag we currently pass is useless, as replacing the service
is disallowed when not started with the ALLOW_REPLACEMENT flag.
Fix this by adopting a more standard pattern where replacement is always
allowed, but only actually requested when `--replace` is passed on the
command line.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2152 >
2022-02-07 18:44:34 +00:00
Aleksandr Melman
ae053f954f
Update Russian translation
2022-02-07 18:33:25 +00:00
Matej Urbančič
770f1f7102
Update Slovenian translation
2022-02-07 18:23:20 +00:00
Rachit Keerti Das
a67877f520
dash: Use pin instead of favorites
...
Use the term 'pin' for adding new items to the dash
Note that this is only a string change.
Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4976
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2136 >
2022-02-07 14:12:04 +00:00
Daniel Mustieles
f094b6ddd6
Updated Spanish translation
2022-02-07 13:52:03 +01:00
Alexander Mikhaylenko
a619eb55bf
background: Support dark wallpapers
...
See https://gitlab.gnome.org/GNOME/gnome-control-center/-/merge_requests/1174
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2137 >
2022-02-07 10:20:51 +00:00
Hugo Carvalho
bc326c3efb
Update Portuguese translation
2022-02-06 22:36:31 +00:00
Sam Hewitt
d9f3596592
lookingGlass: Fix visual papercuts
...
- change icon size to 16px
- give those icons a buttonized style
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2156 >
2022-02-06 20:59:38 +01:00
Florian Müllner
a92f749daf
lookingGlass: Turn toolbar icons into actual buttons
...
Yes, we can use reactive icons with a `button-press-event` handler,
but really, there's a standard control for that kind of behavior ...
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2156 >
2022-02-06 20:59:35 +01:00
Aurimas Černius
543ec6a0d3
Updated Lithuanian translation
2022-02-06 17:04:40 +02:00
Luming Zh
d0643d450c
Update Chinese (China) translation
2022-02-05 13:03:20 +00:00
Florian Müllner
35466b0e0a
dbusServices/notifications: Disallow acting on "foreign" IDs
...
The Notify() and CloseNotification() methods act on a notification,
identified by the passed ID. Just like it makes sense to only emit
notification signals to the original sender, those methods should
be restricted to the notification owner.
https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5008
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2153 >
2022-02-05 12:17:23 +00:00