Commit Graph

12736 Commits

Author SHA1 Message Date
Todd C. Miller
2c06aa321b cvtsudoers_ldif: display warning on write error 2023-11-11 08:19:19 -07:00
Todd C. Miller
7e4632691b cvtsudoers_merge.c: remove sudo_fatal() calls.
Errors are now propagated up the call stack.
2023-11-11 08:15:06 -07:00
Todd C. Miller
8cfd4467f4 Make new_member() return NULL on failure and adjust callers. 2023-11-10 16:53:57 -07:00
Todd C. Miller
564d8ac01d Pass return values back instead of using sudo_fatal(). 2023-11-10 14:05:35 -07:00
Todd C. Miller
d28884b1c7 Add printf_attribute_ldif() to printf-format an LDIF attribute.
This replaces multiple sequences of asprintf() and print_attribute_ldif().
2023-11-10 13:34:13 -07:00
Todd C. Miller
12e55dcd78 cvtsudoers_json.c: check sudo_json_* return values.
Previously, we set memfatal to true in sudo_json_init() instead.
This also gets rid of a number of sudo_fatalx() calls.
2023-11-09 17:12:56 -07:00
Todd C. Miller
1a68935ae3 add_timestamp: check sudo_json_* return values. 2023-11-09 17:12:55 -07:00
Todd C. Miller
a2998a6701 alias_apply: change return type to bool
We can use the rbapply() return value to detect failure.
2023-11-09 15:31:26 -07:00
Todd C. Miller
ab49adb92d Always disable core dumps when sudo sends itself a fatal signal.
When a command exits due to a fatal signal, sudo will re-send that
signal to itself so the shell does not ignore keyboard-generated
signals.  However, now that sudo disables core dumps by default for
the command, we cannot rely on WCOREDUMP() telling us whether or
not the signal will lead to a core dump.  It is safest to always
disable core dumps before sending the signal to ourself.
2023-11-09 14:08:50 -07:00
Todd C. Miller
62895ea442 Sudo 1.9.15p2 2023-11-08 20:10:02 -07:00
Todd C. Miller
0f40753d46 Update PolyPkg from upstream. 2023-11-08 18:46:03 -07:00
Todd C. Miller
a6ac589cc1 sudo_term_restore: don't check c_cflag on systems with TCSASOFT.
If TCSASOFT is present, tcsetattr() will ignore c_cflag.
Fixes a bug where sudo_term_restore() would refuse to change
the terminal settings back if the PARENB control flag was set.
GitHub issue #326.
2023-11-08 16:58:02 -07:00
Todd C. Miller
0497bde983 Quote $osversion since it may include whitespace. 2023-11-08 08:16:57 -07:00
Todd C. Miller
e0d912d1db Use C99 designated struct initializers.
This is less error-prone and would have avoided GitHub issue #325.
2023-11-07 14:47:48 -07:00
Todd C. Miller
45aeeddcbe Sudo 1.9.15p1 2023-11-07 13:46:01 -07:00
Todd C. Miller
87c193f3f9 Correct the order of the strings in SUDOERS_CONTEXT_INITIALIZER.
Fixes GitHub issue #325, a bug introduced in sudo 1.9.15.
2023-11-07 13:38:30 -07:00
Todd C. Miller
d45071af4f In the sudo 1.9.14p3 section, "Python python" should be "Python plugin". 2023-11-06 12:14:40 -07:00
Todd C. Miller
747c340591 Sudo now logs the submitenv in the JSON logs. 2023-11-06 10:14:03 -07:00
Todd C. Miller
3686c9fdd1 Document special cases for AIX-style shared libraries.
The shared object is a member of an archive file that is specified
in parentheses.
2023-11-06 09:39:36 -07:00
Todd C. Miller
e772479272 Add sudoers plugin Debug example and x-ref sudoers man page for details. 2023-11-04 19:36:35 -06:00
Todd C. Miller
ec6906f63b The HP-UX getgrouplist() code has been disabled due to bugs. 2023-11-04 18:51:36 -06:00
Todd C. Miller
097bec06bd sudo_conf_debug_files: special handling of DSO members for AIX
When matching debug files for AIX-style DSOs like sudoers.a(sudoers.so)
we want to match on the full name, the name without the member and
on the member itself.  This makes it possible to use the existing
examples in the sudo.conf fiile on AIX.
2023-11-03 11:29:20 -06:00
Todd C. Miller
24351bdadc sudo_set_grlist and sudo_set_gidlist: set auth registry based on username
Previously we used the global registry but since we have the user's
passwd info we should use that when storing the group and gid lists.
2023-11-03 10:30:56 -06:00
Todd C. Miller
2ffcda8e15 role_to_sudoers: only try to reuse a privilege if one is present 2023-11-02 14:42:42 -06:00
Todd C. Miller
1a11be4d9f store_plugin: avoid potential NULL deref in boolean context
Coverity CID 330466
2023-11-02 14:26:44 -06:00
Todd C. Miller
4833ac0f01 Avoid passing sudo_term_is_raw() -1 for the fd.
Coverity CID 330472
Coverity CID 330468
2023-11-02 14:17:51 -06:00
Todd C. Miller
3b891c136e fmt_info_messages: bump info_msgs_size for submitenv 2023-11-02 13:57:18 -06:00
Todd C. Miller
77c2582907 Better log message when rejecting a setid command in intercept mode. 2023-11-02 13:44:19 -06:00
Todd C. Miller
886f1414eb Move the check for running setid commands in intercept mode to later.
Checking for setid commands in intercept mode after command matching
allows us to log a proper error message.  Previously, we simply
ignored setid commands when matching and the only indication of why
was in the debug logs.
2023-11-02 13:44:17 -06:00
Todd C. Miller
45e3c0dd17 timestamp_open: add some debugging 2023-11-02 09:10:49 -06:00
Todd C. Miller
3297ffa267 sudo_sia_begin_session: add missing struct sudoers_context * arg. 2023-10-31 10:26:57 -06:00
Todd C. Miller
747114f331 verify_krb_v5_tgt: auth name must be const to match struct sudo_auth. 2023-10-31 10:13:19 -06:00
Todd C. Miller
9ef52151ef Disable PAM before enabling Kerberos V. 2023-10-31 10:00:24 -06:00
Todd C. Miller
7ed7b4536f Add Kerberos V build and test to CI. 2023-10-31 09:54:57 -06:00
Todd C. Miller
145faa3fe9 Updated translations from translationproject.org 2023-10-30 16:25:36 -06:00
Renato Botelho
75e829b740 Add missing sudoers_context to verify_krb_v5_tgt()
Commit 2440174954 added ctx variable to log_warningx() call but that
variable was not declared in that context, breaking the build.
2023-10-31 07:50:45 -06:00
Todd C. Miller
5f3a6b4f6a Mention new Indonesian translation and sudo_logsrvd fd limit change. 2023-10-23 10:19:28 -06:00
Todd C. Miller
31bcdec232 Set the open file descriptor limit to the maximum allowed value.
Each connection can require up to 9 descriptors.
2023-10-27 11:17:32 -06:00
Todd C. Miller
bf722e18b7 Updated translations from translationproject.org 2023-10-23 07:52:36 -06:00
Todd C. Miller
86f1d52a0b Add Andika Triwidada 2023-10-23 07:52:23 -06:00
Todd C. Miller
9a2a882d12 New Indonesian translation from translationproject.org 2023-10-23 07:51:29 -06:00
Todd C. Miller
0fbb17de5e Mention GitHub issue #318 2023-10-22 10:58:22 -06:00
Todd C. Miller
392ae0f030 Avoid a double-free in fuzz_policy caused by the early env_init(NULL).
This adds an env_free() function to explicitly free both the old
and new copies of the environment.  It is really only needed by
fuzz_policy, which calls the policy module multiple times.
2023-10-22 09:56:16 -06:00
Todd C. Miller
3bbc7c8f85 Store submitenv in eventlog and pass it to sudo_logsrvd. 2023-10-22 08:36:44 -06:00
Todd C. Miller
726b646b48 struct eventlog: rename argv/env to runargv/runenv.
This matches the JSON logs.
2023-10-21 19:15:46 -06:00
Todd C. Miller
c7a61a9438 struct sudoers_user_context: rename env_vars to env_add 2023-10-21 19:15:45 -06:00
Todd C. Miller
2b87749f8f Only log the run environment for commands that are allowed.
It may not be available otherwise and unless the command is being
run it has no real meaning.
2023-10-21 19:15:44 -06:00
Todd C. Miller
077826292c Free the private copy of the environment in sudoers_check_cmnd().
This reverts 5118eb5797fb, which had the side-effect of the PAM
session code running with the run environment instead of the invoking
user's environment.  Issue #318
2023-10-21 19:15:42 -06:00
Todd C. Miller
8486976b9e iolog_swapids: short circuit if effective ids match iolog ids. 2023-10-19 16:22:42 -06:00
Todd C. Miller
09a4264372 logsrvd: display error string in message if iolog_mkpath() fails 2023-10-19 14:39:13 -06:00