isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Quiet a few -Wunused-result compiler warnings.

Browse Source
This commit is contained in:
Todd C. Miller
2013-05-01 11:02:09 -04:00
parent 874d84f263
commit f6e8fb8b1c
5 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
common/sudo_debug.c
View File

@@ -146,7 +146,7 @@ int sudo_debug_init(const char *debugfile, const char *settings)
}
if (sudo_debug_fd == -1)
return 0;
fchown(sudo_debug_fd, (uid_t)-1, 0);
ignore_result(fchown(sudo_debug_fd, (uid_t)-1, 0));
}
(void)fcntl(sudo_debug_fd, F_SETFD, FD_CLOEXEC);
sudo_debug_mode = SUDO_DEBUG_MODE_FILE;

6
plugins/sudoers/iolog.c
View File

@@ -139,7 +139,7 @@ io_mkdirs(char *path, mode_t mode, bool is_temp)
if (stat(path, &sb) != 0) {
if (mkdir(path, mode) != 0)
log_fatal(USE_ERRNO, N_("unable to mkdir %s"), path);
(void) chown(path, (uid_t)-1, parent_gid);
ignore_result(chown(path, (uid_t)-1, parent_gid));
} else if (!S_ISDIR(sb.st_mode)) {
log_fatal(0, N_("%s exists but is not a directory (0%o)"),
path, (unsigned int) sb.st_mode);
@@ -153,11 +153,11 @@ io_mkdirs(char *path, mode_t mode, bool is_temp)
if (is_temp) {
if (mkdtemp(path) == NULL)
log_fatal(USE_ERRNO, N_("unable to mkdir %s"), path);
(void) chown(path, (uid_t)-1, parent_gid);
ignore_result(chown(path, (uid_t)-1, parent_gid));
} else {
if (mkdir(path, mode) != 0 && errno != EEXIST)
log_fatal(USE_ERRNO, N_("unable to mkdir %s"), path);
(void) chown(path, (uid_t)-1, parent_gid);
ignore_result(chown(path, (uid_t)-1, parent_gid));
}
debug_return;
}

2
plugins/sudoers/set_perms.c
View File

@@ -1085,7 +1085,7 @@ restore_perms(void)
if (OID(euid) == ROOT_UID) {
/* setuid() may not set the saved ID unless the euid is ROOT_UID */
if (ID(euid) != ROOT_UID)
(void)setreuid(-1, ROOT_UID);
ignore_result(setreuid(-1, ROOT_UID));
if (setuid(ROOT_UID)) {
warning("setuid() [%d, %d] -> %d)", (int)state->ruid,
(int)state->euid, ROOT_UID);

3
src/sudo.c
View File

@@ -276,7 +276,8 @@ main(int argc, char *argv[], char *envp[])
if (ISSET(sudo_mode, MODE_BACKGROUND))
SET(command_details.flags, CD_BACKGROUND);
/* Become full root (not just setuid) so user cannot kill us. */
(void) setuid(ROOT_UID);
if (setuid(ROOT_UID) == -1)
warning("setuid(%d)", ROOT_UID);
/* Restore coredumpsize resource limit before running. */
#ifdef RLIMIT_CORE
if (sudo_conf_disable_coredump())

3
src/tgetpass.c
View File

@@ -225,7 +225,8 @@ sudo_askpass(const char *askpass, const char *prompt)
warning("dup2");
_exit(255);
}
(void) setuid(ROOT_UID);
if (setuid(ROOT_UID) == -1)
warning("setuid(%d)", ROOT_UID);
if (setgid(user_details.gid)) {
warning(_("unable to set gid to %u"), (unsigned int)user_details.gid);
_exit(255);