isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Only shift unsigned values to avoid implementation-specific behavior.

Browse Source 
This converts the arithmetic shifts to logical shifts.
This commit is contained in:
Todd C. Miller
2022-06-06 20:15:37 -06:00
parent 263fdc6b06
commit e4ea5ad8af
1 changed files with 12 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
lib/protobuf-c/protobuf-c.c
View File

@@ -331,9 +331,8 @@ int32_size(int32_t v)
static inline uint32_t
zigzag32(int32_t v)
{
// Note: the right-shift must be arithmetic
// Note: left shift must be unsigned because of overflow
return ((uint32_t)(v) << 1) ^ (uint32_t)(v >> 31);
// Note: Using unsigned types prevents undefined behavior
return ((uint32_t)v << 1) ^ -((uint32_t)v >> 31);
}
/**
@@ -395,9 +394,8 @@ uint64_size(uint64_t v)
static inline uint64_t
zigzag64(int64_t v)
{
// Note: the right-shift must be arithmetic
// Note: left shift must be unsigned because of overflow
return ((uint64_t)(v) << 1) ^ (uint64_t)(v >> 63);
// Note: Using unsigned types prevents undefined behavior
return ((uint64_t)v << 1) ^ -((uint64_t)v >> 63);
}
/**
@@ -817,7 +815,8 @@ uint32_pack(uint32_t value, uint8_t *out)
}
/**
* Pack a signed 32-bit integer and return the number of bytes written.
* Pack a signed 32-bit integer and return the number of bytes written,
* passed as unsigned to avoid implementation-specific behavior.
* Negative numbers are encoded as two's complement 64-bit integers.
*
* \param value
@@ -828,14 +827,14 @@ uint32_pack(uint32_t value, uint8_t *out)
* Number of bytes written to `out`.
*/
static inline size_t
int32_pack(int32_t value, uint8_t *out)
int32_pack(uint32_t value, uint8_t *out)
{
if (value < 0) {
if ((int32_t)value < 0) {
out[0] = value | 0x80;
out[1] = (value >> 7) | 0x80;
out[2] = (value >> 14) | 0x80;
out[3] = (value >> 21) | 0x80;
out[4] = (value >> 28) | 0x80;
out[4] = (value >> 28) | 0xf0;
out[5] = out[6] = out[7] = out[8] = 0xff;
out[9] = 0x01;
return 10;
@@ -2440,7 +2439,7 @@ static inline int32_t
unzigzag32(uint32_t v)
{
// Note: Using unsigned types prevents undefined behavior
return (int32_t)((v >> 1) ^ (~(v & 1) + 1));
return (int32_t)((v >> 1) ^ -(v & 1));
}
static inline uint32_t
@@ -2482,7 +2481,7 @@ static inline int64_t
unzigzag64(uint64_t v)
{
// Note: Using unsigned types prevents undefined behavior
return (int64_t)((v >> 1) ^ (~(v & 1) + 1));
return (int64_t)((v >> 1) ^ -(v & 1));
}
static inline uint64_t
@@ -3556,7 +3555,7 @@ protobuf_c_service_generated_init(ProtobufCService *service,
service->descriptor = descriptor;
service->destroy = destroy;
service->invoke = protobuf_c_service_invoke_internal;
memset(service + 1, 0, descriptor->n_methods * sizeof(GenericHandler));
memset(&service[1], 0, descriptor->n_methods * sizeof(GenericHandler));
}
void protobuf_c_service_destroy(ProtobufCService *service)