isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Check localtime() return value; coverity CID 208156

Browse Source
This commit is contained in:
Todd C. Miller
2020-02-07 13:58:31 -07:00
parent a75992897c
commit d25ce46c56
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/sample_approval/sample_approval.c
View File

@@ -138,8 +138,8 @@ approval_check(unsigned int version, sudo_conv_t conversation,
* which are 9am - 5pm local time. Does not check holidays.
*/
ret = 0;
time(&now);
tm = localtime(&now);
if (time(&now) == -1 || (tm = localtime(&now)) == NULL)
goto bad;
if (tm->tm_wday < 1 || tm->tm_wday > 5) {
/* bad weekday */
goto bad;
@@ -164,7 +164,7 @@ bad:
}
done:
while ((debug_file = TAILQ_FIRST(&debug_files))) {
while ((debug_file = TAILQ_FIRST(&debug_files)) != NULL) {
TAILQ_REMOVE(&debug_files, debug_file, entries);
free(debug_file->debug_file);
free(debug_file->debug_flags);