isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix logic goof when checking open() status.

Browse Source
This commit is contained in:
Todd C. Miller
2013-09-03 11:24:31 -06:00
parent 13fd13e17c
commit 6b57ef4f6d
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/sudoers/iolog.c
View File

@@ -487,7 +487,7 @@ write_info_log(char *pathbuf, size_t len, struct iolog_details *details,
pathbuf[len] = '\0'; pathbuf[len] = '\0';
strlcat(pathbuf, "/log", PATH_MAX); strlcat(pathbuf, "/log", PATH_MAX);
fd = open(pathbuf, O_CREAT|O_WRONLY, S_IRUSR|S_IWUSR); fd = open(pathbuf, O_CREAT|O_WRONLY, S_IRUSR|S_IWUSR);
if (fd != -1 || (fp = fdopen(fd, "w")) == NULL) if (fd == -1 || (fp = fdopen(fd, "w")) == NULL)
log_fatal(USE_ERRNO, N_("unable to create %s"), pathbuf); log_fatal(USE_ERRNO, N_("unable to create %s"), pathbuf);
fprintf(fp, "%lld:%s:%s:%s:%s:%d:%d\n%s\n%s", (long long)now->tv_sec, fprintf(fp, "%lld:%s:%s:%s:%s:%d:%d\n%s\n%s", (long long)now->tv_sec,