Fix several issues found by the clang static analyzer; Daniel Kopecek

This commit is contained in:
Todd C. Miller
2013-12-03 14:10:11 -07:00
parent dc69e5af57
commit 543d3b701e

View File

@@ -311,9 +311,8 @@ static int sudo_sss_close(struct sudo_nss *nss)
if (nss && nss->handle) {
handle = nss->handle;
sudo_dso_unload(handle->ssslib);
efree(nss->handle);
}
efree(nss->handle);
debug_return_int(0);
}
@@ -663,12 +662,15 @@ sudo_sss_result_get(struct sudo_nss *nss, struct passwd *pw, uint32_t *state)
*state |= _SUDO_SSS_STATE_HOSTMATCH;
}
}
sudo_debug_printf(SUDO_DEBUG_DEBUG,
"u_sss_result=(%p, %u) => f_sss_result=(%p, %u)", u_sss_result,
u_sss_result->num_rules, f_sss_result, f_sss_result->num_rules);
} else {
sudo_debug_printf(SUDO_DEBUG_DEBUG,
"u_sss_result=(%p, %u) => f_sss_result=NULL", u_sss_result,
u_sss_result->num_rules);
}
sudo_debug_printf(SUDO_DEBUG_DEBUG,
"u_sss_result=(%p, %u) => f_sss_result=(%p, %u)", u_sss_result,
u_sss_result->num_rules, f_sss_result, f_sss_result->num_rules);
handle->fn_free_result(u_sss_result);
debug_return_ptr(f_sss_result);