isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

visudo: quiet a compiler warning on Solaris 10.

Browse Source 
Also explicitly close /dev/tty fd instead of relying on closefrom()
in case the fd ends up being a value 0-2.
This commit is contained in:
Todd C. Miller
2023-02-22 10:55:27 -07:00
parent 8bb1160624
commit 1641c30ed6
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
plugins/sudoers/visudo.c
View File

@@ -911,10 +911,13 @@ run_command(const char *path, char *const *argv, bool foreground)
pid = getpid();
setpgid(0, pid);
fd = open(_PATH_TTY, O_RDWR);
if (fd != -1 && tcsetpgrp(fd, pid) == -1) {
sudo_debug_printf(SUDO_DEBUG_ERROR|SUDO_DEBUG_ERRNO,
"%s: unable to set foreground pgrp to %d (editor)",
__func__, pid);
if (fd != -1) {
if (tcsetpgrp(fd, pid) == -1) {
sudo_debug_printf(SUDO_DEBUG_ERROR|SUDO_DEBUG_ERRNO,
"%s: unable to set foreground pgrp to %d (editor)",
__func__, (int)pid);
}
close(fd);
}
}
closefrom(STDERR_FILENO + 1);