mirror of
https://github.com/brl/mutter.git
synced 2024-11-12 17:27:03 -05:00
Read-only mirror of https://gitlab.gnome.org/GNOME/mutter
df21e20f65
Although we use GLib internally in Cogl we would rather not leak GLib api through Cogl's own api, except through explicitly namespaced cogl_glib_ / cogl_gtype_ feature apis. One of the benefits we see to not leaking GLib through Cogl's public API is that documentation for Cogl won't need to first introduce the Glib API to newcomers, thus hopefully lowering the barrier to learning Cogl. This patch provides a Cogl specific typedef for reporting runtime errors which by no coincidence matches the typedef for GError exactly. If Cogl is built with --enable-glib (default) then developers can even safely assume that a CoglError is a GError under the hood. This patch also enforces a consistent policy for when NULL is passed as an error argument and an error is thrown. In this case we log the error and abort the application, instead of silently ignoring it. In common cases where nothing has been implemented to handle a particular error and/or where applications are just printing the error and aborting themselves then this saves some typing. This also seems more consistent with language based exceptions which usually cause a program to abort if they are not explicitly caught (which passing a non-NULL error signifies in this case) Since this policy for NULL error pointers is stricter than the standard GError convention, there is a clear note in the documentation to warn developers that are used to using the GError api. Reviewed-by: Neil Roberts <neil@linux.intel.com> (cherry picked from commit b068d5ea09ab32c37e8c965fc8582c85d1b2db46) Note: Since we can't change the Cogl 1.x api the patch was changed to not rename _error_quark() functions to be _error_domain() functions and although it's a bit ugly, instead of providing our own CoglError type that's compatible with GError we simply #define CoglError to GError unless Cogl is built with glib disabled. Note: this patch does technically introduce an API break since it drops the cogl_error_get_type() symbol generated by glib-mkenum (Since the CoglError enum was replaced by a CoglSystemError enum) but for now we are assuming that this will not affect anyone currently using the Cogl API. If this does turn out to be a problem in practice then we would be able to fix this my manually copying an implementation of cogl_error_get_type() generated by glib-mkenum into a compatibility source file and we could also define the original COGL_ERROR_ enums for compatibility too. Note: another minor concern with cherry-picking this patch to the 1.14 branch is that an api scanner would be lead to believe that some APIs have changed, and for example the gobject-introspection parser which understands the semantics of GError will not understand the semantics of CoglError. We expect most people that have tried to use gobject-introspection with Cogl already understand though that it is not well suited to generating bindings of the Cogl api anyway and we aren't aware or anyone depending on such bindings for apis involving GErrors. (GnomeShell only makes very-very minimal use of Cogl via the gjs bindings for the cogl_rectangle and cogl_color apis.) The main reason we have cherry-picked this patch to the 1.14 branch even given the above concerns is that without it it would become very awkward for us to cherry-pick other beneficial patches from master. |
||
---|---|---|
build | ||
cogl | ||
cogl-gles2 | ||
cogl-pango | ||
doc | ||
examples | ||
po | ||
tests | ||
.gitignore | ||
.vimrc | ||
autogen.sh | ||
ChangeLog | ||
cogl.doap | ||
config-custom.h | ||
config.h.win32.in | ||
configure.ac | ||
COPYING | ||
Makefile.am | ||
NEWS | ||
README.in |
README for Cogl @COGL_1_VERSION@ =============================================================================== Note: This file is delimited with -- markers so it is possible to split sections out for other purposes, such as for release notes. -- DESCRIPTION ------------------------------------------------------------------------------- Cogl is a small open source library for using 3D graphics hardware for rendering. The API departs from the flat state machine style of OpenGL and is designed to make it easy to write orthogonal components that can render without stepping on each others toes. As well as aiming for a nice API, we think having a single library as opposed to an API specification like OpenGL has a few advantages too; like being able to paper over the inconsistencies/bugs of different OpenGL implementations in a centralized place, not to mention the myriad of OpenGL extensions. It also means we are in a better position to provide utility APIs that help software developers since they only need to be implemented once and there is no risk of inconsistency between implementations. Having other backends, besides OpenGL, such as drm, Gallium or D3D are options we are interested in for the future. -- REQUIREMENTS ------------------------------------------------------------------------------- Cogl currently only requires: • GLib ≥ @GLIB_REQ_VERSION@ • OpenGL ≥ 1.3 (or 1.2 + multitexturing), or OpenGL ES 2.0 (or 1.1) • GLX, AGL, WGL or an EGL implementation Cogl also has optional dependencies: • GDK-Pixbuf ≥ @GDK_PIXBUF_REQ_VERSION@ - for image loading • Cairo ≥ @CAIRO_REQ_VERSION@ - for debugging texture atlasing (debug builds only) The optional Cogl Pango library requires: • Cairo ≥ @CAIRO_REQ_VERSION@ • PangoCairo ≥ @PANGOCAIRO_REQ_VERSION@ On X11, Cogl depends on the following extensions • XComposite ≥ @XCOMPOSITE_REQ_VERSION@ • XDamage • XExt • XFixes ≥ @XFIXES_REQ_VERSION@ When running with OpenGL, Cogl requires at least version 1.3 or 1.2 with the multitexturing extension. However to build Cogl you will need the latest GL headers which can be obtained from: http://www.khronos.org If you are building the API reference you will also need: • GTK-Doc ≥ @GTK_DOC_REQ_VERSION@ If you are building the additional documentation you will also need: • xsltproc • jw (optional, for generating PDFs) If you are building the Introspection data you will also need: • GObject-Introspection ≥ @GI_REQ_VERSION@ GObject-Introspection is available from: git://git.gnome.org/gobject-introspection If you want support for profiling Cogl you will also need: • UProf ≥ @UPROF_REQ_VERSION@ UProf is available from: git://github.com/rib/UProf.git -- DOCUMENTATION ------------------------------------------------------------------------------- The 1.x stable API is documented here: http://developer.gnome.org/cogl/stable/ The 1.x development API is documented here: http://developer.gnome.org/cogl/1.$(COGL_1_MINOR_VERSION) The experimental 2.0 API is currently not hosted online but can be built by passing the --enable-gtk-doc option to ./configure when building and the documentation can then be found under doc/reference/cogl-2.0-experimental/html/index.html -- LICENSE ------------------------------------------------------------------------------- Most of Cogl is licensed under the terms of the GNU Lesser General Public License, version 2.1 or (at your option) later. Some files are licensed under more permissive licenses MIT or BSD style licenses though so please see individual files for details. -- BUILDING AND INSTALLATION ------------------------------------------------------------------------------- Please refer to the INSTALL document. -- BUGS ------------------------------------------------------------------------------- Please report bugs here: http://bugzilla.gnome.org/enter_bug.cgi?product=cogl You will need a Bugzilla account. Please include the following in bug reports: • what system you're running Cogl on; • which version of Cogl you are using; • which version of GLib and OpenGL (or OpenGL ES) you are using; • which video card and which drivers you are using, including output of glxinfo and xdpyinfo (if applicable); • how to reproduce the bug. If you cannot reproduce the bug with one of the tests that come with Cogl's source code, it can help a lot to include a small test case displaying the bad behaviour. If the bug exposes a crash, the exact text printed out and a stack trace obtained using gdb are greatly appreciated. -- CONTRIBUTING ------------------------------------------------------------------------------- The CODING_STYLE file describes the coding style we use throughout Cogl, please try your best to conform to this style because the consistency really helps keep the code maintainable. We can accept contributions in several ways: • Either as patches attached to bugs on bugzilla - For this you may be interested in using git-bz. See http://git.fishsoup.net/man/git-bz.html for details • You can email us patches - For this we recommend using git-send-email • You can create a remote branch and ask us to pull from that for more substantial changes. - For this we recommend using github. Ideally standalone patches should be created using git format-patch since that makes it easiest to import the patch with a commit message into a git repository.