Jasper St. Pierre
73e2d7049a
window: Rearrange code a tiny bit
2014-05-01 19:50:38 -04:00
Jasper St. Pierre
a6353944f6
constraints: Remove a lie
...
The orig / new now are about the frame rect, not the inner window
rect.
2014-05-01 19:50:38 -04:00
Jasper St. Pierre
43d6088ebb
window: Change meta_window_move_resize_internal to take a MetaRectangle
...
We construct one anyway, and most callers already pass in a rectangle
the long way around, so why not change the internal API?
2014-05-01 19:13:33 -04:00
Jasper St. Pierre
e3001794f2
window-x11: Clean up formatting a bit more
2014-05-01 19:11:17 -04:00
Jasper St. Pierre
e97ca325e6
window-x11: Clean up a bit
2014-05-01 19:10:48 -04:00
Jasper St. Pierre
c9c6645284
window-x11: Fix a copy/paste error
...
We need to use the explicitly passed-in gravity here, rather
than the window's existing gravity.
2014-05-01 19:09:36 -04:00
Jasper St. Pierre
57bb297450
window-wayland: Fix interactive resizing from the top/left once more
...
Ugh. So in the fullscreen case, we need to make sure to specify that
it's a MOVE_ACTION so that we move to the saved position, but we
can't do that in the resizing case since we need to use the resized
rectangle.
The flags are really hurting us here. Perhaps we should make it the
client's responsibility to specify a complete rectangle which we
could resize to; then the weird-o logic would be self-contained in
each front-end.
I'm not convinced this covers all cases, especially when we could have
a dangling weird state pointer, but it fixes our existing two testcases.
2014-05-01 18:59:17 -04:00
Jasper St. Pierre
06ca99c3a3
window: Remove some ugly debug logging
2014-05-01 17:59:50 -04:00
Jasper St. Pierre
4b5593c67f
window: Make the x/y position in the requested_rect more accurate
...
For gravity-based resizing, we need to make sure that the requested
rectangle has the proper x/y position given by the gravity resize,
rather than the bogus root_x_nw / root_y_nw parameter.
Make the test for this more explicit.
2014-05-01 17:59:50 -04:00
Jasper St. Pierre
acb3dc6754
window: Move adjust_for_gravity to window-x11
...
This removes the weirdness about which edge cases are where in the
move_resize_internal API, and we now always pass in client top-left
coordinates.
2014-05-01 17:59:49 -04:00
Jasper St. Pierre
4c21a46452
window: Move the session restoration and post-manage move_resize to window-x11
2014-05-01 17:59:49 -04:00
Jasper St. Pierre
900ae2c1fa
window: Remove the borders parameter from adjust_for_gravity
...
We can simply use the existing cached borders.
2014-05-01 17:59:49 -04:00
Jasper St. Pierre
01b6445708
window: Simplify adjust_for_gravity
2014-05-01 17:59:49 -04:00
Jasper St. Pierre
292d502205
window: Fix typo in comment
2014-05-01 17:59:49 -04:00
Jasper St. Pierre
adf2e44a82
core: Remove a few unused meta_core functions
2014-05-01 17:59:48 -04:00
Piotr Drąg
b075d576a0
Updated POTFILES.skip
...
mutter-wayland may be dead, but src/mutter-wayland.desktop.in file
is alive and kicking.
2014-04-30 22:10:42 +02:00
Florian Müllner
a7665a3e05
Bump version to 3.13.1
...
Update NEWS.
2014-04-30 18:14:27 +02:00
Florian Müllner
d2e40273ae
Update POTFILES
...
mutter-wayland is dead, long live mutter!
2014-04-30 18:14:27 +02:00
Jasper St. Pierre
d456e68375
keybindings: Fix another place we unfreeze on the wrong xdisplay
2014-04-30 09:32:51 -04:00
Jasper St. Pierre
03efa3ccbc
keybindings: Make sure to unfreeze the keyboard on the right xdisplay
...
This fixes keybindings getting "stuck" after being activated in
X11 compositor mode.
2014-04-30 09:32:51 -04:00
Jasper St. Pierre
2101c8357b
Move sync_request_* handling mostly to window-x11
2014-04-29 17:58:23 -04:00
Jasper St. Pierre
575963bee7
window: Turn grab_op_begin / grab_op_ended into vfuncs
...
And move the grab_resize_popup management to the X11 window class,
as this is only used under X11.
2014-04-29 17:58:22 -04:00
Jasper St. Pierre
7726001d43
window: Simplify resize_popup handling
2014-04-29 17:58:22 -04:00
Jasper St. Pierre
e382a4b560
window: Replace manual switch statement for a resizing grab op
2014-04-29 17:58:22 -04:00
Jasper St. Pierre
70713cc7db
window: Add some hooks for when grab ops begin / end on windows
2014-04-29 17:58:22 -04:00
Jasper St. Pierre
417090f3fa
window: Remove some superfluous uses of window->xwindow
2014-04-29 17:58:21 -04:00
Jasper St. Pierre
9fcc57cdec
core: Remove unused function
2014-04-29 17:58:21 -04:00
Jasper St. Pierre
7bf0c77193
window: Move _NET_WM_ALLOWED_ACTIONS setting to window-x11 as well
2014-04-29 17:58:21 -04:00
Jasper St. Pierre
f2328f1105
window: Move meta_window_move_resize_request to window-x11
2014-04-29 17:58:21 -04:00
Florian Müllner
d9a2443e53
Fix crash when cursor theme lookup failed
...
meta_cursor_reference_from_theme() may return %NULL on failure,
in which case we currently crash when trying to release it.
2014-04-29 22:20:03 +02:00
Jasper St. Pierre
b773898a60
window-wayland: Fix resizing from the top/left once more
...
Restoring the position in our move_resize_internal implementation
is too late. We need to do it at ack-time, before we hand off the
new position to the constraints code.
2014-04-28 18:22:55 -04:00
Jasper St. Pierre
8461b2c910
window: Move move_resize_wayland to window-wayland.c
...
The move/resize logic is still busted for top/left resizes... sigh.
2014-04-28 18:22:55 -04:00
Jasper St. Pierre
9b760dbbab
window: Remove unused condition
...
IS_WAYLAND_RESIZE will always result in a RESIZED result, at least.
2014-04-28 18:22:55 -04:00
Jasper St. Pierre
8b0747786a
window: Move X11 struts implementation to X11 codepath
2014-04-28 17:34:33 -04:00
Jasper St. Pierre
41235fcb86
keybindings: Remove now-unused meta_screen_grab_all_keys
2014-04-28 17:34:33 -04:00
Jasper St. Pierre
1d5b4e5b2f
display: Remove the same checks in end_grab_op
2014-04-28 17:34:32 -04:00
Jasper St. Pierre
6e8d1d79d1
display: Make sure to retrieve the toplevel transient for
...
If we have multiple modal stacked dialogs, move the top one, not
the immediate parent, which heavily confuses mutter.
2014-04-28 17:34:32 -04:00
Jasper St. Pierre
7cefe91c3c
display: Fix tiling when grabbing an attached dialog
...
It seems we used the wrong variable by accident
2014-04-28 17:34:32 -04:00
Jasper St. Pierre
1ef6a5542a
display: Remove extraneous checks for grab_window
...
We assert a few lines down anyway, so just move the asserts up
and kill the if statement.
2014-04-28 17:34:32 -04:00
Jasper St. Pierre
bc0f7def47
display: Clean up whitespace
2014-04-28 17:34:31 -04:00
Jasper St. Pierre
f0175d1234
window: Don't reset pending_compositor_effect too early
...
With our surface_mapped strategy, implement_showing might not
change whether the window has been shown or not, and thus we
might end up clearing pending_compositor_effect before the window
is mapped.
Only clear pending_compositor_effect when the effect has actually
been used.
2014-04-28 16:59:34 -04:00
Jasper St. Pierre
eb0c4db46d
keyboard: Don't use a grab interface for sending key events
2014-04-28 16:30:51 -04:00
Jasper St. Pierre
19e97ec567
keyboard: Remove start_grab / end_grab
...
It's unused.
2014-04-28 16:30:50 -04:00
Jasper St. Pierre
ce5c029509
window-wayland: Make sure to save where the position for server-initiated resizes
...
For the server-initiated resize case, like unmaximize or some forms
of tiling, we dropped the x/y of the server-assigned rectangle on the
floor, which meant the surface didn't move to where it needed to be in
that case. Now, save it internally, and combine it with the dx/dy passed
in during attaches to figure out where we actually need to be.
Make sure to only use it for when we send out a configure notify. We
should use the passed in rectangle for other scenarios, like a
client-initiated resize.
This fixes incorrect surface placement after unmaximization.
2014-04-28 16:23:38 -04:00
Jasper St. Pierre
647743aa5f
Revert "window-wayland: Don't enter the only-moving path for Wayland
...
resizes"
We're going to use the old code structure now.
This reverts commit 23ae11043f
.
2014-04-28 16:23:38 -04:00
Jasper St. Pierre
e94f169d4e
Revert "window-wayland: Make sure to save where the position for server-initiated resizes"
...
This is wrong for client-initiated resizes now.
This reverts commit e6b0525c70
.
2014-04-28 16:23:38 -04:00
Jasper St. Pierre
e6b0525c70
window-wayland: Make sure to save where the position for server-initiated resizes
...
For the server-initiated resize case, like unmaximize or some forms
of tiling, we dropped the x/y of the server-assigned rectangle on the
floor, which meant the surface didn't move to where it needed to be in
that case. Now, save it internally, and combine it with the dx/dy passed
in during attaches to figure out where we actually need to be.
This fixes incorrect surface placement after unmaximization.
2014-04-28 16:11:10 -04:00
Jasper St. Pierre
23ae11043f
window-wayland: Don't enter the only-moving path for Wayland resizes
...
We'll be adding additional code here for "correct" moving soon, so
we need to make sure not to do it for Wayland resizes.
2014-04-28 16:11:09 -04:00
Jasper St. Pierre
78657dafca
window-wayland: Clean up a bit
2014-04-28 16:11:09 -04:00
Jasper St. Pierre
0f47eae33a
window-wayland: Split an if statement in two
2014-04-28 16:11:09 -04:00