surround the XDeleteProperty() call with a

2006-10-01  Elijah Newren  <newren gmail com>

	* src/window-props.c (set_title_text): surround the
	XDeleteProperty() call with a
	meta_error_trap_push/meta_error_trap_pop pair to prevent a crash
	when closing a remote instance of gedit (and perhaps other apps).
	#358514.
This commit is contained in:
Elijah Newren 2006-10-01 21:36:10 +00:00 committed by Elijah Newren
parent b694312f1c
commit 79eb53bd53
2 changed files with 16 additions and 3 deletions

View File

@ -1,3 +1,11 @@
2006-10-01 Elijah Newren <newren gmail com>
* src/window-props.c (set_title_text): surround the
XDeleteProperty() call with a
meta_error_trap_push/meta_error_trap_pop pair to prevent a crash
when closing a remote instance of gedit (and perhaps other apps).
#358514.
2006-10-01 Elijah Newren <newren gmail com>
Fix longstanding focus bug with mouse (not sloppy) focus mode with

View File

@ -22,6 +22,7 @@
#include <config.h>
#include "window-props.h"
#include "errors.h"
#include "xprops.h"
#include "frame.h"
#include "group.h"
@ -248,9 +249,13 @@ set_title_text (MetaWindow *window,
/* Bug 330671 -- Don't forget to clear _NET_WM_VISIBLE_(ICON_)NAME */
if (!modified && previous_was_modified)
XDeleteProperty (window->display->xdisplay,
window->xwindow,
atom);
{
meta_error_trap_push (window->display);
XDeleteProperty (window->display->xdisplay,
window->xwindow,
atom);
meta_error_trap_pop (window->display, FALSE);
}
return modified;
}