remove redundant _cogl_clip_stack_dirty() api

The only place we were calling _cogl_clip_stack_dirty() was when
changing the current draw_buffer which also implies a change in
the current clip stack. _cogl_clip_stack_flush() would already
be able to quickly determine that the clip stack has changed by
checking ctx->current_clip_stack so there isn't really any need
to explicitly mark the clip_stack state as dirty.

Reviewed-by: Neil Roberts <neil@linux.intel.com>
This commit is contained in:
Robert Bragg 2011-11-21 17:37:41 +00:00
parent 104a6be84c
commit 6d1bf9a0d4
3 changed files with 0 additions and 17 deletions

View File

@ -1003,15 +1003,3 @@ _cogl_clip_stack_flush (CoglClipStack *stack,
ctx->current_clip_stack_uses_stencil = using_stencil_buffer; ctx->current_clip_stack_uses_stencil = using_stencil_buffer;
} }
void
_cogl_clip_stack_dirty (void)
{
_COGL_GET_CONTEXT (ctx, NO_RETVAL);
if (ctx->current_clip_stack_valid)
{
ctx->current_clip_stack_valid = FALSE;
_cogl_clip_stack_unref (ctx->current_clip_stack);
}
}

View File

@ -215,7 +215,4 @@ _cogl_clip_stack_ref (CoglClipStack *stack);
void void
_cogl_clip_stack_unref (CoglClipStack *stack); _cogl_clip_stack_unref (CoglClipStack *stack);
void
_cogl_clip_stack_dirty (void);
#endif /* __COGL_CLIP_STACK_H */ #endif /* __COGL_CLIP_STACK_H */

View File

@ -1102,8 +1102,6 @@ notify_buffers_changed (CoglFramebuffer *old_draw_buffer,
ctx->dirty_bound_framebuffer = 1; ctx->dirty_bound_framebuffer = 1;
ctx->dirty_gl_viewport = 1; ctx->dirty_gl_viewport = 1;
_cogl_clip_stack_dirty ();
if (old_draw_buffer && new_draw_buffer) if (old_draw_buffer && new_draw_buffer)
{ {
/* If the two draw framebuffers have a different color mask then /* If the two draw framebuffers have a different color mask then