isa/mutter
1
0
Fork 0
mirror of https://github.com/brl/mutter.git synced 2024-11-22 08:00:42 -05:00
Code Issues Packages Projects Releases Wiki Activity

wayland: Use right sign for workspace ID

Browse Source 
We get a signed integer (-1 meaning "no workspace specified"), store it in
an unsigned integer, check for >= 0 (of course it is!) and set as the window
workspace (signed integer, -1 meaning "show on all workspaces"). What could
possibly go wrong?

https://gitlab.gnome.org/GNOME/mutter/merge_requests/639
This commit is contained in:
Carlos Garnacho 2019-06-23 20:24:58 +02:00 committed by Jonas Ådahl
parent 740a62044e
commit 181c7cab32
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/wayland/meta-wayland-gtk-shell.c
View File

@ -172,7 +172,8 @@ gtk_surface_request_focus (struct wl_client *client,
if (sequence) if (sequence)
{ {
uint32_t timestamp, workspace_idx; uint32_t timestamp;
int32_t workspace_idx;
workspace_idx = meta_startup_sequence_get_workspace (sequence); workspace_idx = meta_startup_sequence_get_workspace (sequence);
timestamp = meta_startup_sequence_get_timestamp (sequence); timestamp = meta_startup_sequence_get_timestamp (sequence);