From 181c7cab328e33600b2c5c9b3d0f79678aebbdd4 Mon Sep 17 00:00:00 2001 From: Carlos Garnacho Date: Sun, 23 Jun 2019 20:24:58 +0200 Subject: [PATCH] wayland: Use right sign for workspace ID We get a signed integer (-1 meaning "no workspace specified"), store it in an unsigned integer, check for >= 0 (of course it is!) and set as the window workspace (signed integer, -1 meaning "show on all workspaces"). What could possibly go wrong? https://gitlab.gnome.org/GNOME/mutter/merge_requests/639 --- src/wayland/meta-wayland-gtk-shell.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/wayland/meta-wayland-gtk-shell.c b/src/wayland/meta-wayland-gtk-shell.c index cbbe9d5f9..6c6652884 100644 --- a/src/wayland/meta-wayland-gtk-shell.c +++ b/src/wayland/meta-wayland-gtk-shell.c @@ -172,7 +172,8 @@ gtk_surface_request_focus (struct wl_client *client, if (sequence) { - uint32_t timestamp, workspace_idx; + uint32_t timestamp; + int32_t workspace_idx; workspace_idx = meta_startup_sequence_get_workspace (sequence); timestamp = meta_startup_sequence_get_timestamp (sequence);