isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Read-only mirror of https://gitlab.gnome.org/GNOME/gnome-shell
17,273 Commits 179 Branches 237 Tags 67 MiB
C 49.2%
JavaScript 47.4%
SCSS 1.4%
Meson 0.8%
Python 0.6%
Other 0.4%
2326721561
Go to file
Alessandro Bono 2326721561 appDisplay: Connect to hidden signal after content initialization 
When the overview is hidden just after starting GNOME Shell the app
grid is not populated yet. Thus, this._grid.nPages is 0. When the
overview is about to be hidden, we call goToPage(0) on the AppGrid.
This results in pageNumber being clamped to -1 and leads to the
following exception:

```
JS ERROR: Exception in callback for signal: hidden: Error: Page -2 does not exist at IconGrid
getItemsAtPage@resource:///org/gnome/shell/ui/iconGrid.js:1383:19
_translatePreviousPageIcons@resource:///org/gnome/shell/ui/appDisplay.js:323:34
_syncPageIndicators@resource:///org/gnome/shell/ui/appDisplay.js:396:14
goToPage@resource:///org/gnome/shell/ui/appDisplay.js:445:14
goToPage@resource:///org/gnome/shell/ui/appDisplay.js:1237:29
goToPage@resource:///org/gnome/shell/ui/appDisplay.js:1584:15
_init/<@resource:///org/gnome/shell/ui/appDisplay.js:1328:52
_emit@resource:///org/gnome/gjs/modules/core/_signals.js:89:42
_hideDone@resource:///org/gnome/shell/ui/overview.js:589:18
_animateNotVisible/<@resource:///org/gnome/shell/ui/overview.js:566:55
onStopped@resource:///org/gnome/shell/ui/overviewControls.js:753:21
_makeEaseCallback/<@resource:///org/gnome/shell/ui/environment.js:150:22
_easeActorProperty/<@resource:///org/gnome/shell/ui/environment.js:316:60
```

Connect to the overview hidden signal only after initializing the
AppDisplay content, so that goToPage(0) is not called when there
is no page yet.

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/5837
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2536>
2022-11-16 17:06:32 +00:00
.gitlab/issue_templates Add a link to supported releases in the README and bug template 2021-03-03 14:47:20 +00:00
.gitlab-ci ci: Try falling back to stable branch before HEAD 2022-07-04 17:47:36 +02:00
.settings Clean out some eclipse artefacts 2019-02-13 04:39:26 +01:00
data screenshot: Move HAVE_RECORDER check into screencast service 2022-11-04 09:51:20 +00:00
docs/reference build: Replace deprecated meson functions 2021-12-23 15:52:21 +00:00
js appDisplay: Connect to hidden signal after content initialization 2022-11-16 17:06:32 +00:00
lint lint: Transition to gjs' object spacing rule 2022-07-18 21:54:22 +00:00
man man: Update options 2020-12-28 02:25:17 +01:00
meson build: Use meson's gnome.post_install() 2021-12-23 15:52:21 +00:00
po Update Russian translation 2022-11-13 14:43:34 +00:00
src shell/app-system: Retrack windows if necessary 2022-10-18 19:20:26 +00:00
subprojects Bump version to 43.1 2022-11-04 11:19:53 +01:00
tests cleanup: Use deepUnpack() intead of deep_unpack() 2022-08-10 10:29:24 +00:00
tools *: Fix spelling mistakes found by codespell 2020-08-21 18:25:09 +00:00
.eslintrc.yml init: Set console log domain 2021-09-01 14:55:47 +00:00
.gitignore Add small gnome-shell-extension-prefs script 2020-04-28 00:06:19 +02:00
.gitlab-ci.yml ci: Bump image 2022-09-01 15:52:48 +00:00
.gitmodules git: Always use libgnome-volume-control submodule from GNOME group 2022-08-04 18:31:16 +02:00
.jscheckignore init: Set console log domain 2021-09-01 14:55:47 +00:00
config.h.meson build: Do not redefine polkit autocleanup 2022-05-17 14:04:01 +00:00
COPYING Changed obsolete FSF postal address. 2014-01-08 04:35:14 +07:00
gnome-shell.doap gnome-shell.doap: Make marge-bot a maintainer 2020-11-17 17:29:56 +00:00
HACKING.md *: Fix spelling mistakes found by codespell 2020-08-21 18:25:09 +00:00
meson_options.txt build: Default to soup3 2022-06-21 19:29:02 +00:00
meson.build Bump version to 43.1 2022-11-04 11:19:53 +01:00
NEWS Bump version to 43.1 2022-11-04 11:19:53 +01:00
README.md readme: Change "GNOME 3" to "GNOME" 2021-08-11 14:41:15 +00:00

README.md

GNOME Shell

GNOME Shell provides core user interface functions for the GNOME desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience.

For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see the project wiki.

Bugs should be reported to the GNOME bug tracking system. Please refer to the Schedule wiki page to see the supported versions.

Contributing

To contribute, open merge requests at https://gitlab.gnome.org/GNOME/gnome-shell.

Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.

Default branch

The default development branch is main. If you still have a local checkout under the old name, use:

git checkout master
git branch -m master main
git fetch
git branch --unset-upstream
git branch -u origin/main
git symbolic-ref refs/remotes/origin/HEAD refs/remotes/origin/main

License

GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.