isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

calendar: Unbind settings when destroying

Browse Source 
Running dispose on the setting causes issues when we're being destroyed,
as the signal handler in the GSettings binding will be cleared by the
GObject itself before it has the chance, resulting in warnings.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1349>
This commit is contained in:
Jonas Ådahl 2022-08-17 15:53:45 +02:00
parent 7f4db052a0
commit fa47a7576d
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
js/ui/calendar.js
View File

@ -908,7 +908,7 @@ class DoNotDisturbSwitch extends PopupMenu.Switch {
Gio.SettingsBindFlags.INVERT_BOOLEAN); Gio.SettingsBindFlags.INVERT_BOOLEAN);
this.connect('destroy', () => { this.connect('destroy', () => {
this._settings.run_dispose(); Gio.Settings.unbind(this, 'state');
this._settings = null; this._settings = null;
}); });
} }