From fa47a7576d8bef93b95715165837ce9eee7d75fa Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jonas=20=C3=85dahl?= <jadahl@gmail.com>
Date: Wed, 17 Aug 2022 15:53:45 +0200
Subject: [PATCH] calendar: Unbind settings when destroying

Running dispose on the setting causes issues when we're being destroyed,
as the signal handler in the GSettings binding will be cleared by the
GObject itself before it has the chance, resulting in warnings.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1349>
---
 js/ui/calendar.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/js/ui/calendar.js b/js/ui/calendar.js
index 84bdaeea8..985153663 100644
--- a/js/ui/calendar.js
+++ b/js/ui/calendar.js
@@ -908,7 +908,7 @@ class DoNotDisturbSwitch extends PopupMenu.Switch {
             Gio.SettingsBindFlags.INVERT_BOOLEAN);
 
         this.connect('destroy', () => {
-            this._settings.run_dispose();
+            Gio.Settings.unbind(this, 'state');
             this._settings = null;
         });
     }