isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

appDisplay: Fall back to app name in icon menu

Browse Source 
The app icon's context menu contains a list of open windows,
identified by their title. As we currently don't handle the
case where the app didn't set a title, we end up with empty
menu items which looks clearly broken. Fall back to the app's
name in that case.

https://gitlab.gnome.org/GNOME/gnome-shell/issues/26
This commit is contained in:
Florian Müllner 2018-02-20 18:16:52 +01:00 committed by Jonas Ådahl
parent 44894262f4
commit f0557ea05c
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
js/ui/appDisplay.js
View File

@ -1870,7 +1870,9 @@ var AppIconMenu = new Lang.Class({
this._appendSeparator(); this._appendSeparator();
separatorShown = true; separatorShown = true;
} }
let item = this._appendMenuItem(window.title); let title = window.title ? window.title
: this._source.app.get_name();
let item = this._appendMenuItem(title);
item.connect('activate', () => { item.connect('activate', () => {
this.emit('activate-window', window); this.emit('activate-window', window);
}); });