From f0557ea05c0912ee8d8941b1e903606c39f8ee11 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Tue, 20 Feb 2018 18:16:52 +0100 Subject: [PATCH] appDisplay: Fall back to app name in icon menu The app icon's context menu contains a list of open windows, identified by their title. As we currently don't handle the case where the app didn't set a title, we end up with empty menu items which looks clearly broken. Fall back to the app's name in that case. https://gitlab.gnome.org/GNOME/gnome-shell/issues/26 --- js/ui/appDisplay.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js index 74c772d50..2c4d2d1da 100644 --- a/js/ui/appDisplay.js +++ b/js/ui/appDisplay.js @@ -1870,7 +1870,9 @@ var AppIconMenu = new Lang.Class({ this._appendSeparator(); separatorShown = true; } - let item = this._appendMenuItem(window.title); + let title = window.title ? window.title + : this._source.app.get_name(); + let item = this._appendMenuItem(title); item.connect('activate', () => { this.emit('activate-window', window); });