isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

modemManager: Add property getters

Browse Source 
gjs improved its default property getter/setters, and as a result it
is no longer possible to set read-only properties.

Add proper getters (backed by private properties) to fix the resulting
errors.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3203
This commit is contained in:
Popax21 2020-10-15 15:14:55 +00:00 committed by Florian Müllner
parent 62d0c3a661
commit 461bbcff15
1 changed files with 20 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
js/misc/modemManager.js
View File

@ -111,17 +111,33 @@ var ModemBase = GObject.registerClass({
0, 100, 0),
},
}, class ModemBase extends GObject.Object {
_init() {
super._init();
this._operatorName = null;
this._signalQuality = 0;
}
// eslint-disable-next-line camelcase
get operator_name() {
return this._operatorName;
}
// eslint-disable-next-line camelcase
get signal_quality() {
return this._signalQuality;
}
_setOperatorName(operatorName) {
if (this.operator_name == operatorName)
if (this._operatorName == operatorName)
return;
this.operator_name = operatorName;
this._operatorName = operatorName;
this.notify('operator-name');
}
_setSignalQuality(signalQuality) {
if (this.signal_quality == signalQuality)
if (this._signalQuality == signalQuality)
return;
this.signal_quality = signalQuality;
this._signalQuality = signalQuality;
this.notify('signal-quality');
}
});