isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

iconGrid: Remove unreachable code

Browse Source 
Throwing an exception already aborts a function, so there's no need
for a return statement in that case.

Spotted by eslint.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/375
This commit is contained in:
Florian Müllner 2019-01-29 23:00:46 +01:00 committed by Florian Müllner
parent 4f76e05058
commit 37e0a73c8f
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
js/ui/iconGrid.js
View File

@ -906,10 +906,8 @@ var PaginatedIconGrid = GObject.registerClass({
getItemPage(item) { getItemPage(item) {
let children = this._getVisibleChildren(); let children = this._getVisibleChildren();
let index = children.indexOf(item); let index = children.indexOf(item);
if (index == -1) { if (index == -1)
throw new Error('Item not found.'); throw new Error('Item not found.');
return 0;
}
return Math.floor(index / this._childrenPerPage); return Math.floor(index / this._childrenPerPage);
} }
@ -924,10 +922,9 @@ var PaginatedIconGrid = GObject.registerClass({
openExtraSpace(sourceItem, side, nRows) { openExtraSpace(sourceItem, side, nRows) {
let children = this._getVisibleChildren(); let children = this._getVisibleChildren();
let index = children.indexOf(sourceItem.actor); let index = children.indexOf(sourceItem.actor);
if (index == -1) { if (index == -1)
throw new Error('Item not found.'); throw new Error('Item not found.');
return;
}
let pageIndex = Math.floor(index / this._childrenPerPage); let pageIndex = Math.floor(index / this._childrenPerPage);
let pageOffset = pageIndex * this._childrenPerPage; let pageOffset = pageIndex * this._childrenPerPage;