From 37e0a73c8fe25123b341ecdd49ed3ae4604d0506 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Florian=20M=C3=BCllner?= Date: Tue, 29 Jan 2019 23:00:46 +0100 Subject: [PATCH] iconGrid: Remove unreachable code Throwing an exception already aborts a function, so there's no need for a return statement in that case. Spotted by eslint. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/375 --- js/ui/iconGrid.js | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/js/ui/iconGrid.js b/js/ui/iconGrid.js index cd54d50a3..452dc0c96 100644 --- a/js/ui/iconGrid.js +++ b/js/ui/iconGrid.js @@ -906,10 +906,8 @@ var PaginatedIconGrid = GObject.registerClass({ getItemPage(item) { let children = this._getVisibleChildren(); let index = children.indexOf(item); - if (index == -1) { + if (index == -1) throw new Error('Item not found.'); - return 0; - } return Math.floor(index / this._childrenPerPage); } @@ -924,10 +922,9 @@ var PaginatedIconGrid = GObject.registerClass({ openExtraSpace(sourceItem, side, nRows) { let children = this._getVisibleChildren(); let index = children.indexOf(sourceItem.actor); - if (index == -1) { + if (index == -1) throw new Error('Item not found.'); - return; - } + let pageIndex = Math.floor(index / this._childrenPerPage); let pageOffset = pageIndex * this._childrenPerPage;