isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

messageTray: Make clear item insensetive when there is nothing to clear

Browse Source 
There is no point in having a menu entry that does nothing so set the item
to insensitive when there are no items to clear.
This commit is contained in:
Adel Gadllah 2013-02-13 13:08:28 +01:00
parent cdc8dd88e9
commit 2138fc2349
1 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
js/ui/messageTray.js
View File

@ -1457,8 +1457,9 @@ const MessageTrayContextMenu = new Lang.Class({
Main.uiGroup.add_actor(this._dummy); Main.uiGroup.add_actor(this._dummy);
this.parent(this._dummy, 0, St.Side.BOTTOM); this.parent(this._dummy, 0, St.Side.BOTTOM);
this._tray = tray;
this.addAction(_("Clear"), function() { this._clearItem = this.addAction(_("Clear"), function() {
let toDestroy = []; let toDestroy = [];
let sources = tray.getSources(); let sources = tray.getSources();
for (let i = 0; i < sources.length; i++) { for (let i = 0; i < sources.length; i++) {
@ -1478,6 +1479,10 @@ const MessageTrayContextMenu = new Lang.Class({
tray.close(); tray.close();
}); });
tray.connect('source-added', Lang.bind(this, this._updateClearSensitivity));
tray.connect('source-removed', Lang.bind(this, this._updateClearSensitivity));
this._updateClearSensitivity();
let separator = new PopupMenu.PopupSeparatorMenuItem(); let separator = new PopupMenu.PopupSeparatorMenuItem();
this.addMenuItem(separator); this.addMenuItem(separator);
@ -1485,6 +1490,14 @@ const MessageTrayContextMenu = new Lang.Class({
settingsItem.connect('activate', function() { tray.close(); }); settingsItem.connect('activate', function() { tray.close(); });
}, },
_updateClearSensitivity: function() {
let sources = this._tray.getSources();
sources = sources.filter(function(source) {
return !source.trayIcon && !source.isChat && !source.resident;
});
this._clearItem.setSensitive(sources.length > 0);
},
setPosition: function(x, y) { setPosition: function(x, y) {
this._dummy.set_position(x, y); this._dummy.set_position(x, y);
} }