isa/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

messageTray: Remove an extraneous show

Browse Source 
This means that the close button also does not have to be public.
This commit is contained in:
Jasper St. Pierre 2013-08-02 00:38:59 -04:00
parent 0007343175
commit 12b7e56261
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
js/ui/messageTray.js
View File

@ -1406,12 +1406,12 @@ const SummaryItem = new Lang.Class({
this.notificationStackView.add_actor(this.notificationStack); this.notificationStackView.add_actor(this.notificationStack);
this.notificationStackWidget.add_actor(this.notificationStackView); this.notificationStackWidget.add_actor(this.notificationStackView);
this.closeButton = Util.makeCloseButton(); this._closeButton = Util.makeCloseButton();
this.closeButton.connect('clicked', Lang.bind(this, function() { this._closeButton.connect('clicked', Lang.bind(this, function() {
source.destroy(); source.destroy();
source.emit('done-displaying-content'); source.emit('done-displaying-content');
})); }));
this.notificationStackWidget.add_actor(this.closeButton); this.notificationStackWidget.add_actor(this._closeButton);
this._stackedNotifications = []; this._stackedNotifications = [];
this._oldMaxScrollAdjustment = 0; this._oldMaxScrollAdjustment = 0;
@ -2666,12 +2666,8 @@ const MessageTray = new Lang.Class({
if (this._clickedSummaryItemMouseButton == 1) { if (this._clickedSummaryItemMouseButton == 1) {
// Acknowledge all our notifications // Acknowledge all our notifications
summaryItem.source.notifications.forEach(function(n) { n.acknowledged = true; }); summaryItem.source.notifications.forEach(function(n) { n.acknowledged = true; });
child = summaryItem.notificationStackWidget;
let closeButton = summaryItem.closeButton;
closeButton.show();
summaryItem.prepareNotificationStackForShowing(); summaryItem.prepareNotificationStackForShowing();
child = summaryItem.notificationStackWidget;
} else if (this._clickedSummaryItemMouseButton == 3) { } else if (this._clickedSummaryItemMouseButton == 3) {
child = summaryItem.rightClickMenu; child = summaryItem.rightClickMenu;
} }