From 12b7e56261b46d93581b5b722d336a2244a51293 Mon Sep 17 00:00:00 2001 From: "Jasper St. Pierre" Date: Fri, 2 Aug 2013 00:38:59 -0400 Subject: [PATCH] messageTray: Remove an extraneous show This means that the close button also does not have to be public. --- js/ui/messageTray.js | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js index 7b61d11b6..250c11295 100644 --- a/js/ui/messageTray.js +++ b/js/ui/messageTray.js @@ -1406,12 +1406,12 @@ const SummaryItem = new Lang.Class({ this.notificationStackView.add_actor(this.notificationStack); this.notificationStackWidget.add_actor(this.notificationStackView); - this.closeButton = Util.makeCloseButton(); - this.closeButton.connect('clicked', Lang.bind(this, function() { + this._closeButton = Util.makeCloseButton(); + this._closeButton.connect('clicked', Lang.bind(this, function() { source.destroy(); source.emit('done-displaying-content'); })); - this.notificationStackWidget.add_actor(this.closeButton); + this.notificationStackWidget.add_actor(this._closeButton); this._stackedNotifications = []; this._oldMaxScrollAdjustment = 0; @@ -2666,12 +2666,8 @@ const MessageTray = new Lang.Class({ if (this._clickedSummaryItemMouseButton == 1) { // Acknowledge all our notifications summaryItem.source.notifications.forEach(function(n) { n.acknowledged = true; }); - - child = summaryItem.notificationStackWidget; - - let closeButton = summaryItem.closeButton; - closeButton.show(); summaryItem.prepareNotificationStackForShowing(); + child = summaryItem.notificationStackWidget; } else if (this._clickedSummaryItemMouseButton == 3) { child = summaryItem.rightClickMenu; }