brl
0 Followers · 0 Following
  • Joined on 2024-03-31
Repositories
7
 Projects Packages Code Public Activity Starred Repositories
brl commented on pull request brl/citadel-tools#4 2024-08-30 15:29:03 +00:00
Improve error handling by using std lib rust code

Ooops, you forgot to replace a libcitadel::error::Error the 'improved' version and everything still works when you return it. Are you still sure rewriting everything was what you needed to do?

brl commented on pull request brl/citadel-tools#4 2024-08-30 15:29:03 +00:00
Improve error handling by using std lib rust code

Why did you rewrite this? Why is this buried in a massive commit described vaguely as "improve error handling"?

brl commented on pull request brl/citadel-tools#4 2024-08-30 15:29:03 +00:00
Improve error handling by using std lib rust code

Uh..... you want to panic instead of just exiting cleanly and printing an error message?

brl commented on pull request brl/citadel-tools#4 2024-08-30 15:29:03 +00:00
Improve error handling by using std lib rust code

When you mix reformatting changes in with code changes then I have to read the reformatting changes very carefully to make sure you haven't changed anything.

brl commented on pull request brl/citadel-tools#4 2024-08-30 15:29:03 +00:00
Improve error handling by using std lib rust code

Sorry, but no.

brl pushed to master at brl/citadel 2024-08-30 13:38:52 +00:00
88b412a18f Add citadel-installer-ui icon
brl merged pull request brl/citadel#12 2024-08-30 13:38:51 +00:00
Add citadel-installer-ui icon
brl merged pull request brl/citadel#11 2024-08-30 13:38:20 +00:00
Fix x1 touchpad not working
brl pushed to master at brl/citadel 2024-08-30 13:38:20 +00:00
277cac8eea Fix x1 touchpad not working
brl pushed to master at brl/citadel 2024-08-30 13:36:33 +00:00
4b73960043 Fix installer fails because missing kernel module
brl merged pull request brl/citadel#8 2024-08-30 13:36:32 +00:00
Fix installer fails because missing kernel module
brl pushed to master at brl/citadel 2024-08-30 13:35:48 +00:00
8eacade6bf Fix not able to change timezones
brl merged pull request brl/citadel#7 2024-08-30 13:35:47 +00:00
Fix not able to change timezones
brl pushed to master at brl/citadel 2024-08-30 13:34:25 +00:00
5dfd3e31db Add features to qemu script and support for other linux distros
brl merged pull request brl/citadel#6 2024-08-30 13:34:23 +00:00
Add features to qemu script and support for other linux distros
brl merged pull request brl/citadel#5 2024-07-17 11:01:44 +00:00
Build citadel-tools from the same git repo owner as citadel
brl pushed to master at brl/citadel 2024-07-17 11:01:44 +00:00
1dc36e94fc Build citadel-tools from the same git repo owner as citadel
brl pushed to master at brl/citadel 2024-07-17 11:00:47 +00:00
68dc48bcf7 Add subgraph mirror server
956661945e Improve build to fail hard if error occurs
038b25817b Update Dockerfile to build the current version of citadel
Compare 3 commits »
brl merged pull request brl/citadel#4 2024-07-17 11:00:45 +00:00
Basic changes to the citadel build process
brl pushed to master at brl/citadel-tools 2024-07-17 10:58:13 +00:00
b7e6ee3b3c Increase size of tmpfs to allow base-realmfs to decompress