brl/mutter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

text: Avoid changing the contents when possible

Browse Source 
An editable ClutterText will reset the selection and cursor whenever the
contents are changed — even if those contents are the same. As this may
confuse the user, we should check if we're setting the exact same string,
and bail out if necessary.
This commit is contained in:
Emmanuele Bassi 2012-02-07 11:36:27 +00:00
parent d509455de0
commit e7511dd469
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
clutter/clutter-text.c
View File

@ -4742,6 +4742,16 @@ clutter_text_set_text (ClutterText *self,
{
g_return_if_fail (CLUTTER_IS_TEXT (self));
/* if the text is editable (i.e. there is not markup flag to reset) then
* changing the contents will result in selection and cursor changes that
* we should avoid
*/
if (self->priv->editable)
{
if (strcmp (clutter_text_buffer_get_text (get_buffer (self)), text) == 0)
return;
}
clutter_text_set_use_markup_internal (self, FALSE);
clutter_text_buffer_set_text (get_buffer (self), text, -1);
}