brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
ee41dfdb8c
gnome-shell/js/ui
History
Robert Mader ee41dfdb8c ControlsManager: Propagate unmap before hiding the WorkspacesDisplay 
Hiding the `WorkspacesDisplay` triggers a reallocation of the
`ControlsManagerLayout` which can fail with the following error:
```
JS ERROR: TypeError: workspace is undefined
_getSpacing@resource:///org/gnome/shell/ui/workspacesView.js:229:13
vfunc_allocate@resource:///org/gnome/shell/ui/workspacesView.js:355:18
vfunc_allocate@resource:///org/gnome/shell/ui/overviewControls.js:200:33
vfunc_hide@resource:///org/gnome/shell/ui/workspacesView.js:1070:38
vfunc_unmap@resource:///org/gnome/shell/ui/overviewControls.js:672:33
hideOverview@resource:///org/gnome/shell/ui/layout.js:312:28
_hideDone@resource:///org/gnome/shell/ui/overview.js:617:32
onComplete@resource:///org/gnome/shell/ui/overview.js:390:37
_makeEaseCallback/<@resource:///org/gnome/shell/ui/environment.js:134:13
_easeActorProperty/<@resource:///org/gnome/shell/ui/environment.js:298:60
```

This can be reproduced by closing the overview with the three-finger
gesture.

Thus propagate the unmap before hiding the `WorkspacesDisplay`.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2088>
2022-01-09 16:50:48 +01:00
..
components keyring: Fix incorrect reference to the label instead of string 2021-11-17 10:19:08 +00:00
status docs: Use gender-neutral pronouns 2022-01-05 16:34:23 +01:00
accessDialog.js modalDialog: Consistently return correct boolean for open() in ModalDialogs 2021-11-17 10:24:47 +00:00
altTab.js
animation.js
appDisplay.js appDisplay: Remove leftover code from the spring animation 2022-01-02 16:24:14 +01:00
appFavorites.js
appMenu.js
audioDeviceSelection.js
background.js
backgroundMenu.js
barLevel.js
boxpointer.js boxpointer: Fix positioning with non-widget sources 2021-09-01 20:22:58 +00:00
calendar.js calendar-server: Remove the all-day property of events 2021-11-30 02:13:24 +00:00
checkBox.js
closeDialog.js
ctrlAltTab.js
dash.js dash: Fixes wrong separator position 2021-09-01 15:10:14 +00:00
dateMenu.js dateMenu: Port to GWeather 4.0 2022-01-05 04:07:25 +01:00
dialog.js
dnd.js
edgeDragAction.js
endSessionDialog.js
environment.js dateMenu: Port to GWeather 4.0 2022-01-05 04:07:25 +01:00
extensionDownloader.js cleanup: Replace non-standard ByteArray module 2021-09-01 14:49:30 +00:00
extensionSystem.js sessionMode: Drop allowExtensions property 2021-10-14 18:40:53 +00:00
focusCaretTracker.js
grabHelper.js
ibusCandidatePopup.js
iconGrid.js iconGrid: Remove unused spring animation code 2022-01-02 16:24:14 +01:00
inhibitShortcutsDialog.js
init.js init: Set console log domain 2021-09-01 14:55:47 +00:00
kbdA11yDialog.js
keyboard.js keyboard: Ensure chrome input region is updated after slide animation 2021-09-01 18:37:56 +02:00
layout.js layout: Removed unused method 2021-11-21 20:46:20 +00:00
lightbox.js Always assume GLSL is supported 2021-09-21 16:37:01 +02:00
locatePointer.js
lookingGlass.js
magnifier.js magnifier: Remove call to dropped Clutter::get_default_frame_rate() 2021-11-16 23:34:38 +00:00
main.js main: Don't terminate remote session in headless mode 2022-01-08 18:18:55 +00:00
messageList.js messageList: Give focus to next message on delete 2021-12-01 10:19:54 +00:00
messageTray.js messageTray: Close SHOWING banner when its notification is destroyed 2022-01-05 15:51:14 +00:00
modalDialog.js
mpris.js
notificationDaemon.js notificationDaemon: Fix sound-file support 2021-10-06 17:39:01 +00:00
osdMonitorLabeler.js
osdWindow.js
overview.js
overviewControls.js ControlsManager: Propagate unmap before hiding the WorkspacesDisplay 2022-01-09 16:50:48 +01:00
padOsd.js cleanup: Replace non-standard ByteArray module 2021-09-01 14:49:30 +00:00
pageIndicators.js
panel.js panel: Show warning indicator when unsafe-mode is on 2021-09-03 21:34:58 +00:00
panelMenu.js
pointerA11yTimeout.js
pointerWatcher.js
popupMenu.js
remoteSearch.js
ripples.js
runDialog.js modalDialog: Consistently return correct boolean for open() in ModalDialogs 2021-11-17 10:24:47 +00:00
screenShield.js docs: Use gender-neutral pronouns 2022-01-05 16:34:23 +01:00
screenshot.js util: Wait for initial name owners in DBusSenderCheck before checking 2021-12-04 16:57:25 +00:00
scripting.js
search.js search: Split out the description highlighter into its own class 2021-12-22 16:47:18 +00:00
searchController.js
sessionMode.js sessionMode: Drop allowExtensions property 2021-10-14 18:40:53 +00:00
shellDBus.js util: Wait for initial name owners in DBusSenderCheck before checking 2021-12-04 16:57:25 +00:00
shellEntry.js
shellMountOperation.js shellMountOperation: Remove unused volume monitor 2021-11-03 22:13:00 +00:00
slider.js
swipeTracker.js swipeTracker: Set up TouchSwipeGesture in the capture phase 2021-11-24 22:33:18 +00:00
switcherPopup.js
switchMonitor.js switchMonitor: Only show 'mirror' and 'join' modes when not a laptop 2021-12-04 16:21:31 +00:00
unlockDialog.js lockScreen: Don't wake up screen in DND mode 2021-12-23 17:20:49 +01:00
userWidget.js
welcomeDialog.js modalDialog: Consistently return correct boolean for open() in ModalDialogs 2021-11-17 10:24:47 +00:00
windowAttentionHandler.js
windowManager.js windowManager: Set correct unfullscreen gesture enabled state on startup 2022-01-06 04:53:23 +01:00
windowMenu.js
windowPreview.js
workspace.js workspace: Move fading minimized windows out of allocation 2021-09-01 15:02:47 +00:00
workspaceAnimation.js workspaceAnimation: Make WorkspaceGroup public 2021-12-22 18:27:07 +00:00
workspacesView.js js: Remove dead code in loginDialog and workspacesView 2022-01-05 15:44:28 +00:00
workspaceSwitcherPopup.js
workspaceThumbnail.js
xdndHandler.js