brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
b0be6b8678
gnome-shell/js/ui
History
Giovanni Campagna b0be6b8678 RemoteSearch: don't complete a search that was cancelled 
This closes a race between setTerms and a slow GetInitialResultSet.
The bug manifests as follows:
- initial search for a short string
- previous results === undefined, call GetInitialResultSet
- user types more, cancel previous search in setTerms()
- mainloop, then _gotResults([])
- previous results === [], !!previous results === true
- therefore call GetSubsearchResultSet with an empty list of results
- _gotResults() from GetSubsearchResultSet is empty
- much later, return from GetInitialResultSet is discarded by
  cancellable
- user unhappy because what he searched for is not there

After this fix, the flow is:
- initial search for a short string
- previous results === undefined, call GetInitialResultSet
- user types more, cancel previous search in setTerms()
- mainloop, but no _gotResults
- previous results === undefined, call GetInitialResultSet again with
  longer string
- some time later, return from first GetInitialResultSet is discarded
  by cancellable
- soon after, return from second GetInitialResultSet comes with good
  results
- user happy

https://bugzilla.gnome.org/show_bug.cgi?id=745861
2015-03-11 13:47:48 -07:00
..
components telepathyClient: Close overview and panel when activated 2015-03-11 01:17:57 +01:00
status Drop MESSAGE_TRAY action mode 2015-02-26 01:41:18 +01:00
altTab.js switcher: Remove some unused variables 2014-11-27 13:30:20 +00:00
animation.js st: always use GFile internally 2014-10-14 18:53:39 -07:00
appDisplay.js appDisplay: Don't call a non-existent onComplete 2015-03-04 19:01:41 +01:00
appFavorites.js appFavorites: Add gnome-boxes to the rename list 2014-09-16 17:14:36 +02:00
background.js BackgroundCache: plug an Animation object leak 2014-10-27 17:50:41 +01:00
backgroundMenu.js backgroundMenu: Allow for long presses on touch devices 2014-07-24 18:15:02 +02:00
boxpointer.js boxpointer: Add condition checks for -arrow-rise:0px 2014-01-15 18:28:31 +01:00
calendar.js calendar: Sync pointer after a message is removed 2015-03-11 21:15:53 +01:00
checkBox.js checkBox: Remove custom container implementation 2013-08-20 08:06:30 +02:00
ctrlAltTab.js StTextureCache: adapt to MetaWindow changing icon prop type 2015-01-13 15:58:45 +01:00
dash.js dash: Fix show-apps button drop target 2015-03-05 12:34:17 +01:00
dateMenu.js dateMenu: Set label_actor for WorldClock button 2015-03-04 13:57:30 +01:00
dnd.js js: Name all the timeouts and idles 2014-04-10 21:08:16 +02:00
edgeDragAction.js Rename KeyBindingMode to ActionMode 2014-12-19 11:39:50 +01:00
endSessionDialog.js endSessionDialog: Fix DialogContent const 2014-09-11 17:05:48 +01:00
environment.js environment: Define N_() globally 2014-11-13 12:26:33 +00:00
extensionDownloader.js theme: modal dialog headlines 2015-03-10 19:16:28 +01:00
extensionSystem.js theme: convert stylesheet loading to GFile 2014-10-14 18:54:00 -07:00
focusCaretTracker.js a11y: initialize atspi on demand 2014-06-20 14:32:55 +02:00
grabHelper.js grabHelper: Adjust to property name change 2014-08-28 19:49:51 +02:00
ibusCandidatePopup.js theme: a button is a button is a button 2015-02-20 15:16:06 +01:00
iconGrid.js iconGrid: Fix slowness on pulse animation for few items 2014-10-09 12:47:16 +02:00
keyboard.js keyboard: Delay caribou daemon invocation until really needed 2014-11-08 06:49:17 +09:00
layout.js messageTray: Take over trayBox from LayoutManager 2015-02-27 14:16:30 +01:00
legacyTray.js legacyTray: Allow extensions to hijack the tray-icon-added/removed signals 2015-03-06 13:47:47 +01:00
lightbox.js lightbox: Do not assume GLSL is available 2014-07-24 16:51:02 +02:00
lookingGlass.js lookingGlass: Remove ugly hack 2015-02-14 18:20:28 +01:00
magnifier.js Fix handling of SystemBackground 2014-10-16 17:16:06 -04:00
magnifierDBus.js Stringify the xml definitions for E4X removal 2013-10-25 08:57:27 +11:00
main.js main: Close calendar on activateWindow() 2015-03-10 22:41:52 +01:00
messageTray.js messageTray: Fix custom notification icons 2015-03-06 18:28:19 +01:00
modalDialog.js theme: a button is a button is a button 2015-02-20 15:16:06 +01:00
notificationDaemon.js NotificationDaemon: stop filtering notifications from empathy 2015-03-03 14:20:48 -08:00
osdMonitorLabeler.js Add an OSD monitor labeler exposed on DBus 2015-02-05 13:34:52 +01:00
osdWindow.js osdWindow: Check monitor validity before updating 2014-05-08 11:14:23 +02:00
overview.js overviewControls: Remove message indicator 2015-02-20 17:40:21 +01:00
overviewControls.js overviewControls: Remove message indicator 2015-02-20 17:40:21 +01:00
panel.js panel: Center app-menu label vertically 2015-03-04 20:54:49 +01:00
panelMenu.js panelMenu: Consider vertical margins when computing max-height 2015-02-15 10:23:39 +01:00
pointerWatcher.js js: Name all the timeouts and idles 2014-04-10 21:08:16 +02:00
popupMenu.js popupMenu: Center separators vertically 2015-03-06 19:01:46 +01:00
remoteMenu.js popupMenu: Remove our custom allocation code 2013-08-13 06:50:25 -04:00
remoteSearch.js RemoteSearch: don't complete a search that was cancelled 2015-03-11 13:47:48 -07:00
runDialog.js runDialog: Disable restart command on wayland 2015-03-03 20:09:06 +01:00
screencast.js screencast: Make it possible to disable draw-cursor 2015-02-17 08:35:24 +01:00
screenShield.js screenShield: Do not wake up screen after adding hidden source 2015-02-26 23:39:01 +01:00
screenshot.js screenshot: Respect lockdown settings 2014-10-03 17:08:56 +02:00
scripting.js shell-perf-helper: Add an option for continual redraws 2014-07-16 10:33:59 -04:00
search.js search: remove redundant check 2015-01-07 15:26:21 -08:00
separator.js js: Explicitly dispose all cairo contexts 2013-01-08 13:07:51 -05:00
sessionMode.js sessionMode: Don't set overridesSchema 2014-06-09 22:39:15 +02:00
shellDBus.js Add an OSD monitor labeler exposed on DBus 2015-02-05 13:34:52 +01:00
shellEntry.js shellEntry: Remove unused style class 2014-09-05 14:37:18 -07:00
shellMountOperation.js theme: modal dialog headlines 2015-03-10 19:16:28 +01:00
slider.js Lower slider scrolling step to 2% 2015-01-16 18:24:36 +01:00
switcherPopup.js switcher: Remove some unused variables 2014-11-27 13:30:20 +00:00
tweener.js tweener: Also consider delay when disabling animations 2014-08-19 19:46:44 +02:00
unlockDialog.js Rename KeyBindingMode to ActionMode 2014-12-19 11:39:50 +01:00
userWidget.js loginDialog: Pass-through UserWidget's label-actor 2015-03-06 17:24:13 +01:00
viewSelector.js viewSelector: Don't reset the search entry if it has preedit text 2015-03-04 15:25:35 +01:00
windowAttentionHandler.js messageTray: Make Notification._onClicked handler public 2015-02-20 17:39:25 +01:00
windowManager.js Revert "theme: use a global headline class" 2015-03-10 18:27:43 +01:00
windowMenu.js windowMenu: Only disable "Always on Top" for fully maximized 2014-09-25 23:10:03 +02:00
workspace.js workspace: Prevent overlapping windows when scaling to fit the screen 2015-03-03 23:00:10 +01:00
workspacesView.js WorkspacesDisplay: update the primary monitor index too 2015-02-05 13:34:52 +01:00
workspaceSwitcherPopup.js js: Name all the timeouts and idles 2014-04-10 21:08:16 +02:00
workspaceThumbnail.js windowManager: Split out workspace insertion from thumbnails 2015-01-16 19:28:56 +01:00
xdndHandler.js Remove use of superfluous MetaWindowActor APIs 2013-12-16 12:48:53 -05:00