Jonas Dreßler 118676bffb st/theme: Unref CRStylesheet after removing old theme nodes
Since we now remove all theme nodes on a stylesheet change (ie.
StTheme's "custom-stylesheets-changed" signal) instead of only
invalidating them, those nodes may not be accessed anymore as soon as
"custom-stylesheets-changed" is emitted.

It turned out though that when comparing them to the newly generated
nodes in `st_widget_recompute_style()` using the
`st_theme_node_paint/geometry_equal()` functions, the properties of the
old nodes will still be accessed, causing a crash since the
CRDeclarations are already freed.

To fix that, keep the reference to the CRStylesheet, which owns the
CRDeclarations used by the theme nodes, around a bit longer, so it's
still possible to access the CRDeclarations inside the
"custom-stylesheets-changed" signal handler. This allows us to compare
the old theme nodes to the new ones since the CSS properties of both are
still valid.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2709


(cherry picked from commit e06109c23ce2a6dd53d32c26a89ab46a952d7373)
2020-05-01 14:32:38 +00:00
..
2014-01-09 14:59:31 -05:00
2014-01-09 14:59:31 -05:00
2014-01-09 14:59:31 -05:00
2019-08-27 15:30:51 +03:00
2019-02-06 18:29:15 +01:00
2020-02-26 19:00:05 -08:00
2017-08-02 11:27:42 +01:00
2015-10-15 22:58:28 +02:00