gnome-shell/js/ui
Sebastian Keller 2801d0bfe3 messageTray: Close SHOWING banner when its notification is destroyed
Currently only banners in the SHOWN state are hidden when the underlying
notification is destroyed, but if they are in the SHOWING state, they
remain visible. Because the 'notification' member has already been set
to null when the notification got destroyed, closing the banner by
clicking on the close button, will not do anything and clicking on the
notification itself will result in an error message. For notifications
without a timeout, i.e. critical ones, this will result in an
uncloseable notification.

This can happen if the program creating a critical notification
immediately closes it again, as might happen with power notifications
from gnome-settings-daemon in some situations.

Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4855
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2079>
2022-01-05 15:51:14 +00:00
..
components keyring: Fix incorrect reference to the label instead of string 2021-11-17 10:19:08 +00:00
status docs: Use gender-neutral pronouns 2022-01-05 16:34:23 +01:00
accessDialog.js modalDialog: Consistently return correct boolean for open() in ModalDialogs 2021-11-17 10:24:47 +00:00
altTab.js altTab: Avoid allocation cycle when showing CyclerHighlight 2021-05-11 17:36:29 +02:00
animation.js st/widget: Remove get_resource_scale function 2020-06-30 13:42:18 +00:00
appDisplay.js appDisplay: Remove leftover code from the spring animation 2022-01-02 16:24:14 +01:00
appFavorites.js appFavorites: Add eog to rename list 2020-05-02 00:16:28 +02:00
appMenu.js appMenu: Support launching on the non-default GPU 2021-08-16 21:28:22 +00:00
audioDeviceSelection.js audioDeviceSelection: Ensure close() is called with no arguments 2021-04-19 19:12:59 +02:00
background.js background: Check xml mime type instead of extension 2021-04-16 19:53:53 +05:00
backgroundMenu.js
barLevel.js cleanup: Define GObject accessors in camelCase 2021-02-03 20:19:29 +01:00
boxpointer.js boxpointer: Fix positioning with non-widget sources 2021-09-01 20:22:58 +00:00
calendar.js calendar-server: Remove the all-day property of events 2021-11-30 02:13:24 +00:00
checkBox.js
closeDialog.js
ctrlAltTab.js ctrlAltTab: Fix usage of bind_cairo_surface_property 2021-03-08 09:21:25 +00:00
dash.js dash: Fixes wrong separator position 2021-09-01 15:10:14 +00:00
dateMenu.js dateMenu: Port to GWeather 4.0 2022-01-05 04:07:25 +01:00
dialog.js dialog: Ensure action callback is called with no arguments 2021-04-19 19:12:59 +02:00
dnd.js dnd: Immediately start drag done by pointer devices 2021-05-31 10:59:11 -03:00
edgeDragAction.js keyboard: Handle edge drag gesture cancellation 2021-02-17 15:45:01 +00:00
endSessionDialog.js endSessionDialog: Only show logout inhibiting apps 2021-02-24 15:31:03 +00:00
environment.js dateMenu: Port to GWeather 4.0 2022-01-05 04:07:25 +01:00
extensionDownloader.js cleanup: Replace non-standard ByteArray module 2021-09-01 14:49:30 +00:00
extensionSystem.js sessionMode: Drop allowExtensions property 2021-10-14 18:40:53 +00:00
focusCaretTracker.js
grabHelper.js grabHelper: Propagate events while this._ignoreUntilRelease 2021-05-11 16:13:49 +00:00
ibusCandidatePopup.js ibusCandidatePopup: Use plain actor as dummy cursor 2021-06-29 22:47:58 +02:00
iconGrid.js iconGrid: Remove unused spring animation code 2022-01-02 16:24:14 +01:00
inhibitShortcutsDialog.js cleanup: Use optional chaining and ?? operator 2020-12-02 15:10:29 +00:00
init.js init: Set console log domain 2021-09-01 14:55:47 +00:00
kbdA11yDialog.js cleanup: Remove empty leading/trailing lines in blocks 2020-11-16 18:04:23 +00:00
keyboard.js keyboard: Ensure chrome input region is updated after slide animation 2021-09-01 18:37:56 +02:00
layout.js layout: Removed unused method 2021-11-21 20:46:20 +00:00
lightbox.js Always assume GLSL is supported 2021-09-21 16:37:01 +02:00
locatePointer.js
lookingGlass.js lookingGlass: Use symbolic icons on the toolbar 2021-06-14 18:51:30 +00:00
magnifier.js magnifier: Remove call to dropped Clutter::get_default_frame_rate() 2021-11-16 23:34:38 +00:00
main.js main: Warn when unsafe mode is toggled 2021-11-26 16:14:39 +00:00
messageList.js messageList: Give focus to next message on delete 2021-12-01 10:19:54 +00:00
messageTray.js messageTray: Close SHOWING banner when its notification is destroyed 2022-01-05 15:51:14 +00:00
modalDialog.js
mpris.js mpris: Hide unused elements to leave more space for the title 2021-02-04 22:42:08 +00:00
notificationDaemon.js notificationDaemon: Fix sound-file support 2021-10-06 17:39:01 +00:00
osdMonitorLabeler.js
osdWindow.js
overview.js overview: Emit 'hidden' after it's *really* hidden 2021-08-19 15:44:34 +08:00
overviewControls.js ControlsManagerLayout: Allocate respecting the work area 2021-07-17 00:25:50 +02:00
padOsd.js cleanup: Replace non-standard ByteArray module 2021-09-01 14:49:30 +00:00
pageIndicators.js pageIndicators: Remove animated indicators 2021-02-03 09:55:29 +01:00
panel.js panel: Show warning indicator when unsafe-mode is on 2021-09-03 21:34:58 +00:00
panelMenu.js cleanup: Use optional chaining and ?? operator 2020-12-02 15:10:29 +00:00
pointerA11yTimeout.js
pointerWatcher.js js: Get idle monitor from backend 2021-05-18 13:42:52 +00:00
popupMenu.js popupMenu: Remove can_focus=True from Switch 2021-07-20 14:11:28 +02:00
remoteSearch.js remoteSearch: Fetch enabled/disabled list once 2021-04-02 19:07:56 +00:00
ripples.js
runDialog.js modalDialog: Consistently return correct boolean for open() in ModalDialogs 2021-11-17 10:24:47 +00:00
screenShield.js docs: Use gender-neutral pronouns 2022-01-05 16:34:23 +01:00
screenshot.js util: Wait for initial name owners in DBusSenderCheck before checking 2021-12-04 16:57:25 +00:00
scripting.js scripting: Switch to standard async/await pattern 2020-08-12 15:43:38 +00:00
search.js search: Split out the description highlighter into its own class 2021-12-22 16:47:18 +00:00
searchController.js searchController: Get rid of activePage reference in key handling 2021-02-17 02:31:32 +01:00
sessionMode.js sessionMode: Drop allowExtensions property 2021-10-14 18:40:53 +00:00
shellDBus.js util: Wait for initial name owners in DBusSenderCheck before checking 2021-12-04 16:57:25 +00:00
shellEntry.js shellEntry: Don't show "Show Password" menu if entry icon is disabled 2021-07-30 14:17:07 +00:00
shellMountOperation.js shellMountOperation: Remove unused volume monitor 2021-11-03 22:13:00 +00:00
slider.js
swipeTracker.js swipeTracker: Set up TouchSwipeGesture in the capture phase 2021-11-24 22:33:18 +00:00
switcherPopup.js cleanup: Remove empty leading/trailing lines in blocks 2020-11-16 18:04:23 +00:00
switchMonitor.js switchMonitor: Only show 'mirror' and 'join' modes when not a laptop 2021-12-04 16:21:31 +00:00
unlockDialog.js lockScreen: Don't wake up screen in DND mode 2021-12-23 17:20:49 +01:00
userWidget.js theme: Don't draw border around symbolic user-icon 2020-12-17 21:46:41 +01:00
welcomeDialog.js modalDialog: Consistently return correct boolean for open() in ModalDialogs 2021-11-17 10:24:47 +00:00
windowAttentionHandler.js
windowManager.js windowManager: Use one consistent animation mode for minimize/unminimize 2021-12-22 16:16:23 +00:00
windowMenu.js windowMenu: Use consistent terminology 2021-08-18 00:43:12 +02:00
windowPreview.js windowPreview: Make St.Label use single line mode 2021-04-28 14:29:19 +02:00
workspace.js workspace: Move fading minimized windows out of allocation 2021-09-01 15:02:47 +00:00
workspaceAnimation.js workspaceAnimation: Make WorkspaceGroup public 2021-12-22 18:27:07 +00:00
workspacesView.js js: Remove dead code in loginDialog and workspacesView 2022-01-05 15:44:28 +00:00
workspaceSwitcherPopup.js cleanup: Remove empty leading/trailing lines in blocks 2020-11-16 18:04:23 +00:00
workspaceThumbnail.js workspaceThumbnail: Destroy thumbnails on destruction 2021-05-25 12:43:32 -03:00
xdndHandler.js cleanup: Use optional chaining and ?? operator 2020-12-02 15:10:29 +00:00