Read-only mirror of https://gitlab.gnome.org/GNOME/gnome-shell
08d2ca300a
If you copy a theme node's paint state into itself, it should be an inexpensive no-op. What actually happened was that we destroyed the old paint state, re-initialized to blank, then copied the blank state back into itself. In the process, we lost (for instance) the textures for rounded corners. Until I introduced the texture cache, this never actually happened, because when st_widget_recompute_style() calls st_widget_get_theme_node(), we'd always get a fresh theme node. Now, we get a theme node T back from the cache, notice that paint_equal(T, T) is true, short-circuit slightly by copying its drawing state into itself, and destroy drawing state that we still needed. I'm going to fix this in recompute_style() too, but as a general principle, self-assignment ought to be harmless. Bug: https://bugzilla.gnome.org/show_bug.cgi?id=687465 Reviewed-by: Jasper St. Pierre <jstpierre@mecheye.net> |
||
|---|---|---|
| .settings | ||
| browser-plugin | ||
| data | ||
| docs | ||
| js | ||
| man | ||
| po | ||
| src | ||
| tests | ||
| tools | ||
| .gitignore | ||
| .project | ||
| AUTHORS | ||
| autogen.sh | ||
| configure.ac | ||
| COPYING | ||
| gnome-shell.doap | ||
| HACKING | ||
| MAINTAINERS | ||
| Makefile.am | ||
| NEWS | ||
| README | ||
GNOME Shell provides core user interface functions for the GNOME 3 desktop, like switching to windows and launching applications. GNOME Shell takes advantage of the capabilities of modern graphics hardware and introduces innovative user interface concepts to provide a visually attractive and easy to use experience. For more information about GNOME Shell, including instructions on how to build GNOME Shell from source and how to get involved with the project, see: http://live.gnome.org/GnomeShell Bugs should be reported at http://bugzilla.gnome.org against the 'gnome-shell' product. License ======= GNOME Shell is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for details.