brl/gnome-shell
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
070c784412
gnome-shell/js/ui
History
Joaquim Rocha 070c784412 polkitAgent: Use dialog as confirmation when the user has no password 
When a user has no password and a polkit authentication is started,
instead of blindly initiating the admin session, show the regular
"Authentication Requested" dialog (but without the password entry). This
makes sure that the user's admin session is only effectively started
after the user chooses to proceed with the authentication, which
provides an extra confirmation step that can be vital for critical
tasks.

To do this, we show the dialog inside `_onUserChanged()` right after the
dialog was created instead of calling `performAuthentication()` from
`_onInitiate()`. The bug mentioned in `_onInitiate()` is no longer an
issue since we show the dialog in all cases now anyway.

Ideally we should use a different wording than "authentication" when the
user has no password set, and use "confirmation" instead. However polkit
already sends the requests with such messages (e.g. "Authentication is
required to configure software repositories"), and it's important to
show those to the user, so this patch keeps the regular wording.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/829
2019-11-24 20:23:42 +01:00
..
components polkitAgent: Use dialog as confirmation when the user has no password 2019-11-24 20:23:42 +01:00
status power: Handle "100% but charging" case 2019-11-22 00:33:23 +01:00
accessDialog.js cleanup: Disambiguate assignments in arrow functions 2019-09-15 16:02:45 +02:00
altTab.js cleanup: Avoid unnecessary parentheses in arrow functions 2019-09-15 16:02:45 +02:00
animation.js animation: Add parameter for hiding stopped Spinner actor 2019-11-19 23:25:34 +02:00
appDisplay.js appDisplay: Add a timeout when switching pages during DnD 2019-11-24 20:18:42 +01:00
appFavorites.js cleanup: "Only" use two indentation styles for object literals 2019-09-12 23:18:24 +02:00
audioDeviceSelection.js cleanup: Disambiguate assignments in arrow functions 2019-09-15 16:02:45 +02:00
background.js cleanup: "Only" use two indentation styles for object literals 2019-09-12 23:18:24 +02:00
backgroundMenu.js backgroundMenu: Animate menu opening 2019-09-11 23:25:21 +00:00
barLevel.js barLevel: Remove duplicated assignment 2019-08-13 16:35:17 +02:00
boxpointer.js cleanup: Don't add linebreak before operators 2019-09-15 16:02:45 +02:00
calendar.js cleanup: Avoid unnecessary parentheses in arrow functions 2019-09-15 16:02:45 +02:00
checkBox.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
closeDialog.js closeDialog: Fix dialog size when using geometry scaling 2019-11-22 00:30:23 +01:00
ctrlAltTab.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
dash.js js: Replace Tweener time leftovers with ease duration 2019-10-10 02:14:28 +02:00
dateMenu.js cleanup: Disambiguate assignments in arrow functions 2019-09-15 16:02:45 +02:00
dialog.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
dnd.js dnd: Skip drag target when its acceptDrop() throws an exception 2019-10-24 23:08:08 +00:00
edgeDragAction.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
endSessionDialog.js cleanup: "Only" use two indentation styles for object literals 2019-09-12 23:18:24 +02:00
environment.js environment: Only disable unredirection of ongoing transitions 2019-10-14 08:54:20 +00:00
extensionDownloader.js cleanup: "Only" use two indentation styles for object literals 2019-09-12 23:18:24 +02:00
extensionSystem.js cleanup: Avoid pointless "renames" in destructuring 2019-09-15 16:02:45 +02:00
focusCaretTracker.js cleanup: Prefer template strings 2019-07-05 11:32:31 +00:00
grabHelper.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
ibusCandidatePopup.js ibusCandidatePopup: Use an internal actor to track IM focus position 2019-10-08 17:12:43 +00:00
iconGrid.js appDisplay: Add API to animate launch at given position 2019-09-18 17:14:16 +00:00
inhibitShortcutsDialog.js cleanup: Use consistent style for ternary operator 2019-09-15 13:30:19 +00:00
kbdA11yDialog.js cleanup: Fix wrong indentation 2019-09-15 13:30:19 +00:00
keyboard.js keyboard: Try harder to find a matching layout 2019-11-23 00:38:53 +00:00
layout.js layout: Don't use the actors pick workaround on update regions 2019-09-20 16:05:32 +00:00
lightbox.js lightbox: Show the actor before easing it 2019-10-03 15:26:13 +02:00
locatePointer.js locatePointer: Bind ripples creation to settings 2019-09-09 19:28:18 +00:00
lookingGlass.js js: Replace Tweener time leftovers with ease duration 2019-10-10 02:14:28 +02:00
magnifier.js magnifier: Do not modify function argument 2019-09-15 16:02:45 +02:00
magnifierDBus.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
main.js main, util: Notify systemd once we are fully initialised 2019-10-04 15:40:05 +00:00
messageList.js js: Ease non-animatable actor properties 2019-08-06 23:54:29 +02:00
messageTray.js cleanup: Remove trailing spaces 2019-09-15 16:02:45 +02:00
modalDialog.js cleanup: Disambiguate assignments in arrow functions 2019-09-15 16:02:45 +02:00
mpris.js cleanup: Use consistent style for ternary operator 2019-09-15 13:30:19 +00:00
notificationDaemon.js cleanup: Remove trailing spaces 2019-09-15 16:02:45 +02:00
osdMonitorLabeler.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
osdWindow.js cleanup: Stop using Mainloop module 2019-09-12 19:09:24 +02:00
overview.js overview: Fix fading out desktop icons 2019-09-14 14:05:12 +02:00
overviewControls.js cleanup: Use consistent style for ternary operator 2019-09-15 13:30:19 +00:00
padOsd.js style: Disable camelcase rule for GObject properties 2019-07-24 00:28:45 +02:00
pageIndicators.js cleanup: Use consistent style for ternary operator 2019-09-15 13:30:19 +00:00
panel.js panel: Update window section items on title changes 2019-11-22 01:33:45 +01:00
panelMenu.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
pointerA11yTimeout.js cleanup: Remove left-over imports 2019-09-11 20:59:31 +00:00
pointerWatcher.js cleanup: Stop using Mainloop module 2019-09-12 19:09:24 +02:00
popupMenu.js popupMenu: Add focusActor property to define the default focus actor 2019-09-20 15:53:42 +00:00
remoteSearch.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
ripples.js cleanup: Disambiguate assignments in arrow functions 2019-09-15 16:02:45 +02:00
runDialog.js cleanup: Avoid unnecessary parentheses in arrow functions 2019-09-15 16:02:45 +02:00
screencast.js cleanup: Use destructuring for imports from GI 2019-02-09 07:39:20 +01:00
screenShield.js screenShield: Replace child properties 2019-11-23 00:19:26 +00:00
screenshot.js cleanup: Switch some method calls to new indentation style 2019-09-15 13:30:19 +00:00
scripting.js scripting: Disable an eslint warning 2019-09-15 16:02:45 +02:00
search.js cleanup: Use consistent style for ternary operator 2019-09-15 13:30:19 +00:00
sessionMode.js cleanup: Use consistent style for ternary operator 2019-09-15 13:30:19 +00:00
shellDBus.js shellDBus: Don't assume devices have a node 2019-10-07 21:24:13 +00:00
shellEntry.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
shellMountOperation.js animation: Turn Spinner animate parameter into Params option 2019-11-19 23:25:29 +02:00
slider.js slider: Unset signal IDs when ending the slider drag 2019-09-22 22:20:41 +00:00
switcherPopup.js switcherPopup: Fix last commit 2019-11-23 01:05:31 +01:00
switchMonitor.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
tweener.js tweener: Use new adjustAnimationTime() helper 2019-08-06 20:50:43 +02:00
unlockDialog.js unlockDialog: Use inheritance instead of composition 2019-09-20 16:58:00 +00:00
userWidget.js userWidget: Handle non-square icons gracefully 2019-07-29 16:16:22 +00:00
viewSelector.js viewSelector: Only reset search entry if it has key focus 2019-09-18 15:56:26 +00:00
windowAttentionHandler.js cleanup: Mark globals used from other modules as exported 2019-07-24 00:28:45 +02:00
windowManager.js windowManager: Replace left-over calls to _removeEffect() 2019-11-11 22:39:58 +01:00
windowMenu.js cleanup: Avoid unnecessary parentheses in arrow functions 2019-09-15 16:02:45 +02:00
workspace.js workspace: Sort windows in overview grid using cached center 2019-10-17 08:07:22 +00:00
workspacesView.js cleanup: Disambiguate assignments in arrow functions 2019-09-15 16:02:45 +02:00
workspaceSwitcherPopup.js cleanup: Stop using Mainloop module 2019-09-12 19:09:24 +02:00
workspaceThumbnail.js appDisplay: Animate DnD app icons at the position they were dropped 2019-09-18 17:14:16 +00:00
xdndHandler.js cleanup: Mark unused (but useful) variables as ignored 2019-07-24 00:28:45 +02:00