magnifier: Do not modify function argument
The intention of the code is clearly to operate on a copy, but that's not how the Object constructor works. While it doesn't matter in practice that we modify the passed-in object parameter, it's still a good idea to fix the code. https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/731
This commit is contained in:
parent
2546445884
commit
8d6820c4df
@ -264,7 +264,7 @@ var Magnifier = class Magnifier {
|
||||
zoomRegion.setViewPort(viewPort);
|
||||
|
||||
// We ignore the redundant width/height on the ROI
|
||||
let fixedROI = new Object(roi);
|
||||
let fixedROI = Object.create(roi);
|
||||
fixedROI.width = viewPort.width / xMagFactor;
|
||||
fixedROI.height = viewPort.height / yMagFactor;
|
||||
zoomRegion.setROI(fixedROI);
|
||||
|
Loading…
Reference in New Issue
Block a user